Project

General

Profile

Actions

Bug #865

closed

Fonction setFBinMask erronée

Added by Veronique bouzid almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Immediate
Category:
R3+
Target version:
-
Start date:
29/12/2016
Due date:
% Done:

0%

Estimated time:
revision:
r0

Description

Pour avancer sur l'analyse du bug #864 , je me suis permise de récuperer ta fonction setFBinMask et de la tester unitairement.

1- Cette boucle est erronée , la derniere valeur de k doit etre 2 et non 3
for (k = 0; k <= 3; k++) {
bin = binToRemove[k];

--> la declaration du tableau est int binToRemove[ 3 ];
Si on a 3 bins à enlever tu vas superposer 4 masques.


Related issues

Related to Bug #862: Valeurs des masques RW erronées dans TM_LFR_PARAMETER_DUMPClosedbruno katra28/12/2016

Actions
Actions #1

Updated by Veronique bouzid almost 8 years ago

  • Subject changed from Fonction setFBinMask erronnée to Fonction setFBinMask erronée
Actions #2

Updated by bruno katra almost 8 years ago

  • Description updated (diff)
Actions #3

Updated by bruno katra almost 8 years ago

  • Related to Bug #862: Valeurs des masques RW erronées dans TM_LFR_PARAMETER_DUMP added
Actions #4

Updated by Alexis Jeandet almost 8 years ago

J'ai testé avec le FSW corrigé et le bug semble disparaitre:

diff -r b4928c7e1920 src/tc_load_dump_parameters.c
--- a/src/tc_load_dump_parameters.c    Wed Jul 13 15:44:16 2016 +0200
+++ b/src/tc_load_dump_parameters.c    Mon Jan 02 17:23:55 2017 +0100
@@ -1053,7 +1053,7 @@
         binToRemove[2] = -1;
     }

-    for (k = 0; k <= 3; k++)
+    for (k = 0; k < 3; k++)
     {
         bin = binToRemove[k];
         if ( (bin >= 0) && (bin <= 127) )

Actions #5

Updated by paul leroy almost 8 years ago

  • Status changed from New to Resolved
  • Assignee changed from paul leroy to Veronique bouzid

exact, un signe = malheureux est resté dans la boucle for
c'est corrigé pour fsw >= 3.1.0.5

Actions #6

Updated by Veronique bouzid almost 8 years ago

  • Status changed from Resolved to Closed

Bug corrigé en 3.1.0.6.
Voir #867

Actions

Also available in: Atom PDF