HG_REPOSITORIES/LPP/SciQLOP_Repos/SciQLop Commit - r673:09db2d1144f0

Adapts SqpIterator to make non-const iterators

Alexandre Leroux -

r673:09db2d1144f0

parent child

Context file:

r673:09db2d1144f0

Collapse all files

core/include/Data/ArrayData.h +51 -5

                 }
             };
+            template <int Dim, bool IsConst>
+            class IteratorValue;
+            template <int Dim, bool IsConst>
+            struct IteratorValueBuilder {
+            };
+            template <int Dim>
+            struct IteratorValueBuilder<Dim, true> {
+                using DataContainerIterator = DataContainer::const_iterator;
+            };
             template <int Dim>
+            struct IteratorValueBuilder<Dim, false> {
+                using DataContainerIterator = DataContainer::iterator;
+            };
+            template <int Dim, bool IsConst>
             class IteratorValue : public ArrayDataIteratorValue::Impl {
             public:
+                friend class ArrayData<Dim>;
+                friend class IteratorValueBuilder<Dim, IsConst>;
+                using DataContainerIterator =
+                    typename IteratorValueBuilder<Dim, IsConst>::DataContainerIterator;
+                template <bool IC = IsConst, typename = std::enable_if_t<IC == true> >
                 explicit IteratorValue(const DataContainer &container, int nbComponents, bool begin)
                         : m_It{begin ? container.cbegin() : container.cend()}, m_NbComponents{nbComponents}
                 {
                 }
+                template <bool IC = IsConst, typename = std::enable_if_t<IC == false> >
+                explicit IteratorValue(DataContainer &container, int nbComponents, bool begin)
+                        : m_It{begin ? container.begin() : container.end()}, m_NbComponents{nbComponents}
+                {
+                }
                 IteratorValue(const IteratorValue &other) = default;
                 std::unique_ptr<ArrayDataIteratorValue::Impl> clone() const override
                 {
-                    return std::make_unique<IteratorValue<Dim> >(*this);
+                    return std::make_unique<IteratorValue<Dim, IsConst> >(*this);
                 }
                 bool equals(const ArrayDataIteratorValue::Impl &other) const override try {
                 }
             private:
-                DataContainer::const_iterator m_It;
+                DataContainerIterator m_It;
                 int m_NbComponents;
             };
                 // Iterators //
                 // ///////// //
+                ArrayDataIterator begin()
+                {
+                    return ArrayDataIterator{
+                        ArrayDataIteratorValue{std::make_unique<arraydata_detail::IteratorValue<Dim, false> >(
+                            m_Data, m_NbComponents, true)}};
+                }
+                ArrayDataIterator end()
+                {
+                    return ArrayDataIterator{
+                        ArrayDataIteratorValue{std::make_unique<arraydata_detail::IteratorValue<Dim, false> >(
+                            m_Data, m_NbComponents, false)}};
+                }
                 ArrayDataIterator cbegin() const
                 {
-                    return ArrayDataIterator{ArrayDataIteratorValue{
+                    return ArrayDataIterator{
-                        std::make_unique<arraydata_detail::IteratorValue<Dim> >(m_Data, m_NbComponents, true)}};
+                        ArrayDataIteratorValue{std::make_unique<arraydata_detail::IteratorValue<Dim, true> >(
+                            m_Data, m_NbComponents, true)}};
                 }
                 ArrayDataIterator cend() const
                 {
                     return ArrayDataIterator{
-                        ArrayDataIteratorValue{std::make_unique<arraydata_detail::IteratorValue<Dim> >(
+                        ArrayDataIteratorValue{std::make_unique<arraydata_detail::IteratorValue<Dim, true> >(
                             m_Data, m_NbComponents, false)}};
                 }

core/include/Data/DataSeries.h +27 -4

             namespace dataseries_detail {
-            template <int Dim>
+            template <int Dim, bool IsConst>
             class IteratorValue : public DataSeriesIteratorValue::Impl {
             public:
+                friend class DataSeries<Dim>;
+                template <bool IC = IsConst, typename = std::enable_if_t<IC == false> >
+                explicit IteratorValue(DataSeries<Dim> &dataSeries, bool begin)
+                        : m_XIt(begin ? dataSeries.xAxisData()->begin() : dataSeries.xAxisData()->end()),
+                          m_ValuesIt(begin ? dataSeries.valuesData()->begin() : dataSeries.valuesData()->end())
+                {
+                }
+                template <bool IC = IsConst, typename = std::enable_if_t<IC == true> >
                 explicit IteratorValue(const DataSeries<Dim> &dataSeries, bool begin)
                         : m_XIt(begin ? dataSeries.xAxisData()->cbegin() : dataSeries.xAxisData()->cend()),
                           m_ValuesIt(begin ? dataSeries.valuesData()->cbegin()
                                            : dataSeries.valuesData()->cend())
                 {
                 }
                 IteratorValue(const IteratorValue &other) = default;
                 std::unique_ptr<DataSeriesIteratorValue::Impl> clone() const override
                 {
-                    return std::make_unique<IteratorValue<Dim> >(*this);
+                    return std::make_unique<IteratorValue<Dim, IsConst> >(*this);
                 }
                 bool equals(const DataSeriesIteratorValue::Impl &other) const override try {
                 // Iterators //
                 // ///////// //
+                DataSeriesIterator begin() override
+                {
+                    return DataSeriesIterator{DataSeriesIteratorValue{
+                        std::make_unique<dataseries_detail::IteratorValue<Dim, false> >(*this, true)}};
+                }
+                DataSeriesIterator end() override
+                {
+                    return DataSeriesIterator{DataSeriesIteratorValue{
+                        std::make_unique<dataseries_detail::IteratorValue<Dim, false> >(*this, false)}};
+                }
                 DataSeriesIterator cbegin() const override
                 {
                     return DataSeriesIterator{DataSeriesIteratorValue{
-                        std::make_unique<dataseries_detail::IteratorValue<Dim> >(*this, true)}};
+                        std::make_unique<dataseries_detail::IteratorValue<Dim, true> >(*this, true)}};
                 }
                 DataSeriesIterator cend() const override
                 {
                     return DataSeriesIterator{DataSeriesIteratorValue{
-                        std::make_unique<dataseries_detail::IteratorValue<Dim> >(*this, false)}};
+                        std::make_unique<dataseries_detail::IteratorValue<Dim, true> >(*this, false)}};
                 }
                 /// @sa IDataSeries::minXAxisData()

core/include/Data/IDataSeries.h +2 0

                 virtual DataSeriesIterator cbegin() const = 0;
                 virtual DataSeriesIterator cend() const = 0;
+                virtual DataSeriesIterator begin() = 0;
+                virtual DataSeriesIterator end() = 0;
                 /// @return the iterator to the first entry of the data series whose x-axis data is greater than
                 /// or equal to the value passed in parameter, or the end iterator if there is no matching value

core/include/Data/SqpIterator.h +4 -2

                     return *this;
                 }
-                pointer operator->() const { return &m_CurrentValue; }
+                const T *operator->() const { return &m_CurrentValue; }
-                reference operator*() const { return m_CurrentValue; }
+                const T &operator*() const { return m_CurrentValue; }
+                T *operator->() { return &m_CurrentValue; }
+                T &operator*() { return m_CurrentValue; }
                 bool operator==(const SqpIterator &other) const
                 {

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages