HG_REPOSITORIES/LPP/INSTRUMENTATION/USERS/JEANDET/qtcharts Commit - r2400:37aa57c82a3a

0

src/animations/axisanimation.cpp 0 -6

              {
                  if (state() != QAbstractAnimation::Stopped) stop();
-             //  TODO: cannot return even if layout is empty
-             //  New layout is not set properly without it (crash)
-             //    if (newLayout.count() == 0)
-             //        return;
                  switch (m_type) {
                  case ZoomOutAnimation: {
                      QRectF rect = m_axis->gridGeometry();
              {
                  if (state() != QAbstractAnimation::Stopped) { //workaround
                      QVector<qreal> vector = qvariant_cast<QVector<qreal> >(value);
-             //        Q_ASSERT(vector.count() != 0);
                      m_axis->setLayout(vector);
                      m_axis->updateGeometry();
                  }

0

src/areachart/areachartitem.cpp +1 -3

              QTCOMMERCIALCHART_BEGIN_NAMESPACE
-             //TODO: optimize : remove points which are not visible
              AreaChartItem::AreaChartItem(QAreaSeries *areaSeries, QGraphicsItem* item)
-                 : ChartItem(areaSeries->d_func(),item), //TODO: fix me
+                 : ChartItem(areaSeries->d_func(),item),
                    m_series(areaSeries),
                    m_upper(0),
                    m_lower(0),

0

src/areachart/qareaseries.cpp +1 -2

              {
                  Q_D(QAreaSeries);
                  if(d->m_upperSeries!=series){
-                 	d->m_upperSeries = series;
-                 	//TODO:
+                 	d->m_upperSeries = series;
-                 }
              }

0

src/axis/barcategoryaxis/qbarcategoryaxis.cpp +2 -6

                          } else if (d->m_maxCategory == category) {
                              setRange(d->m_minCategory, d->m_categories.last());
                          } else {
-                             d->updateCategoryDomain();
-                             //TODO:: d->emitUpdated();
+                             d->updateCategoryDomain();
-                         }
                      } else {
                          setRange(QString::null, QString::null);
                  } else if (index == count) {
                      setRange(d->m_minCategory, d->m_categories.last());
                  } else {
-                     d->updateCategoryDomain();
-                     //TODO:: d->emitUpdated();
+                     d->updateCategoryDomain();
-                 }
                  emit categoriesChanged();
                          setRange(newCategory, d->m_maxCategory);
                      } else if (d->m_maxCategory == oldCategory) {
                          setRange(d->m_minCategory, newCategory);
-                     } else {
-                         //TODO:: d->emitUpdated();
                      }
                      emit categoriesChanged();
                      emit countChanged();

0

src/axis/categoryaxis/chartcategoryaxisx.cpp +1 -2

              }
              void ChartCategoryAxisX::updateGeometry()
+             {
-                 //TODO: this is not optimal when many categories :( , create only visible lables
+             {
-                 setLabels(m_axis->categoriesLabels() << "");
                  HorizontalAxis::updateGeometry();
              }

0

src/axis/categoryaxis/chartcategoryaxisy.cpp +1 -2

              void ChartCategoryAxisY::handleAxisUpdated()
              {
-                 updateGeometry();
-                 //TODO:: ChartAxis::handleAxisUpdated();
+                 updateGeometry();
              }
              QSizeF ChartCategoryAxisY::sizeHint(Qt::SizeHint which, const QSizeF &constraint) const

0

src/axis/categoryaxis/qcategoryaxis.cpp +2 -4

                              range.first = d->m_categoriesMap.value(d->m_categories.at(labelIndex - 1)).second;
                              d->m_categoriesMap.insert(label, range);
                          }
+                     }
-                     //TODO:: d->emitUpdated();
+                     }
-                 }
              }
                      d->m_categories.replace(labelIndex, newLabel);
                      Range range = d->m_categoriesMap.value(oldLabel);
                      d->m_categoriesMap.remove(oldLabel);
-                     d->m_categoriesMap.insert(newLabel, range);
-                     //TODO:: d->emitUpdated();
+                     d->m_categoriesMap.insert(newLabel, range);
-                 }
              }

0

src/axis/chartaxis.cpp 0 -5

              QStringList ChartAxis::createValueLabels(qreal min, qreal max, int ticks,const QString& format)
              {
-                 //TODO: Q_ASSERT(m_max > m_min);
-                 //TODO: Q_ASSERT(ticks > 1);
                  QStringList labels;
                  if(max <= min || ticks < 1){
              QStringList ChartAxis::createDateTimeLabels(qreal min, qreal max,int ticks,const QString& format)
              {
-                 //TODO: Q_ASSERT(m_max > m_min);
-                 //TODO: Q_ASSERT(ticks > 1);
                  QStringList labels;
                  if(max <= min || ticks < 1) {

0

src/axis/qabstractaxis.cpp +3 -6

                  return d_ptr->m_axisPen;
              }
-             //TODO: remove me
              void QAbstractAxis::setLinePenColor(QColor color)
              {
                  QPen p = d_ptr->m_axisPen;
              {
                  return d_ptr->m_labelsAngle;
              }
-             //TODO: remove me
              void QAbstractAxis::setLabelsColor(QColor color)
              {
                  QBrush b = d_ptr->m_labelsBrush;
              /*!
                Returns the orientation in which the axis is being used (Vertical or Horizontal)
              */
-             // NOTE: should have const but it breaks BC:
-             // http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Change_the_CV-qualifiers_of_a_member_function
              Qt::Orientation QAbstractAxis::orientation()
              {
                  return d_ptr->orientation();
                      if (forced || brush == m_labelsBrush){
                          q_ptr->setLabelsBrush(theme->labelBrush());
                      }
-                     //TODO: introduce axis brush
                      if (forced || brush == m_titleBrush){
                          q_ptr->setTitleBrush(theme->labelBrush());
                      }
                      if (forced || font == m_labelsFont){
                      	q_ptr->setLabelsFont(theme->labelFont());
                      }
-                     //TODO: discuss with Tero
                      if (forced || font == m_titleFont){
                          QFont font(m_labelsFont);
                          font.setBold(true);

0

src/axis/qabstractaxis.h +2 -2

                  Q_PROPERTY(bool labelsVisible READ labelsVisible WRITE setLabelsVisible NOTIFY labelsVisibleChanged)
                  Q_PROPERTY(QPen labelsPen READ labelsPen WRITE setLabelsPen NOTIFY labelsPenChanged)
                  Q_PROPERTY(QBrush labelsBrush READ labelsBrush WRITE setLabelsBrush NOTIFY labelsBrushChanged)
-                 //TODO: fix labels angles to work with layout
                  Q_PROPERTY(int labelsAngle READ labelsAngle WRITE setLabelsAngle NOTIFY labelsAngleChanged)
                  Q_PROPERTY(QFont labelsFont READ labelsFont WRITE setLabelsFont NOTIFY labelsFontChanged)
                  Q_PROPERTY(QColor labelsColor READ labelsColor WRITE setLabelsColor NOTIFY labelsColorChanged)
                  void setShadesBorderColor(QColor color);
                  QColor shadesBorderColor() const;
-                 Qt::Orientation orientation(); //TODO: missing const <- BC
+                 Qt::Orientation orientation();
                  Qt::Alignment alignment() const;
                  //range handling

0

src/axis/valueaxis/qvalueaxis.h +1 -1

                  void setLabelFormat(const QString &format);
                  QString labelFormat() const;
-                 //TODO: depreciated !
                  void setNiceNumbersEnabled(bool enable = true);
                  bool niceNumbersEnabled() const;

0

src/axis/valueaxis/qvalueaxis_p.h +1 -1

                  int m_tickCount;
                  QString m_format;
                  bool m_applying;
-                 bool m_niceNumbersEnabled; //TODO: this depreciated
+                 bool m_niceNumbersEnabled;
                  Q_DECLARE_PUBLIC(QValueAxis)
              };

0

src/chartthememanager.cpp 0 -3

                      qreal h = color.hsvHueF();
                      qreal s = color.hsvSaturationF();
-                     // TODO: tune the algorithm to give nice results with most base colors defined in
-                     // most themes. The rest of the gradients we can define manually in theme specific
-                     // implementation.
                      QColor start = color;
                      start.setHsvF(h, 0.0, 1.0);
                      g.setColorAt(0.0, start);

0

src/legend/qlegendmarker_p.h +1 -1

              QTCOMMERCIALCHART_BEGIN_NAMESPACE
-             // TODO: check these
              class QAbstractSeries;
              class QAreaSeries;
              class QXYSeries;

0

src/qabstractseries.cpp 0 -5

                  return d_ptr->m_chart;
              }
-             //void QAbstractSeries::adjustView()
-             //{
-             //    //TODO:
-             //}
              /*!
                  \brief Sets the visibility of the series to true

0

src/qchart.cpp 0 -11

              {
                  d_ptr->m_legend = new LegendScroller(this);
                  setTheme(QChart::ChartThemeLight);
-                 //TODO: what is that ?
-                 //connect(d_ptr->m_presenter, SIGNAL(marginsChanged(QRectF)), this, SIGNAL(marginsChanged(QRectF)));
                  setLayout(d_ptr->m_presenter->layout());
              }
                  return d_ptr->m_presenter->geometry();
              }
-             ///*!
-             //    TODO: Dummy.
-             //    Adjest the ranges of the axes so that all the data of the specified \a series is visible
-             // */
-             //void QChart::adjustViewToSeries(QAbstractSeries* series)
-             //{
-             //    //
-             //}
              /*!
               Sets animation \a options for the chart
               */

0

src/scatterchart/scatterchartitem.cpp +1 -2

                  m_shape = m_series->markerShape();
                  setOpacity(m_series->opacity());
-                 if (recreate) {
-                     // TODO: optimize handleUpdate to recreate points only in case shape changed
+                 if (recreate) {
-                     deletePoints(count);
                      createPoints(count);

0

src/xychart/xychart.cpp 0 -2

              QTCOMMERCIALCHART_BEGIN_NAMESPACE
-             //TODO: optimize : remove points which are not visible
              XYChart::XYChart(QXYSeries *series,QGraphicsItem* item):
                    ChartItem(series->d_func(),item),
                    m_series(series),

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages