##// END OF EJS Templates
HG_REPOSITORIES » LPP » INSTRUMENTATION » USERS » JEANDET » qtcharts
RSS

Clone from http://code.qt.io/qt/qtcharts.git

Fix axis geometry when there is no axis title...
Fix axis geometry when there is no axis title SizeHint won't include title padding when there is no title, yet updateGeometry() always assumed it was there when determining space for labels, causing truncated labels when title was missing. Also made missing/empty/hidden axis title work consistently. Now axis geometries should be updated correctly always when title text or visibility status changes. Task-number: QTRD-1903 Reviewed-by: Mika Salmela
Miikka Heikkinen - - Load All Authors

File last commit:

r2412:38736d0999b4
r2415:65ea14fdb747
Show More
chartlogvalueaxisx.cpp
137 lines | 4.2 KiB | text/x-c | CppLexer
/ src / axis / logvalueaxis / chartlogvalueaxisx.cpp
History | Source | Raw |Copy content |Copy permalink
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274 /****************************************************************************
**
** Copyright (C) 2012 Digia Plc
** All rights reserved.
** For any questions to Digia, please use contact form at http://qt.digia.com
**
** This file is part of the Qt Commercial Charts Add-on.
**
** $QT_BEGIN_LICENSE$
** Licensees holding valid Qt Commercial licenses may use this file in
** accordance with the Qt Commercial License Agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia.
**
** If you have questions regarding the use of this file, please use
** contact form at http://qt.digia.com
** $QT_END_LICENSE$
**
****************************************************************************/
#include "chartlogvalueaxisx_p.h"
#include "chartpresenter_p.h"
#include "qlogvalueaxis.h"
#include "chartlayout_p.h"
#include <QGraphicsLayout>
#include <QFontMetrics>
#include <qmath.h>
Michal Klocek
Fixes missing layout updated on ticks,base and format calls
 r2333 #include <QDebug>
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274
QTCOMMERCIALCHART_BEGIN_NAMESPACE
ChartLogValueAxisX::ChartLogValueAxisX(QLogValueAxis *axis, QGraphicsItem* item)
: HorizontalAxis(axis, item),
m_axis(axis)
{
Marek Rosa
Fixed: chart not redrawing when logaxis's logBase value changed
 r2322 QObject::connect(m_axis,SIGNAL(baseChanged(qreal)),this, SLOT(handleBaseChanged(qreal)));
Marek Rosa
Fixed: axis not redrawing when labelFormat changed
 r2323 QObject::connect(m_axis,SIGNAL(labelFormatChanged(QString)),this, SLOT(handleLabelFormatChanged(QString)));
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274 }
ChartLogValueAxisX::~ChartLogValueAxisX()
{
}
QVector<qreal> ChartLogValueAxisX::calculateLayout() const
{
QVector<qreal> points;
qreal logMax = log10(m_axis->max()) / log10(m_axis->base());
qreal logMin = log10(m_axis->min()) / log10(m_axis->base());
Marek Rosa
Domains added
 r2275 qreal leftEdge = logMin < logMax ? logMin : logMax;
qreal ceilEdge = ceil(leftEdge);
Marek Rosa
QSplineSeries calculateControlPoints moved to splinechartitem. This way we don't need to deal with controlPoints on logaritmic scale
 r2372 int tickCount = qAbs(ceil(logMax) - ceil(logMin));
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274
points.resize(tickCount);
const QRectF &gridRect = gridGeometry();
const qreal deltaX = gridRect.width() / qAbs(logMax - logMin);
for (int i = 0; i < tickCount; ++i)
Marek Rosa
Domains added
 r2275 points[i] = (ceilEdge + i) * deltaX - leftEdge * deltaX + gridRect.left();
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274
return points;
}
void ChartLogValueAxisX::updateGeometry()
{
const QVector<qreal>& layout = ChartAxis::layout();
if (layout.isEmpty())
return;
setLabels(createLogValueLabels(m_axis->min(), m_axis->max(), m_axis->base(), layout.size(), m_axis->labelFormat()));
HorizontalAxis::updateGeometry();
}
Marek Rosa
Fixed: chart not redrawing when logaxis's logBase value changed
 r2322 void ChartLogValueAxisX::handleBaseChanged(qreal base)
{
Q_UNUSED(base);
Michal Klocek
Fixes missing layout updated on ticks,base and format calls
 r2333 QGraphicsLayoutItem::updateGeometry();
Marek Rosa
Fixed: chart not redrawing when logaxis's logBase value changed
 r2322 if(presenter()) presenter()->layout()->invalidate();
}
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274
Marek Rosa
Fixed: axis not redrawing when labelFormat changed
 r2323 void ChartLogValueAxisX::handleLabelFormatChanged(const QString &format)
{
Q_UNUSED(format);
Michal Klocek
Fixes missing layout updated on ticks,base and format calls
 r2333 QGraphicsLayoutItem::updateGeometry();
Marek Rosa
Fixed: axis not redrawing when labelFormat changed
 r2323 if(presenter()) presenter()->layout()->invalidate();
}
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274 QSizeF ChartLogValueAxisX::sizeHint(Qt::SizeHint which, const QSizeF &constraint) const
{
Q_UNUSED(constraint)
QFontMetrics fn(font());
QSizeF sh;
QSizeF base = HorizontalAxis::sizeHint(which, constraint);
QStringList ticksList;
qreal logMax = log10(m_axis->max()) / log10(m_axis->base());
qreal logMin = log10(m_axis->min()) / log10(m_axis->base());
Marek Rosa
QLogValueAxis number of labels calculation fixed
 r2370 int tickCount = qAbs(ceil(logMax) - ceil(logMin));
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274 if (m_axis->max() > m_axis->min() && tickCount > 1)
ticksList = createLogValueLabels(m_axis->min(), m_axis->max(), m_axis->base(), tickCount, m_axis->labelFormat());
else
ticksList.append(QString(" "));
qreal width = 0;
qreal height = 0;
switch (which) {
case Qt::MinimumSize:{
Miikka Heikkinen
Fix axis sizehints when labels are angled...
 r2412 QRectF boundingRect = labelBoundingRect(fn, "...");
width = qMax(boundingRect.width(), base.width());
height = boundingRect.height() + labelPadding();
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274 height += base.height();
Miikka Heikkinen
Fix axis sizehints when labels are angled...
 r2412 sh = QSizeF(width, height);
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274 break;
}
case Qt::PreferredSize: {
Miikka Heikkinen
Fix axis sizehints when labels are angled...
 r2412 int labelHeight = 0;
foreach (const QString& s, ticksList) {
QRect rect = labelBoundingRect(fn, s);
labelHeight = qMax(rect.height(), labelHeight);
width += rect.width();
}
height = labelHeight + labelPadding();
height += base.height();
width = qMax(width, base.width());
sh = QSizeF(width, height);
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274 break;
}
default:
break;
}
return sh;
}
Marek Rosa
Fixed: chart not redrawing when logaxis's logBase value changed
 r2322 #include "moc_chartlogvalueaxisx_p.cpp"
Marek Rosa
QLogValueAxis added. Log domain missing
 r2274 QTCOMMERCIALCHART_END_NAMESPACE