GIT_REPOSITORIES/LPP/Users/mperrinel/SciQLop-fork Commit - r890:9b45c5936f92

Moves the DragDropHelper file

trabillard - Mon, 06 Nov 2017 15:58:02

r890:9b45c5936f92

parent child

Diff options:

Raw Diff | Patch Diff | Download Diff

Side by Side Unified

Hide whitespace changes

Show full context diff

Context file:

r890:9b45c5936f92 Loading diff...:

Collapse all files

gui/include/DragAndDrop/DragDropHelper.h

¶ permalink

gui/include/DragAndDrop/DragDropHelper.h ~~gui/include/DragDropHelper.h~~ renamed 0 0

Show file before | Show file after | Hide comments

NO CONTENT: file renamed from gui/include/DragDropHelper.h to gui/include/DragAndDrop/DragDropHelper.h

gui/include/Visualization/VisualizationDragDropContainer.h

¶ permalink

gui/include/Visualization/VisualizationDragDropContainer.h +1 -1

Show file before | Show file after | Hide comments

             #include <functional>
-            #include <DragDropHelper.h>
+            #include <DragAndDrop/DragDropHelper.h>
             Q_DECLARE_LOGGING_CATEGORY(LOG_VisualizationDragDropContainer)

gui/meson.build

¶ permalink

gui/meson.build +2 -2

Show file before | Show file after | Hide comments

               'include/Settings/SqpSettingsGeneralWidget.h',
               'include/SidePane/SqpSidePane.h',
               'include/SqpApplication.h',
-              'include/DragDropHelper.h',
+              'include/DragAndDrop/DragDropHelper.h',
               'include/TimeWidget/TimeWidget.h',
               'include/Variable/VariableInspectorWidget.h',
               'include/Variable/VariableInspectorTableView.h',
             gui_sources = [
               'src/SqpApplication.cpp',
-              'src/DragDropHelper.cpp',
+              'src/DragAndDrop/DragDropHelper.cpp',
               'src/Common/ColorUtils.cpp',
               'src/Common/VisualizationDef.cpp',
               'src/DataSource/DataSourceTreeWidgetItem.cpp',

gui/src/DataSource/DataSourceTreeWidget.cpp

¶ permalink

gui/src/DataSource/DataSourceTreeWidget.cpp +1 -1

Show file before | Show file after | Hide comments

             #include "DataSource/DataSourceItem.h"
             #include "DataSource/DataSourceTreeWidgetItem.h"
-            #include "DragDropHelper.h"
+            #include "DragAndDrop/DragDropHelper.h"
             #include "SqpApplication.h"
             #include <QMimeData>

gui/src/DragAndDrop/DragDropHelper.cpp

¶ permalink

gui/src/DragAndDrop/DragDropHelper.cpp ~~gui/src/DragDropHelper.cpp~~ renamed +2 -4

Show file before | Show file after | Hide comments

-            #include "DragDropHelper.h"
+            #include "DragAndDrop/DragDropHelper.h"
             #include "SqpApplication.h"
             #include "Visualization/VisualizationDragDropContainer.h"
             #include "Visualization/VisualizationDragWidget.h"
             };
-            DragDropHelper::DragDropHelper() : impl{spimpl::make_unique_impl<DragDropHelperPrivate>()}
+            DragDropHelper::DragDropHelper() : impl{spimpl::make_unique_impl<DragDropHelperPrivate>()} {}
             DragDropHelper::~DragDropHelper()
             {

gui/src/SqpApplication.cpp

¶ permalink

gui/src/SqpApplication.cpp +1 -1

Show file before | Show file after | Hide comments

             #include <Data/IDataProvider.h>
             #include <DataSource/DataSourceController.h>
-            #include <DragDropHelper.h>
+            #include <DragAndDrop/DragDropHelper.h>
             #include <Network/NetworkController.h>
             #include <QThread>
             #include <Time/TimeController.h>

gui/src/TimeWidget/TimeWidget.cpp

¶ permalink

gui/src/TimeWidget/TimeWidget.cpp +1 -1

Show file before | Show file after | Hide comments

             #include <Common/DateUtils.h>
             #include <Common/MimeTypesDef.h>
-            #include <DragDropHelper.h>
+            #include <DragAndDrop/DragDropHelper.h>
             #include <SqpApplication.h>
             #include <Time/TimeController.h>

gui/src/Variable/VariableInspectorTableView.cpp

¶ permalink

gui/src/Variable/VariableInspectorTableView.cpp +1 -1

Show file before | Show file after | Hide comments

             #include "Variable/VariableInspectorTableView.h"
-            #include "DragDropHelper.h"
+            #include "DragAndDrop/DragDropHelper.h"
             #include "SqpApplication.h"
             VariableInspectorTableView::VariableInspectorTableView(QWidget *parent) : QTableView(parent) {}

gui/src/Variable/VariableInspectorWidget.cpp

¶ permalink

gui/src/Variable/VariableInspectorWidget.cpp +1 -1

Show file before | Show file after | Hide comments

             #include <QStyledItemDelegate>
             #include <QWidgetAction>
-            #include <DragDropHelper.h>
+            #include <DragAndDrop/DragDropHelper.h>
             #include <SqpApplication.h>
             Q_LOGGING_CATEGORY(LOG_VariableInspectorWidget, "VariableInspectorWidget")

gui/src/Visualization/VisualizationDragDropContainer.cpp

¶ permalink

gui/src/Visualization/VisualizationDragDropContainer.cpp +1 -1

Show file before | Show file after | Hide comments

             #include "Visualization/VisualizationDragDropContainer.h"
-            #include "DragDropHelper.h"
+            #include "DragAndDrop/DragDropHelper.h"
             #include "SqpApplication.h"
             #include "Visualization/VisualizationDragWidget.h"

gui/src/Visualization/VisualizationGraphWidget.cpp

¶ permalink

gui/src/Visualization/VisualizationGraphWidget.cpp +1 -1

Show file before | Show file after | Hide comments

             #include <Common/MimeTypesDef.h>
             #include <Data/ArrayData.h>
             #include <Data/IDataSeries.h>
-            #include <DragDropHelper.h>
+            #include <DragAndDrop/DragDropHelper.h>
             #include <Settings/SqpSettingsDefs.h>
             #include <SqpApplication.h>
             #include <Time/TimeController.h>

gui/src/Visualization/VisualizationTabWidget.cpp

¶ permalink

gui/src/Visualization/VisualizationTabWidget.cpp +1 -1

Show file before | Show file after | Hide comments

             #include "Common/MimeTypesDef.h"
-            #include "DragDropHelper.h"
+            #include "DragAndDrop/DragDropHelper.h"
             #include "SqpApplication.h"
             Q_LOGGING_CATEGORY(LOG_VisualizationTabWidget, "VisualizationTabWidget")

gui/src/Visualization/VisualizationZoneWidget.cpp

¶ permalink

gui/src/Visualization/VisualizationZoneWidget.cpp +1 -1

Show file before | Show file after | Hide comments

             #include <Visualization/operations/FindVariableOperation.h>
-            #include <DragDropHelper.h>
+            #include <DragAndDrop/DragDropHelper.h>
             #include <QUuid>
             #include <SqpApplication.h>
             #include <cmath>

General Comments 3

Under Review

trabillard

Fri, 03 Nov 2017 17:51:26

author

Comment #2379

Edit

Delete

|

Auto status change to "Under Review"

Under Review

trabillard

Tue, 07 Nov 2017 10:35:02

author

Comment #2383

Edit

Delete

|

Pull request updated. Auto status change to "Under Review"

Changed commits:
  * 5 added
  * 0 removed

Changed files:
  * A gui/include/DragAndDrop/DragDropScroller.h
  * A gui/include/DragAndDrop/DragDropTabSwitcher.h
  * A gui/src/DragAndDrop/DragDropHelper.cpp
  * A gui/src/DragAndDrop/DragDropScroller.cpp
  * A gui/src/DragAndDrop/DragDropTabSwitcher.cpp
  * A gui/include/DragAndDrop/DragDropHelper.h
  * A gui/src/Visualization/VisualizationWidget.cpp
  * M gui/src/Variable/VariableInspectorTableView.cpp
  * M core/include/DataSource/DataSourceController.h
  * M core/include/Variable/VariableController.h
  * M core/meson.build
  * M core/src/DataSource/DataSourceController.cpp
  * M core/src/DataSource/DataSourceItem.cpp
  * M core/src/Variable/VariableModel.cpp
  * M gui/include/DataSource/DataSourceTreeWidget.h
  * M gui/include/Visualization/VisualizationDragDropContainer.h
  * M gui/include/Visualization/VisualizationDragWidget.h
  * M gui/include/Visualization/VisualizationGraphWidget.h
  * M gui/include/Visualization/VisualizationZoneWidget.h
  * M gui/meson.build
  * M gui/src/DataSource/DataSourceTreeWidget.cpp
  * M gui/src/SqpApplication.cpp
  * M gui/src/TimeWidget/TimeWidget.cpp
  * M gui/src/Variable/VariableInspectorWidget.cpp
  * M gui/src/Visualization/VisualizationDragDropContainer.cpp
  * M gui/src/Visualization/VisualizationGraphWidget.cpp
  * M gui/src/Visualization/VisualizationTabWidget.cpp
  * M gui/src/Visualization/VisualizationZoneWidget.cpp
  * M gui/ui/Variable/VariableInspectorWidget.ui
  * M gui/ui/Visualization/VisualizationTabWidget.ui
  * M gui/ui/Visualization/VisualizationZoneWidget.ui
  * M gui/src/DragDropHelper.cpp
  * R core/include/Common/MimeTypesDef.h
  * R core/include/Data/OptionalAxis.h
  * R core/include/Data/SpectrogramSeries.h
  * R core/include/Data/Unit.h
  * R core/include/Variable/VariableCacheStrategyFactory.h
  * R core/include/Variable/VariableSingleThresholdCacheStrategy.h
  * R core/src/Common/MimeTypesDef.cpp
  * R core/src/Data/OptionalAxis.cpp
  * R core/src/Data/SpectrogramSeries.cpp
  * R core/tests/Data/DataSeriesBuilders.cpp
  * R core/tests/Data/DataSeriesBuilders.h
  * R core/tests/Data/DataSeriesUtils.cpp
  * R core/tests/Data/DataSeriesUtils.h
  * R core/tests/Data/TestOptionalAxis.cpp
  * R core/tests/Data/TestScalarSeries.cpp
  * R core/tests/Data/TestSpectrogramSeries.cpp
  * R core/tests/Data/TestVectorSeries.cpp
  * R core/tests/Variable/TestVariableSync.cpp
  * R gui/include/Common/VisualizationDef.h
  * R gui/include/DragDropHelper.h
  * R gui/src/Common/VisualizationDef.cpp
  * R gui/src/Visualization/VisualizationDragWidget.cpp
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/FileNotFound.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/NaNValue.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/NaNX.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/NoUnit.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/TooManyValues.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/ValidScalar1.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/ValidVector1.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/WrongDate.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/WrongUnit.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/WrongValue.txt
  * R plugins/mockplugin/include/MockDefs.h
  * R plugins/mockplugin/src/MockDefs.cpp
  * R core/include/Data/ArrayData.h
  * R core/include/Data/DataSeries.h
  * R core/include/Data/IDataSeries.h
  * R core/include/Data/VariableRequest.h
  * R core/include/DataSource/DataSourceItem.h
  * R core/include/Variable/Variable.h
  * R core/include/Variable/VariableCacheStrategy.h
  * R core/include/Variable/VariableModel.h
  * R core/src/Data/VectorSeries.cpp
  * R core/src/Variable/Variable.cpp
  * R core/src/Variable/VariableAcquisitionWorker.cpp
  * R core/src/Variable/VariableController.cpp
  * R core/tests/Variable/TestVariable.cpp
  * R core/tests/meson.build
  * R gui/include/SqpApplication.h
  * R gui/include/Visualization/VisualizationTabWidget.h
  * R gui/src/DataSource/DataSourceTreeWidgetItem.cpp
  * R gui/src/Visualization/operations/RescaleAxeOperation.cpp
  * R gui/ui/DataSource/DataSourceWidget.ui
  * R plugins/amda/src/AmdaProvider.cpp
  * R plugins/amda/src/AmdaResultParser.cpp
  * R plugins/amda/tests/TestAmdaAcquisition.cpp
  * R plugins/amda/tests/TestAmdaResultParser.cpp
  * R plugins/mockplugin/include/CosinusProvider.h
  * R plugins/mockplugin/meson.build
  * R plugins/mockplugin/src/CosinusProvider.cpp
  * R plugins/mockplugin/src/MockPlugin.cpp
  * R plugins/mockplugin/tests/TestCosinusAcquisition.cpp
  * R core/src/Variable/VariableCacheStrategy.cpp
  * R core/tests/Data/TestDataSeries.cpp

Under Review

trabillard

Tue, 07 Nov 2017 11:18:35

author

Comment #2384

Edit

Delete

|

Pull request updated. Auto status change to "Under Review"

Changed commits:
  * 1 added
  * 0 removed

Changed files:
  * A core/tests/meson.build

Write
Preview

You need to be logged in to leave comments. Login now

Reviewers

TODOs Show resolved

No TODOs yet

3 3 0

Comments

		Pull request updated. Auto status change to \|under_review\|...
		Pull request updated. Auto status change to \|under_review\|...
		Auto status change to \|new_status\|...

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages