GIT_REPOSITORIES/LPP/Users/mperrinel/SciQLop-fork Commit - r1244:7202dffeda15

Randomizes the number of operations to wait between calling validation (defines min/max frequencies)

Alexandre Leroux -

r1244:7202dffeda15

parent child

Context file:

r1244:7202dffeda15

Collapse all files

plugins/amda/tests/FuzzingDefs.cpp +1 0

             const QString PROVIDER_PROPERTY = QStringLiteral("provider");
             const QString OPERATION_DELAY_BOUNDS_PROPERTY = QStringLiteral("operationDelays");
             const QString VALIDATORS_PROPERTY = QStringLiteral("validators");
+            const QString VALIDATION_FREQUENCY_BOUNDS_PROPERTY = QStringLiteral("validationFrequencyBounds");
             // //////////// //
             // FuzzingState //

plugins/amda/tests/FuzzingDefs.h +3 0

             /// Validators used to validate an operation
             extern const QString VALIDATORS_PROPERTY;
+            /// Min/max number of operations to execute before calling validation of the current test's state
+            extern const QString VALIDATION_FREQUENCY_BOUNDS_PROPERTY;
             // /////// //
             // Structs //
             // /////// //

plugins/amda/tests/TestAmdaFuzzing.cpp +29 -1

             const auto VALIDATORS_DEFAULT_VALUE = QVariant::fromValue(
                 ValidatorsTypes{{FuzzingValidatorType::RANGE, FuzzingValidatorType::DATA}});
+            /// Min/max number of operations to execute before calling validation
+            const auto VALIDATION_FREQUENCY_BOUNDS_DEFAULT_VALUE = QVariant::fromValue(std::make_pair(1, 10));
             // /////// //
             // Methods //
             // /////// //
                     qCInfo(LOG_TestAmdaFuzzing()).noquote() << "Running" << nbMaxOperations() << "operations on"
                                                             << nbMaxVariables() << "variable(s)...";
+                    // Inits the count of the number of operations before the next validation
+                    int nextValidationCounter = 0;
+                    auto updateValidationCounter = [this, &nextValidationCounter]() {
+                        nextValidationCounter = RandomGenerator::instance().generateInt(
+                            validationFrequencies().first, validationFrequencies().second);
+                        qCInfo(LOG_TestAmdaFuzzing()).noquote()
+                            << "Next validation in " << nextValidationCounter << "operations...";
+                    };
+                    updateValidationCounter();
                     auto canExecute = true;
                     for (auto i = 0; i < nbMaxOperations() && canExecute; ++i) {
                         // Retrieves all operations that can be executed in the current context
                         canExecute = !variableOperations.empty();
                         if (canExecute) {
+                            --nextValidationCounter;
                             // Of the operations available, chooses a random operation and executes it
                             auto variableOperation
                                 = RandomGenerator::instance().randomChoice(variableOperations, weights);
                             QTest::qWait(delay);
                             // Validates variables
-                            validate(m_FuzzingState.m_VariablesPool, validators());
+                            if (nextValidationCounter == 0) {
+                                validate(m_FuzzingState.m_VariablesPool, validators());
+                                updateValidationCounter();
+                            }
                         }
                         else {
                             qCInfo(LOG_TestAmdaFuzzing()).noquote()
                     return result;
                 }
+                std::pair<int, int> validationFrequencies() const
+                {
+                    static auto result = m_Properties
+                                             .value(VALIDATION_FREQUENCY_BOUNDS_PROPERTY,
+                                                    VALIDATION_FREQUENCY_BOUNDS_DEFAULT_VALUE)
+                                             .value<std::pair<int, int> >();
+                    return result;
+                }
                 VariableController &m_VariableController;
                 Properties m_Properties;
                 FuzzingState m_FuzzingState;

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages