GIT_REPOSITORIES/LPP/Users/mperrinel/SciQLop-fork Commit - r1004:15899f42a907

0

core/include/Common/SortUtils.h +1 -1

                     auto sortedData = Container{};
                     sortedData.reserve(containerSize);
-                    for (auto i = 0, componentIndex = 0, permutationIndex = 0; i < containerSize;
+                    for (auto i = 0u, componentIndex = 0u, permutationIndex = 0u; i < containerSize;
                          ++i, componentIndex = i % nbValues, permutationIndex = i / nbValues) {
                         auto insertIndex = sortPermutation.at(permutationIndex) * nbValues + componentIndex;
                         sortedData.push_back(container.at(insertIndex));

0

core/include/Variable/VariableCacheStrategy.h +1 0

             class SCIQLOP_CORE_EXPORT VariableCacheStrategy {
             public:
+                virtual ~VariableCacheStrategy() noexcept = default;
                 virtual std::pair<SqpRange, SqpRange> computeRange(const SqpRange &vRange,
                                                                    const SqpRange &rangeRequested)
                     = 0;

0

core/include/Variable/VariableCacheStrategyFactory.h +2 0

                             qCCritical(LOG_VariableCacheStrategyFactory())
                                 << QObject::tr("Unknown cache strategy");
                     }
+                    return nullptr;
                 }
             };

0

core/meson.build 0 -1

               'include/Variable/VariableCacheController.h',
               'include/Variable/VariableController.h',
               'include/Variable/VariableAcquisitionWorker.h',
-              'include/Variable/VariableCacheStrategy.h',
               'include/Variable/VariableSynchronizationGroup.h',
               'include/Variable/VariableModel.h',
               'include/Visualization/VisualizationController.h'

0

core/src/Data/OptionalAxis.cpp 0 -2

                             return SortUtils::maxCompareWithNaN(it1.first(), it2.first());
                         });
-                    auto pair = std::make_pair(minIt->first(), maxIt->first());
                     return std::make_pair(minIt->first(), maxIt->first());
                 }
             }

0

core/src/Data/VectorSeries.cpp +1 -1

                 auto result = std::vector<double>();
                 result.reserve(xValues.size() * 3);
-                for (int i = 0; i < xValues.size(); i++) {
+                for (auto i = 0u; i < xValues.size(); ++i) {
                     result.push_back(xValues[i]);
                     result.push_back(yValues[i]);
                     result.push_back(zValues[i]);

0

core/src/Variable/VariableController.cpp +3 0

                     return newVariable;
                 }
+                qCCritical(LOG_VariableController()) << tr("Impossible to create variable");
+                return nullptr;
             }
             void VariableController::onDateTimeOnSelection(const SqpRange &dateTime)

0

core/src/Variable/VariableModel.cpp +3 -1

             std::shared_ptr<Variable> VariableModel::variable(int index) const
             {
-                return (index >= 0 && index < impl->m_Variables.size()) ? impl->m_Variables[index] : nullptr;
+                return (index >= 0u && static_cast<size_t>(index) < impl->m_Variables.size())
+                           ? impl->m_Variables[index]
+                           : nullptr;
             }
             std::vector<std::shared_ptr<Variable> > VariableModel::variables() const

0

core/tests/Data/DataSeriesUtils.cpp +1 -1

             {
                 QVERIFY(std::equal(first, last, xData.cbegin(), xData.cend(),
                                    [](const auto &it, const auto &expectedX) { return it.x() == expectedX; }));
-                for (auto i = 0; i < valuesData.size(); ++i) {
+                for (auto i = 0u; i < valuesData.size(); ++i) {
                     auto componentData = valuesData.at(i);
                     QVERIFY(std::equal(

0

core/tests/Data/TestTwoDimArrayData.cpp +3 -3

                 auto result = DataContainer{};
                 result.reserve(componentSize * containerSize);
-                for (auto i = 0; i < componentSize; ++i) {
+                for (auto i = 0u; i < componentSize; ++i) {
-                    for (auto j = 0; j < containerSize; ++j) {
+                    for (auto j = 0u; j < containerSize; ++j) {
                         result.push_back(container.at(j).at(i));
                     }
                 }
                                        }));
                 };
-                for (auto i = 0; i < expectedData.size(); ++i) {
+                for (auto i = 0u; i < expectedData.size(); ++i) {
                     verifyComponent(expectedData.at(i), [i](const auto &seriesIt, const auto &value) {
                         return seriesIt.at(i) == value;
                     });

0

gui/meson.build 0 -3

             gui_moc_headers = [
               'include/DataSource/DataSourceWidget.h',
-              'include/DataSource/DataSourceTreeWidget.h',
               'include/Settings/SqpSettingsDialog.h',
               'include/Settings/SqpSettingsGeneralWidget.h',
               'include/SidePane/SqpSidePane.h',
               'include/SqpApplication.h',
-              'include/DragAndDrop/DragDropHelper.h',
               'include/DragAndDrop/DragDropScroller.h',
               'include/DragAndDrop/DragDropTabSwitcher.h',
               'include/TimeWidget/TimeWidget.h',
               'include/Variable/VariableInspectorWidget.h',
-              'include/Variable/VariableInspectorTableView.h',
               'include/Variable/RenameVariableDialog.h',
               'include/Visualization/qcustomplot.h',
               'include/Visualization/VisualizationGraphWidget.h',

0

gui/src/SqpApplication.cpp +2 -2

             public:
                 SqpApplicationPrivate()
                         : m_DataSourceController{std::make_unique<DataSourceController>()},
-                          m_NetworkController{std::make_unique<NetworkController>()},
-                          m_TimeController{std::make_unique<TimeController>()},
                           m_VariableController{std::make_unique<VariableController>()},
+                          m_TimeController{std::make_unique<TimeController>()},
+                          m_NetworkController{std::make_unique<NetworkController>()},
                           m_VisualizationController{std::make_unique<VisualizationController>()},
                           m_DragDropHelper{std::make_unique<DragDropHelper>()}
                 {

0

gui/src/Visualization/operations/GenerateVariableMenuOperation.cpp +2 -2

                     QMenu *menu, std::shared_ptr<Variable> variable,
                     std::set<IVisualizationWidget *> variableContainers)
                         : m_Variable{variable},
+                          m_VariableContainers{std::move(variableContainers)},
                           m_PlotMenuBuilder{menu},
-                          m_UnplotMenuBuilder{menu},
+                          m_UnplotMenuBuilder{menu}
-                          m_VariableContainers{std::move(variableContainers)}
                 {
                 }

0

plugins/amda/src/AmdaResultParserHelper.cpp +1 -1

                 auto lineData = line.split(RESULT_LINE_SEPARATOR, QString::SkipEmptyParts);
                 // Checks that the line contains expected number of values + x-axis value
-                if (lineData.size() == valuesIndexes.size() + 1) {
+                if (static_cast<size_t>(lineData.size()) == valuesIndexes.size() + 1) {
                     // X : the data is converted from date to double (in secs)
                     auto x = doubleDate(lineData.at(0));

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages