GIT_REPOSITORIES/LPP/Users/mperrinel/SCIQLOP-Initialisation Commit - r159:d6ec0a8c7ca0

Minor fixes

Alexandre Leroux -

r159:d6ec0a8c7ca0

parent child

Context file:

r159:d6ec0a8c7ca0

core/src/DataSource/DataSourceController.cpp +2 -2

-             #include <DataSource/DataSourceController.h>
-             #include <DataSource/DataSourceItem.h>
+             #include "DataSource/DataSourceController.h"
+             #include "DataSource/DataSourceItem.h"
              #include <Data/IDataProvider.h>

core/src/DataSource/DataSourceItem.cpp +1 -1

              QVector<DataSourceItemAction *> DataSourceItem::actions() const noexcept
              {
-                 QVector<DataSourceItemAction *> result{};
+                 auto result = QVector<DataSourceItemAction *>{};
                  std::transform(std::cbegin(impl->m_Actions), std::cend(impl->m_Actions),
                                 std::back_inserter(result), [](const auto &action) { return action.get(); });

core/src/Variable/VariableController.cpp +5 -2

              std::unique_ptr<IDataSeries> generateDefaultDataSeries(const IDataProvider &provider) noexcept
              {
                  auto parameters = DataProviderParameters{
-                     static_cast<double>(QDateTime{QDate{2017, 01, 01}}.toSecsSinceEpoch()),
-                     static_cast<double>(QDateTime{QDate{2017, 01, 03}}.toSecsSinceEpoch())};
+                     // Remarks : we don't use toSecsSinceEpoch() here (method is for Qt 5.8 or above)
+                     static_cast<double>(QDateTime{QDate{2017, 01, 01}, QTime{12, 00}}.toMSecsSinceEpoch()
+                                         / 1000.),
+                     static_cast<double>(QDateTime{QDate{2017, 01, 01}, QTime{12, 01}}.toMSecsSinceEpoch())
+                         / 1000.};
                  return provider.retrieveData(parameters);
              }

core/vera-exclusions/exclusions.txt +3 0

              # Ignore false positive relative to an alias
              DataSourceItemAction\.h:\d+:.*IPSIS_S06.*found: (ExecuteFunction)
+             # Ignore false positive relative to unnamed namespace
+             VariableController\.cpp:\d+:.*IPSIS_F13.*

General Comments 1

perrinel

|

Status change > Approved

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages