Project

General

Profile

Bug #804

Analyse Logiscope LFR_3.1.0.4 : Tr_ModelFonction Severity is High

Added by William Recart almost 5 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
-
Target version:
-
Start date:
19/10/2016
Due date:
% Done:

100%

Estimated time:
revision:
r0

Description

Rappel de la règle :
Tr_ModelFonction
Definition:
-----------
Use inline functions instead of macro-functions.

Example:
--------

// write
inline char *GetName(aClass &object) {
return(object.name);
}

// do not write
#define GetName(s) ((s)->name)

La règle n'est pas respectée dans 120 cas d'après Logiscope:
Fichier fsw_params.h : lignes 237, 238, 239, 241, 242, 243, 247, 248, 249, 251, 252, 253, 257, 258, 259, 261, 262, 263

History

#1 Updated by William Recart almost 5 years ago

  • % Done changed from 0 to 100

Violation are due to use of debug macro to redefine printf() function in file fsw_params.h.

In case of debug compilation, macro functions redefined printf () function, in case of flight compilation, macro functions are defined as empty.

This is considered as acceptable at LFR level.

#2 Updated by paul leroy almost 5 years ago

  • Status changed from New to Resolved
  • Priority changed from Normal to Low

#3 Updated by William Recart almost 5 years ago

  • Status changed from Resolved to Closed

Vérification effectuée sur le tag 322 (c0603702c8c8) , il reste en erreur les mêmes lignes.
L'issue est considérée close.

#4 Updated by William Recart over 4 years ago

Satus on FSW V3.2.0.15 :
- fsw_params.h : lines 16, 17, 18, 20, 21, 22, 26, 27, 28, 30, 31, 32, 36, 37, 38, 40, 41, 42 : Violation are due to use of debug macro to redefine printf() function in file fsw_params.h.

This is considered as acceptable at LFR level.

#5 Updated by William Recart about 3 years ago

Satus on FSW V3.2.0.21:
- fsw_params.h : lines 66, 67, 68, 76, 77, 78, 86, 87, 88 : Violation are due to use of debug macro to redefine printf() function in file fsw_params.h. (not activated in fligth version)

This is considered as acceptable at LFR level.

Also available in: Atom PDF