From 213f5ecfb65daf263451bdca3027c55909ad7d4f 2018-05-08 12:53:22
From: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Date: 2018-05-08 12:53:22
Subject: [PATCH] Empty passwd storing hash map in downloader once download is complete

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>

---

diff --git a/core/src/Network/Downloader.cpp b/core/src/Network/Downloader.cpp
index 6f285df..29a9f1a 100644
--- a/core/src/Network/Downloader.cpp
+++ b/core/src/Network/Downloader.cpp
@@ -60,6 +60,8 @@ public:
         QVariant status_code = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute);
         Response resp = Response(reply->readAll(), status_code.toInt());
         delete reply;
+        if(user!="" and passwd!="")
+            auth.remove(url);
         return resp;
     }
 
@@ -68,7 +70,7 @@ public:
         auto uuid = QUuid::createUuid();
         QNetworkRequest request = buildRequest(url, user, passwd);
         QNetworkReply *reply = manager.get(request);
-        auto callback_wrapper = [uuid, callback, this](){
+        auto callback_wrapper = [url, uuid, callback, this](){
             QNetworkReply* reply;
             {
                 QWriteLocker locker(&pending_requests_lock);
@@ -76,6 +78,7 @@ public:
             }
             QVariant status_code = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute);
             Response resp = Response(reply->readAll(), status_code.toInt());
+            auth.remove(url);
             delete reply;
             callback(uuid, resp);
         };