diff --git a/core/include/Data/DataSeries.h b/core/include/Data/DataSeries.h index 19df6c8..f9de7dc 100644 --- a/core/include/Data/DataSeries.h +++ b/core/include/Data/DataSeries.h @@ -31,12 +31,12 @@ public: protected: /// Protected ctor (DataSeries is abstract) - explicit DataSeries(std::shared_ptr > xAxisData, Unit xAxisUnit, - std::shared_ptr > valuesData, Unit valuesUnit) + explicit DataSeries(std::shared_ptr > xAxisData, const Unit &xAxisUnit, + std::shared_ptr > valuesData, const Unit &valuesUnit) : m_XAxisData{xAxisData}, - m_XAxisUnit{std::move(xAxisUnit)}, + m_XAxisUnit{xAxisUnit}, m_ValuesData{valuesData}, - m_ValuesUnit{std::move(valuesUnit)} + m_ValuesUnit{valuesUnit} { } diff --git a/core/include/Data/ScalarSeries.h b/core/include/Data/ScalarSeries.h index e740bec..69d68e1 100644 --- a/core/include/Data/ScalarSeries.h +++ b/core/include/Data/ScalarSeries.h @@ -14,7 +14,7 @@ public: * @param xAxisUnit x-axis unit * @param valuesUnit values unit */ - explicit ScalarSeries(int size, Unit xAxisUnit, Unit valuesUnit); + explicit ScalarSeries(int size, const Unit &xAxisUnit, const Unit &valuesUnit); /** * Sets data for a specific index. The index has to be valid to be effective diff --git a/core/src/Data/ScalarSeries.cpp b/core/src/Data/ScalarSeries.cpp index bd07739..90718a5 100644 --- a/core/src/Data/ScalarSeries.cpp +++ b/core/src/Data/ScalarSeries.cpp @@ -1,8 +1,8 @@ #include -ScalarSeries::ScalarSeries(int size, Unit xAxisUnit, Unit valuesUnit) - : DataSeries{std::make_shared >(size), std::move(xAxisUnit), - std::make_shared >(size), std::move(valuesUnit)} +ScalarSeries::ScalarSeries(int size, const Unit &xAxisUnit, const Unit &valuesUnit) + : DataSeries{std::make_shared >(size), xAxisUnit, + std::make_shared >(size), valuesUnit} { } diff --git a/gui/src/Visualization/VisualizationWidget.cpp b/gui/src/Visualization/VisualizationWidget.cpp index c780ec8..6011c5a 100644 --- a/gui/src/Visualization/VisualizationWidget.cpp +++ b/gui/src/Visualization/VisualizationWidget.cpp @@ -20,7 +20,7 @@ VisualizationWidget::VisualizationWidget(QWidget *parent) addTabViewButton->setCursor(Qt::ArrowCursor); ui->tabWidget->setCornerWidget(addTabViewButton, Qt::TopRightCorner); - auto enableMinimunCornerWidgetSize = [this](bool enable) { + auto enableMinimumCornerWidgetSize = [this](bool enable) { auto tabViewCornerWidget = ui->tabWidget->cornerWidget(); auto width = enable ? tabViewCornerWidget->width() : 0; @@ -31,18 +31,18 @@ VisualizationWidget::VisualizationWidget(QWidget *parent) ui->tabWidget->setMinimumWidth(width); }; - auto addTabView = [this, enableMinimunCornerWidgetSize]() { + auto addTabView = [this, enableMinimumCornerWidgetSize]() { auto index = ui->tabWidget->addTab(new VisualizationTabWidget(ui->tabWidget), QString("View %1").arg(ui->tabWidget->count() + 1)); if (ui->tabWidget->count() > 0) { - enableMinimunCornerWidgetSize(false); + enableMinimumCornerWidgetSize(false); } qCInfo(LOG_VisualizationWidget()) << tr("add the tab of index %1").arg(index); }; - auto removeTabView = [this, enableMinimunCornerWidgetSize](int index) { + auto removeTabView = [this, enableMinimumCornerWidgetSize](int index) { if (ui->tabWidget->count() == 1) { - enableMinimunCornerWidgetSize(true); + enableMinimumCornerWidgetSize(true); } ui->tabWidget->removeTab(index); @@ -101,17 +101,17 @@ void VisualizationWidget::displayVariable(std::shared_ptr variable) no newGraph->addVariable(variable); } else { - qCDebug(LOG_VisualizationWidget()) + qCCritical(LOG_VisualizationWidget()) << tr("Can't display the variable : can't create the graph"); } } else { - qCDebug(LOG_VisualizationWidget()) + qCCritical(LOG_VisualizationWidget()) << tr("Can't display the variable : can't create a new zone in the current tab"); } } else { - qCDebug(LOG_VisualizationWidget()) + qCCritical(LOG_VisualizationWidget()) << tr("Can't display the variable : there is no current tab"); } }