HG_REPOSITORIES/LPP/SciQLOP_Repos/SciQLop Files · gui/src/Variable/RenameVariableDialog.cpp

Fix bug when creating two variables crash the app. ...

Fix bug when creating two variables crash the app. Variable as now invalid range and cache range at creation

Alexandre Leroux - - Load All Authors

File last commit:

r713:0bbf90c7e3d0


                r756:a7f60f6512e6

Download file

             RenameVariableDialog.cpp
        
                    63 lines
            
             | 1.7 KiB
            
                | text/x-c
            
             |
                CppLexer
            
             / gui / src / Variable / RenameVariableDialog.cpp
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Alexandre Leroux
    
Creates dialog to rename a variable

              r682
            
      #include "Variable/RenameVariableDialog.h"

      #include <ui_RenameVariableDialog.h>

      RenameVariableDialog::RenameVariableDialog(const QString &defaultName,

                                                 const QVector<QString> &forbiddenNames, QWidget *parent)

              : QDialog{parent},

                ui{new Ui::RenameVariableDialog},

                m_DefaultName{defaultName},

                m_ForbiddenNames{forbiddenNames}

      {

          ui->setupUi(this);

          connect(ui->nameLineEdit, &QLineEdit::textChanged, [this]() { ui->errorLabel->hide(); });

          ui->nameLineEdit->setText(defaultName);

          ui->nameLineEdit->selectAll();

          ui->nameLineEdit->setFocus();

      }

      RenameVariableDialog::~RenameVariableDialog() noexcept

      {

          delete ui;

      }

      QString RenameVariableDialog::name() const noexcept

      {

        Alexandre Leroux
    
Fixes the ability to enter a name with only spaces when renaming variables

              r713
            
          return ui->nameLineEdit->text().trimmed();

        Alexandre Leroux
    
Creates dialog to rename a variable

              r682
            
      }

      void RenameVariableDialog::accept()

      {

          auto invalidateInput = [this](const auto &error) {

              ui->nameLineEdit->selectAll();

              ui->nameLineEdit->setFocus();

              ui->errorLabel->setText(error);

              ui->errorLabel->show();

          };

          // Empty name

        Alexandre Leroux
    
Fixes the ability to enter a name with only spaces when renaming variables

              r713
            
          auto name = this->name();

        Alexandre Leroux
    
Creates dialog to rename a variable

              r682
            
          if (name.isEmpty()) {

              invalidateInput(tr("A variable name must be specified"));

              return;

          }

          // Same name when opening dialog

          if (name.compare(m_DefaultName, Qt::CaseInsensitive) == 0) {

              reject();

              return;

          }

          // Forbidden name

          auto isForbidden

              = [&name](const auto &it) { return name.compare(it, Qt::CaseInsensitive) == 0; };

          if (std::any_of(m_ForbiddenNames.cbegin(), m_ForbiddenNames.cend(), isForbidden)) {

              invalidateInput(tr("'%1' is already used").arg(name));

              return;

          }

          // Valid name

          QDialog::accept();

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Alexandre Leroux Creates dialog to rename a variable	r682	#include "Variable/RenameVariableDialog.h"

		#include <ui_RenameVariableDialog.h>

		RenameVariableDialog::RenameVariableDialog(const QString &defaultName,
		const QVector<QString> &forbiddenNames, QWidget *parent)
		: QDialog{parent},
		ui{new Ui::RenameVariableDialog},
		m_DefaultName{defaultName},
		m_ForbiddenNames{forbiddenNames}
		{
		ui->setupUi(this);

		connect(ui->nameLineEdit, &QLineEdit::textChanged, [this]() { ui->errorLabel->hide(); });

		ui->nameLineEdit->setText(defaultName);
		ui->nameLineEdit->selectAll();
		ui->nameLineEdit->setFocus();
		}

		RenameVariableDialog::~RenameVariableDialog() noexcept
		{
		delete ui;
		}

		QString RenameVariableDialog::name() const noexcept
		{
Alexandre Leroux Fixes the ability to enter a name with only spaces when renaming variables	r713	return ui->nameLineEdit->text().trimmed();
Alexandre Leroux Creates dialog to rename a variable	r682	}

		void RenameVariableDialog::accept()
		{
		auto invalidateInput = [this](const auto &error) {
		ui->nameLineEdit->selectAll();
		ui->nameLineEdit->setFocus();
		ui->errorLabel->setText(error);
		ui->errorLabel->show();
		};

		// Empty name
Alexandre Leroux Fixes the ability to enter a name with only spaces when renaming variables	r713	auto name = this->name();
Alexandre Leroux Creates dialog to rename a variable	r682	if (name.isEmpty()) {
		invalidateInput(tr("A variable name must be specified"));
		return;
		}

		// Same name when opening dialog
		if (name.compare(m_DefaultName, Qt::CaseInsensitive) == 0) {
		reject();
		return;
		}

		// Forbidden name
		auto isForbidden
		= [&name](const auto &it) { return name.compare(it, Qt::CaseInsensitive) == 0; };
		if (std::any_of(m_ForbiddenNames.cbegin(), m_ForbiddenNames.cend(), isForbidden)) {
		invalidateInput(tr("'%1' is already used").arg(name));
		return;
		}

		// Valid name
		QDialog::accept();
		}