HG_REPOSITORIES/LPP/SciQLOP_Repos/SciQLop Files · gui/src/Visualization/VisualizationTabWidget.cpp

Adds the ability to force an acquisition pending for an operation (2)...

Adds the ability to force an acquisition pending for an operation (2) Handles flag in the test

trabillard - - Load All Authors

File last commit:

r1138:f7fe3621eadc


                r1217:a7d21961e1ef

Download file

             VisualizationTabWidget.cpp
        
                    354 lines
            
             | 11.4 KiB
            
                | text/x-c
            
             |
                CppLexer
            
             / gui / src / Visualization / VisualizationTabWidget.cpp
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        perrinel
    
mv visualization -> Visualization...

              r95
            
      #include "Visualization/VisualizationTabWidget.h"

        Alexandre Leroux
    
Updates visitor interface...

              r207
            
      #include "Visualization/IVisualizationWidgetVisitor.h"

        perrinel
    
Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget

              r58
            
      #include "ui_VisualizationTabWidget.h"

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
      #include "Visualization/VisualizationGraphWidget.h"

        trabillard
    
Format changes

              r844
            
      #include "Visualization/VisualizationZoneWidget.h"

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
        Thibaud Rabillard
    
New style on mac to keep the scrollbars visible

              r930
            
      #include "Visualization/MacScrollBarStyle.h"

        trabillard
    
Manage drag&drop of empty graphs

              r841
            
      #include "Variable/VariableController.h"

        trabillard
    
Move Common MIME types constants in a Definition file in core module.

              r848
            
      #include "Common/MimeTypesDef.h"

        trabillard
    
Rename "DragDropHelper" in "DragDropGuiController"

              r1075
            
      #include "DragAndDrop/DragDropGuiController.h"

        trabillard
    
Format changes

              r844
            
      #include "SqpApplication.h"

        perrinel
    
Add the visualization gui classes

              r118
            
        Alexandre Leroux
    
Adds logs for null visitors

              r219
            
      Q_LOGGING_CATEGORY(LOG_VisualizationTabWidget, "VisualizationTabWidget")

        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
      namespace {

        Alexandre Leroux
    
Handles desynchronisation when removing variable from a graph (2)...

              r738
            
      /**

       * Applies a function to all zones of the tab represented by its layout

       * @param layout the layout that contains zones

       * @param fun the function to apply to each zone

       */

      template <typename Fun>

      void processZones(QLayout &layout, Fun fun)

      {

          for (auto i = 0; i < layout.count(); ++i) {

              if (auto item = layout.itemAt(i)) {

                  if (auto visualizationZoneWidget

        trabillard
    
Ensures graph and zone names are not duplicated in the visualization

              r1137
            
                      = qobject_cast<VisualizationZoneWidget *>(item->widget())) {

        Alexandre Leroux
    
Handles desynchronisation when removing variable from a graph (2)...

              r738
            
                      fun(*visualizationZoneWidget);

                  }

              }

          }

      }

        trabillard
    
Ensures graph and zone names are not duplicated in the visualization

              r1137
            
      /// Generates a default name for a new zone, according to the number of zones already displayed in

      /// the tab

      QString defaultZoneName(QLayout &layout)

      {

          QSet<QString> existingNames;

          processZones(layout,

                       [&existingNames](auto &zoneWidget) { existingNames.insert(zoneWidget.name()); });

          int zoneNum = 1;

          QString name;

          do {

              name = QObject::tr("Zone ").append(QString::number(zoneNum));

              ++zoneNum;

          } while (existingNames.contains(name));

          return name;

      }

        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
      } // namespace

        Alexandre Leroux
    
Adds a name for a tab...

              r198
            
      struct VisualizationTabWidget::VisualizationTabWidgetPrivate {

          explicit VisualizationTabWidgetPrivate(const QString &name) : m_Name{name} {}

        perrinel
    
Add the visualization gui classes

              r118
            
        Alexandre Leroux
    
Adds a name for a tab...

              r198
            
          QString m_Name;

        trabillard
    
drop of variables in the visualization

              r850
            
        Thibaud Rabillard
    
New style on mac to keep the scrollbars visible

              r930
            
      #ifdef Q_OS_MAC

          std::unique_ptr<MacScrollBarStyle> m_MacScrollBarStyle = std::make_unique<MacScrollBarStyle>();

      #endif

        trabillard
    
drop of variables in the visualization

              r850
            
          void dropGraph(int index, VisualizationTabWidget *tabWidget);

          void dropZone(int index, VisualizationTabWidget *tabWidget);

          void dropVariables(const QList<std::shared_ptr<Variable> > &variables, int index,

                             VisualizationTabWidget *tabWidget);

        Alexandre Leroux
    
Adds a name for a tab...

              r198
            
      };

      VisualizationTabWidget::VisualizationTabWidget(const QString &name, QWidget *parent)

              : QWidget{parent},

                ui{new Ui::VisualizationTabWidget},

                impl{spimpl::make_unique_impl<VisualizationTabWidgetPrivate>(name)}

        perrinel
    
Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget

              r58
            
      {

          ui->setupUi(this);

        Alexandre Leroux
    
Updates tab widget so it can be deleted when closed

              r267
            
        Thibaud Rabillard
    
New style on mac to keep the scrollbars visible

              r930
            
      #ifdef Q_OS_MAC

          impl->m_MacScrollBarStyle->selfInstallOn(ui->scrollArea, true);

      #endif

        trabillard
    
Rename "DragDropHelper" in "DragDropGuiController"

              r1075
            
          ui->dragDropContainer->setPlaceHolderType(DragDropGuiController::PlaceHolderType::Zone, "Zone");

        trabillard
    
Increase spacing at the bottom of the visu to give more space for dropping in a new zone

              r937
            
          ui->dragDropContainer->layout()->setContentsMargins(0, 0, 0, 12);

          ui->dragDropContainer->layout()->setSpacing(0);

        trabillard
    
drop of zone on the time widget

              r936
            
          ui->dragDropContainer->setMimeType(MIME_TYPE_GRAPH,

                                             VisualizationDragDropContainer::DropBehavior::Inserted);

          ui->dragDropContainer->setMimeType(MIME_TYPE_ZONE,

                                             VisualizationDragDropContainer::DropBehavior::Inserted);

          ui->dragDropContainer->setMimeType(MIME_TYPE_VARIABLE_LIST,

                                             VisualizationDragDropContainer::DropBehavior::Inserted);

        trabillard
    
Drag of the time widget on a graph

              r879
            
        trabillard
    
drop of variables in the visualization

              r850
            
          ui->dragDropContainer->setAcceptMimeDataFunction([this](auto mimeData) {

        trabillard
    
Rename "DragDropHelper" in "DragDropGuiController"

              r1075
            
              return sqpApp->dragDropGuiController().checkMimeDataForVisualization(mimeData,

                                                                                   ui->dragDropContainer);

        trabillard
    
drop of variables in the visualization

              r850
            
          });

        trabillard
    
Drag of the time widget on a graph

              r879
            
          connect(ui->dragDropContainer, &VisualizationDragDropContainer::dropOccuredInContainer, this,

                  &VisualizationTabWidget::dropMimeData);

        trabillard
    
Rename "DragDropHelper" in "DragDropGuiController"

              r1075
            
          sqpApp->dragDropGuiController().addDragDropScrollArea(ui->scrollArea);

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
        Alexandre Leroux
    
Updates tab widget so it can be deleted when closed

              r267
            
          // Widget is deleted when closed

          setAttribute(Qt::WA_DeleteOnClose);

        perrinel
    
Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget

              r58
            
      }

      VisualizationTabWidget::~VisualizationTabWidget()

      {

        trabillard
    
Rename "DragDropHelper" in "DragDropGuiController"

              r1075
            
          sqpApp->dragDropGuiController().removeDragDropScrollArea(ui->scrollArea);

        perrinel
    
Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget

              r58
            
          delete ui;

      }

        perrinel
    
Add the visualization gui classes

              r118
            
      void VisualizationTabWidget::addZone(VisualizationZoneWidget *zoneWidget)

      {

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
          ui->dragDropContainer->addDragWidget(zoneWidget);

      }

      void VisualizationTabWidget::insertZone(int index, VisualizationZoneWidget *zoneWidget)

      {

        trabillard
    
Format changes

              r844
            
          ui->dragDropContainer->insertDragWidget(index, zoneWidget);

        perrinel
    
Add the visualization gui classes

              r118
            
      }

        trabillard
    
Retrieves zone names from the visualization

              r1136
            
      QStringList VisualizationTabWidget::availableZoneWidgets() const

      {

          QStringList zones;

          processZones(tabLayout(),

                       [&zones](VisualizationZoneWidget &zoneWidget) { zones << zoneWidget.name(); });

          return zones;

      }

        trabillard
    
Time Zone Mode + prepare graph mode

              r1138
            
      VisualizationZoneWidget *VisualizationTabWidget::getZoneWithName(const QString &zoneName)

      {

          VisualizationZoneWidget *result = nullptr;

          processZones(tabLayout(), [&zoneName, &result](VisualizationZoneWidget &zoneWidget) {

              if (!result && zoneWidget.name() == zoneName) {

                  result = &zoneWidget;

              }

          });

          return result;

      }

        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
      VisualizationZoneWidget *VisualizationTabWidget::createZone(std::shared_ptr<Variable> variable)

        perrinel
    
Add the visualization gui classes

              r118
            
      {

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
          return createZone({variable}, -1);

      }

        trabillard
    
Format changes

              r844
            
      VisualizationZoneWidget *

      VisualizationTabWidget::createZone(const QList<std::shared_ptr<Variable> > &variables, int index)

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
      {

        trabillard
    
Manage drag&drop of empty graphs

              r841
            
          auto zoneWidget = createEmptyZone(index);

        perrinel
    
Add the visualization gui classes

              r118
            
        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
          // Creates a new graph into the zone

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
          zoneWidget->createGraph(variables, index);

        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
        perrinel
    
Add the visualization gui classes

              r118
            
          return zoneWidget;

      }

        trabillard
    
Manage drag&drop of empty graphs

              r841
            
      VisualizationZoneWidget *VisualizationTabWidget::createEmptyZone(int index)

      {

        trabillard
    
Format changes

              r844
            
          auto zoneWidget

              = new VisualizationZoneWidget{defaultZoneName(*ui->dragDropContainer->layout()), this};

        trabillard
    
Manage drag&drop of empty graphs

              r841
            
          this->insertZone(index, zoneWidget);

          return zoneWidget;

      }

        Alexandre Leroux
    
Updates visitor interface...

              r207
            
      void VisualizationTabWidget::accept(IVisualizationWidgetVisitor *visitor)

        perrinel
    
Add the visualization gui classes

              r118
            
      {

        Alexandre Leroux
    
Implements accept() method of visualization widgets

              r208
            
          if (visitor) {

              visitor->visitEnter(this);

        Alexandre Leroux
    
Handles desynchronisation when removing variable from a graph (2)...

              r738
            
              // Apply visitor to zone children: widgets different from zones are not visited (no action)

              processZones(tabLayout(), [visitor](VisualizationZoneWidget &zoneWidget) {

                  zoneWidget.accept(visitor);

              });

        Alexandre Leroux
    
Implements accept() method of visualization widgets

              r208
            
              visitor->visitLeave(this);

          }

        Alexandre Leroux
    
Adds logs for null visitors

              r219
            
          else {

              qCCritical(LOG_VisualizationTabWidget()) << tr("Can't visit widget : the visitor is null");

          }

        perrinel
    
Add the visualization gui classes

              r118
            
      }

        Alexandre Leroux
    
Creates a interface that defines a variable container...

              r209
            
      bool VisualizationTabWidget::canDrop(const Variable &variable) const

      {

          // A tab can always accomodate a variable

          Q_UNUSED(variable);

          return true;

      }

        Alexandre Leroux
    
Unplot menu (5): adds contains() method to an IVariableContainer...

              r327
            
      bool VisualizationTabWidget::contains(const Variable &variable) const

      {

          Q_UNUSED(variable);

          return false;

      }

        perrinel
    
Add const and override

              r119
            
      QString VisualizationTabWidget::name() const

        perrinel
    
Add the visualization gui classes

              r118
            
      {

        Alexandre Leroux
    
Adds a name for a tab...

              r198
            
          return impl->m_Name;

        perrinel
    
Add the visualization gui classes

              r118
            
      }

        Alexandre Leroux
    
Adds scrollbar to tabs

              r307
            
        Alexandre Leroux
    
Handles desynchronisation when removing variable from a graph (2)...

              r738
            
      void VisualizationTabWidget::closeEvent(QCloseEvent *event)

      {

          // Closes zones in the tab

          processZones(tabLayout(), [](VisualizationZoneWidget &zoneWidget) { zoneWidget.close(); });

          QWidget::closeEvent(event);

      }

        Alexandre Leroux
    
Adds scrollbar to tabs

              r307
            
      QLayout &VisualizationTabWidget::tabLayout() const noexcept

      {

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
          return *ui->dragDropContainer->layout();

      }

      void VisualizationTabWidget::dropMimeData(int index, const QMimeData *mimeData)

      {

        trabillard
    
Move Common MIME types constants in a Definition file in core module.

              r848
            
          if (mimeData->hasFormat(MIME_TYPE_GRAPH)) {

        trabillard
    
drop of variables in the visualization

              r850
            
              impl->dropGraph(index, this);

          }

          else if (mimeData->hasFormat(MIME_TYPE_ZONE)) {

              impl->dropZone(index, this);

          }

          else if (mimeData->hasFormat(MIME_TYPE_VARIABLE_LIST)) {

              auto variables = sqpApp->variableController().variablesForMimeData(

                  mimeData->data(MIME_TYPE_VARIABLE_LIST));

              impl->dropVariables(variables, index, this);

          }

          else {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropMimeData, unknown MIME data received.");

          }

      }

      void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropGraph(

          int index, VisualizationTabWidget *tabWidget)

      {

        trabillard
    
Rename "DragDropHelper" in "DragDropGuiController"

              r1075
            
          auto &helper = sqpApp->dragDropGuiController();

        trabillard
    
drop of variables in the visualization

              r850
            
          auto graphWidget = qobject_cast<VisualizationGraphWidget *>(helper.getCurrentDragWidget());

          if (!graphWidget) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropGraph, drop aborted, the dropped graph is not "

                        "found or invalid.");

              Q_ASSERT(false);

              return;

          }

          auto parentDragDropContainer

              = qobject_cast<VisualizationDragDropContainer *>(graphWidget->parentWidget());

          if (!parentDragDropContainer) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropGraph, drop aborted, the parent container of "

                        "the dropped graph is not found.");

              Q_ASSERT(false);

              return;

          }

          auto nbGraph = parentDragDropContainer->countDragWidget();

        trabillard
    
Manage drag&drop of empty graphs

              r841
            
        trabillard
    
drop of variables in the visualization

              r850
            
          const auto &variables = graphWidget->variables();

          if (!variables.isEmpty()) {

              // Abort the requests for the variables (if any)

              // Commented, because it's not sure if it's needed or not

              // for (const auto& var : variables)

              //{

              //    sqpApp->variableController().onAbortProgressRequested(var);

              //}

              if (nbGraph == 1) {

                  // This is the only graph in the previous zone, close the zone

        Thibaud Rabillard
    
Fix for D&D bug on mac

              r911
            
                  helper.delayedCloseWidget(graphWidget->parentZoneWidget());

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
              }

        trabillard
    
Format changes

              r844
            
              else {

        trabillard
    
drop of variables in the visualization

              r850
            
                  // Close the graph

        Thibaud Rabillard
    
Fix for D&D bug on mac

              r911
            
                  helper.delayedCloseWidget(graphWidget);

        trabillard
    
drop of variables in the visualization

              r850
            
              }

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
        trabillard
    
Keep the selection zones when a graph is dropped in another synchro zone

              r1048
            
              auto zoneWidget = tabWidget->createZone(variables, index);

              auto firstGraph = zoneWidget->firstGraph();

              if (firstGraph) {

                  firstGraph->addSelectionZones(graphWidget->selectionZoneRanges());

              }

              else {

                  qCWarning(LOG_VisualizationZoneWidget())

                      << tr("VisualizationTabWidget::dropGraph, no graph added in the widget.");

                  Q_ASSERT(false);

              }

        trabillard
    
drop of variables in the visualization

              r850
            
          }

          else {

              // The graph is empty, create an empty zone and move the graph inside

        trabillard
    
Manage drag&drop of empty graphs

              r841
            
        trabillard
    
drop of variables in the visualization

              r850
            
              auto parentZoneWidget = graphWidget->parentZoneWidget();

        trabillard
    
Manage drag&drop of empty graphs

              r841
            
        trabillard
    
drop of variables in the visualization

              r850
            
              parentDragDropContainer->layout()->removeWidget(graphWidget);

        trabillard
    
Manage drag&drop of empty graphs

              r841
            
        trabillard
    
drop of variables in the visualization

              r850
            
              auto zoneWidget = tabWidget->createEmptyZone(index);

              zoneWidget->addGraph(graphWidget);

              // Close the old zone if it was the only graph inside

              if (nbGraph == 1) {

        Thibaud Rabillard
    
Fix for D&D bug on mac

              r911
            
                  helper.delayedCloseWidget(parentZoneWidget);

        trabillard
    
Manage drag&drop of empty graphs

              r841
            
              }

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
          }

        trabillard
    
drop of variables in the visualization

              r850
            
      }

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
        trabillard
    
drop of variables in the visualization

              r850
            
      void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropZone(

          int index, VisualizationTabWidget *tabWidget)

      {

        trabillard
    
Rename "DragDropHelper" in "DragDropGuiController"

              r1075
            
          auto &helper = sqpApp->dragDropGuiController();

        trabillard
    
drop of variables in the visualization

              r850
            
          auto zoneWidget = qobject_cast<VisualizationZoneWidget *>(helper.getCurrentDragWidget());

          if (!zoneWidget) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropZone, drop aborted, the dropped zone is not "

                        "found or invalid.");

              Q_ASSERT(false);

              return;

          }

          auto parentDragDropContainer

              = qobject_cast<VisualizationDragDropContainer *>(zoneWidget->parentWidget());

          if (!parentDragDropContainer) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropZone, drop aborted, the parent container of "

                        "the dropped zone is not found.");

              Q_ASSERT(false);

              return;

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r839
            
          }

        trabillard
    
drop of variables in the visualization

              r850
            
          // Simple move of the zone, no variable operation associated

          parentDragDropContainer->layout()->removeWidget(zoneWidget);

          tabWidget->ui->dragDropContainer->insertDragWidget(index, zoneWidget);

      }

      void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropVariables(

          const QList<std::shared_ptr<Variable> > &variables, int index,

          VisualizationTabWidget *tabWidget)

      {

        trabillard
    
Drag of product

              r868
            
          // Note: the AcceptMimeDataFunction (set on the drop container) ensure there is a single and

          // compatible variable here

          if (variables.count() > 1) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropVariables, dropping multiple variables, operation "

                        "aborted.");

              return;

        trabillard
    
Drop of product in variables

              r870
            
          }

        trabillard
    
Drag of product

              r868
            
        trabillard
    
drop of variables in the visualization

              r850
            
          tabWidget->createZone(variables, index);

        Alexandre Leroux
    
Adds scrollbar to tabs

              r307
            
      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

perrinel mv visualization -> Visualization...	r95	#include "Visualization/VisualizationTabWidget.h"
Alexandre Leroux Updates visitor interface...	r207	#include "Visualization/IVisualizationWidgetVisitor.h"
perrinel Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget	r58	#include "ui_VisualizationTabWidget.h"

trabillard Integrates the drag&drop classes into the existing visualization classes.	r839	#include "Visualization/VisualizationGraphWidget.h"
trabillard Format changes	r844	#include "Visualization/VisualizationZoneWidget.h"
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839
Thibaud Rabillard New style on mac to keep the scrollbars visible	r930	#include "Visualization/MacScrollBarStyle.h"

trabillard Manage drag&drop of empty graphs	r841	#include "Variable/VariableController.h"

trabillard Move Common MIME types constants in a Definition file in core module.	r848	#include "Common/MimeTypesDef.h"

trabillard Rename "DragDropHelper" in "DragDropGuiController"	r1075	#include "DragAndDrop/DragDropGuiController.h"
trabillard Format changes	r844	#include "SqpApplication.h"
perrinel Add the visualization gui classes	r118
Alexandre Leroux Adds logs for null visitors	r219	Q_LOGGING_CATEGORY(LOG_VisualizationTabWidget, "VisualizationTabWidget")

Alexandre Leroux Completes the method of creating a zone from a variable	r201	namespace {

Alexandre Leroux Handles desynchronisation when removing variable from a graph (2)...	r738	/**
		* Applies a function to all zones of the tab represented by its layout
		* @param layout the layout that contains zones
		* @param fun the function to apply to each zone
		*/
		template <typename Fun>
		void processZones(QLayout &layout, Fun fun)
		{
		for (auto i = 0; i < layout.count(); ++i) {
		if (auto item = layout.itemAt(i)) {
		if (auto visualizationZoneWidget
trabillard Ensures graph and zone names are not duplicated in the visualization	r1137	= qobject_cast<VisualizationZoneWidget *>(item->widget())) {
Alexandre Leroux Handles desynchronisation when removing variable from a graph (2)...	r738	fun(*visualizationZoneWidget);
		}
		}
		}
		}

trabillard Ensures graph and zone names are not duplicated in the visualization	r1137	/// Generates a default name for a new zone, according to the number of zones already displayed in
		/// the tab
		QString defaultZoneName(QLayout &layout)
		{
		QSet<QString> existingNames;
		processZones(layout,
		[&existingNames](auto &zoneWidget) { existingNames.insert(zoneWidget.name()); });

		int zoneNum = 1;
		QString name;
		do {
		name = QObject::tr("Zone ").append(QString::number(zoneNum));
		++zoneNum;
		} while (existingNames.contains(name));

		return name;
		}

Alexandre Leroux Completes the method of creating a zone from a variable	r201	} // namespace

Alexandre Leroux Adds a name for a tab...	r198	struct VisualizationTabWidget::VisualizationTabWidgetPrivate {
		explicit VisualizationTabWidgetPrivate(const QString &name) : m_Name{name} {}
perrinel Add the visualization gui classes	r118
Alexandre Leroux Adds a name for a tab...	r198	QString m_Name;
trabillard drop of variables in the visualization	r850
Thibaud Rabillard New style on mac to keep the scrollbars visible	r930	#ifdef Q_OS_MAC
		std::unique_ptr<MacScrollBarStyle> m_MacScrollBarStyle = std::make_unique<MacScrollBarStyle>();
		#endif

trabillard drop of variables in the visualization	r850	void dropGraph(int index, VisualizationTabWidget *tabWidget);
		void dropZone(int index, VisualizationTabWidget *tabWidget);
		void dropVariables(const QList<std::shared_ptr<Variable> > &variables, int index,
		VisualizationTabWidget *tabWidget);
Alexandre Leroux Adds a name for a tab...	r198	};

		VisualizationTabWidget::VisualizationTabWidget(const QString &name, QWidget *parent)
		: QWidget{parent},
		ui{new Ui::VisualizationTabWidget},
		impl{spimpl::make_unique_impl<VisualizationTabWidgetPrivate>(name)}
perrinel Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget	r58	{
		ui->setupUi(this);
Alexandre Leroux Updates tab widget so it can be deleted when closed	r267
Thibaud Rabillard New style on mac to keep the scrollbars visible	r930	#ifdef Q_OS_MAC
		impl->m_MacScrollBarStyle->selfInstallOn(ui->scrollArea, true);
		#endif

trabillard Rename "DragDropHelper" in "DragDropGuiController"	r1075	ui->dragDropContainer->setPlaceHolderType(DragDropGuiController::PlaceHolderType::Zone, "Zone");
trabillard Increase spacing at the bottom of the visu to give more space for dropping in a new zone	r937	ui->dragDropContainer->layout()->setContentsMargins(0, 0, 0, 12);
		ui->dragDropContainer->layout()->setSpacing(0);
trabillard drop of zone on the time widget	r936	ui->dragDropContainer->setMimeType(MIME_TYPE_GRAPH,
		VisualizationDragDropContainer::DropBehavior::Inserted);
		ui->dragDropContainer->setMimeType(MIME_TYPE_ZONE,
		VisualizationDragDropContainer::DropBehavior::Inserted);
		ui->dragDropContainer->setMimeType(MIME_TYPE_VARIABLE_LIST,
		VisualizationDragDropContainer::DropBehavior::Inserted);
trabillard Drag of the time widget on a graph	r879
trabillard drop of variables in the visualization	r850	ui->dragDropContainer->setAcceptMimeDataFunction([this](auto mimeData) {
trabillard Rename "DragDropHelper" in "DragDropGuiController"	r1075	return sqpApp->dragDropGuiController().checkMimeDataForVisualization(mimeData,
		ui->dragDropContainer);
trabillard drop of variables in the visualization	r850	});
trabillard Drag of the time widget on a graph	r879
		connect(ui->dragDropContainer, &VisualizationDragDropContainer::dropOccuredInContainer, this,
		&VisualizationTabWidget::dropMimeData);

trabillard Rename "DragDropHelper" in "DragDropGuiController"	r1075	sqpApp->dragDropGuiController().addDragDropScrollArea(ui->scrollArea);
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839
Alexandre Leroux Updates tab widget so it can be deleted when closed	r267	// Widget is deleted when closed
		setAttribute(Qt::WA_DeleteOnClose);
perrinel Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget	r58	}

		VisualizationTabWidget::~VisualizationTabWidget()
		{
trabillard Rename "DragDropHelper" in "DragDropGuiController"	r1075	sqpApp->dragDropGuiController().removeDragDropScrollArea(ui->scrollArea);
perrinel Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget	r58	delete ui;
		}
perrinel Add the visualization gui classes	r118
		void VisualizationTabWidget::addZone(VisualizationZoneWidget *zoneWidget)
		{
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839	ui->dragDropContainer->addDragWidget(zoneWidget);
		}

		void VisualizationTabWidget::insertZone(int index, VisualizationZoneWidget *zoneWidget)
		{
trabillard Format changes	r844	ui->dragDropContainer->insertDragWidget(index, zoneWidget);
perrinel Add the visualization gui classes	r118	}

trabillard Retrieves zone names from the visualization	r1136	QStringList VisualizationTabWidget::availableZoneWidgets() const
		{
		QStringList zones;
		processZones(tabLayout(),
		[&zones](VisualizationZoneWidget &zoneWidget) { zones << zoneWidget.name(); });

		return zones;
		}

trabillard Time Zone Mode + prepare graph mode	r1138	VisualizationZoneWidget *VisualizationTabWidget::getZoneWithName(const QString &zoneName)
		{
		VisualizationZoneWidget *result = nullptr;
		processZones(tabLayout(), [&zoneName, &result](VisualizationZoneWidget &zoneWidget) {
		if (!result && zoneWidget.name() == zoneName) {
		result = &zoneWidget;
		}
		});

		return result;
		}

Alexandre Leroux Completes the method of creating a zone from a variable	r201	VisualizationZoneWidget *VisualizationTabWidget::createZone(std::shared_ptr<Variable> variable)
perrinel Add the visualization gui classes	r118	{
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839	return createZone({variable}, -1);
		}

trabillard Format changes	r844	VisualizationZoneWidget *
		VisualizationTabWidget::createZone(const QList<std::shared_ptr<Variable> > &variables, int index)
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839	{
trabillard Manage drag&drop of empty graphs	r841	auto zoneWidget = createEmptyZone(index);
perrinel Add the visualization gui classes	r118
Alexandre Leroux Completes the method of creating a zone from a variable	r201	// Creates a new graph into the zone
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839	zoneWidget->createGraph(variables, index);
Alexandre Leroux Completes the method of creating a zone from a variable	r201
perrinel Add the visualization gui classes	r118	return zoneWidget;
		}

trabillard Manage drag&drop of empty graphs	r841	VisualizationZoneWidget *VisualizationTabWidget::createEmptyZone(int index)
		{
trabillard Format changes	r844	auto zoneWidget
		= new VisualizationZoneWidget{defaultZoneName(*ui->dragDropContainer->layout()), this};
trabillard Manage drag&drop of empty graphs	r841	this->insertZone(index, zoneWidget);

		return zoneWidget;
		}

Alexandre Leroux Updates visitor interface...	r207	void VisualizationTabWidget::accept(IVisualizationWidgetVisitor *visitor)
perrinel Add the visualization gui classes	r118	{
Alexandre Leroux Implements accept() method of visualization widgets	r208	if (visitor) {
		visitor->visitEnter(this);

Alexandre Leroux Handles desynchronisation when removing variable from a graph (2)...	r738	// Apply visitor to zone children: widgets different from zones are not visited (no action)
		processZones(tabLayout(), [visitor](VisualizationZoneWidget &zoneWidget) {
		zoneWidget.accept(visitor);
		});
Alexandre Leroux Implements accept() method of visualization widgets	r208
		visitor->visitLeave(this);
		}
Alexandre Leroux Adds logs for null visitors	r219	else {
		qCCritical(LOG_VisualizationTabWidget()) << tr("Can't visit widget : the visitor is null");
		}
perrinel Add the visualization gui classes	r118	}

Alexandre Leroux Creates a interface that defines a variable container...	r209	bool VisualizationTabWidget::canDrop(const Variable &variable) const
		{
		// A tab can always accomodate a variable
		Q_UNUSED(variable);
		return true;
		}

Alexandre Leroux Unplot menu (5): adds contains() method to an IVariableContainer...	r327	bool VisualizationTabWidget::contains(const Variable &variable) const
		{
		Q_UNUSED(variable);
		return false;
		}

perrinel Add const and override	r119	QString VisualizationTabWidget::name() const
perrinel Add the visualization gui classes	r118	{
Alexandre Leroux Adds a name for a tab...	r198	return impl->m_Name;
perrinel Add the visualization gui classes	r118	}
Alexandre Leroux Adds scrollbar to tabs	r307
Alexandre Leroux Handles desynchronisation when removing variable from a graph (2)...	r738	void VisualizationTabWidget::closeEvent(QCloseEvent *event)
		{
		// Closes zones in the tab
		processZones(tabLayout(), [](VisualizationZoneWidget &zoneWidget) { zoneWidget.close(); });

		QWidget::closeEvent(event);
		}

Alexandre Leroux Adds scrollbar to tabs	r307	QLayout &VisualizationTabWidget::tabLayout() const noexcept
		{
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839	return *ui->dragDropContainer->layout();
		}

		void VisualizationTabWidget::dropMimeData(int index, const QMimeData *mimeData)
		{
trabillard Move Common MIME types constants in a Definition file in core module.	r848	if (mimeData->hasFormat(MIME_TYPE_GRAPH)) {
trabillard drop of variables in the visualization	r850	impl->dropGraph(index, this);
		}
		else if (mimeData->hasFormat(MIME_TYPE_ZONE)) {
		impl->dropZone(index, this);
		}
		else if (mimeData->hasFormat(MIME_TYPE_VARIABLE_LIST)) {
		auto variables = sqpApp->variableController().variablesForMimeData(
		mimeData->data(MIME_TYPE_VARIABLE_LIST));
		impl->dropVariables(variables, index, this);
		}
		else {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropMimeData, unknown MIME data received.");
		}
		}

		void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropGraph(
		int index, VisualizationTabWidget *tabWidget)
		{
trabillard Rename "DragDropHelper" in "DragDropGuiController"	r1075	auto &helper = sqpApp->dragDropGuiController();
trabillard drop of variables in the visualization	r850
		auto graphWidget = qobject_cast<VisualizationGraphWidget *>(helper.getCurrentDragWidget());
		if (!graphWidget) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropGraph, drop aborted, the dropped graph is not "
		"found or invalid.");
		Q_ASSERT(false);
		return;
		}

		auto parentDragDropContainer
		= qobject_cast<VisualizationDragDropContainer *>(graphWidget->parentWidget());
		if (!parentDragDropContainer) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropGraph, drop aborted, the parent container of "
		"the dropped graph is not found.");
		Q_ASSERT(false);
		return;
		}

		auto nbGraph = parentDragDropContainer->countDragWidget();
trabillard Manage drag&drop of empty graphs	r841
trabillard drop of variables in the visualization	r850	const auto &variables = graphWidget->variables();

		if (!variables.isEmpty()) {
		// Abort the requests for the variables (if any)
		// Commented, because it's not sure if it's needed or not
		// for (const auto& var : variables)
		//{
		// sqpApp->variableController().onAbortProgressRequested(var);
		//}

		if (nbGraph == 1) {
		// This is the only graph in the previous zone, close the zone
Thibaud Rabillard Fix for D&D bug on mac	r911	helper.delayedCloseWidget(graphWidget->parentZoneWidget());
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839	}
trabillard Format changes	r844	else {
trabillard drop of variables in the visualization	r850	// Close the graph
Thibaud Rabillard Fix for D&D bug on mac	r911	helper.delayedCloseWidget(graphWidget);
trabillard drop of variables in the visualization	r850	}
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839
trabillard Keep the selection zones when a graph is dropped in another synchro zone	r1048	auto zoneWidget = tabWidget->createZone(variables, index);
		auto firstGraph = zoneWidget->firstGraph();
		if (firstGraph) {
		firstGraph->addSelectionZones(graphWidget->selectionZoneRanges());
		}
		else {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropGraph, no graph added in the widget.");
		Q_ASSERT(false);
		}
trabillard drop of variables in the visualization	r850	}
		else {
		// The graph is empty, create an empty zone and move the graph inside
trabillard Manage drag&drop of empty graphs	r841
trabillard drop of variables in the visualization	r850	auto parentZoneWidget = graphWidget->parentZoneWidget();
trabillard Manage drag&drop of empty graphs	r841
trabillard drop of variables in the visualization	r850	parentDragDropContainer->layout()->removeWidget(graphWidget);
trabillard Manage drag&drop of empty graphs	r841
trabillard drop of variables in the visualization	r850	auto zoneWidget = tabWidget->createEmptyZone(index);
		zoneWidget->addGraph(graphWidget);

		// Close the old zone if it was the only graph inside
		if (nbGraph == 1) {
Thibaud Rabillard Fix for D&D bug on mac	r911	helper.delayedCloseWidget(parentZoneWidget);
trabillard Manage drag&drop of empty graphs	r841	}
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839	}
trabillard drop of variables in the visualization	r850	}
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839
trabillard drop of variables in the visualization	r850	void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropZone(
		int index, VisualizationTabWidget *tabWidget)
		{
trabillard Rename "DragDropHelper" in "DragDropGuiController"	r1075	auto &helper = sqpApp->dragDropGuiController();
trabillard drop of variables in the visualization	r850
		auto zoneWidget = qobject_cast<VisualizationZoneWidget *>(helper.getCurrentDragWidget());
		if (!zoneWidget) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropZone, drop aborted, the dropped zone is not "
		"found or invalid.");
		Q_ASSERT(false);
		return;
		}

		auto parentDragDropContainer
		= qobject_cast<VisualizationDragDropContainer *>(zoneWidget->parentWidget());
		if (!parentDragDropContainer) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropZone, drop aborted, the parent container of "
		"the dropped zone is not found.");
		Q_ASSERT(false);
		return;
trabillard Integrates the drag&drop classes into the existing visualization classes.	r839	}
trabillard drop of variables in the visualization	r850
		// Simple move of the zone, no variable operation associated
		parentDragDropContainer->layout()->removeWidget(zoneWidget);
		tabWidget->ui->dragDropContainer->insertDragWidget(index, zoneWidget);
		}

		void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropVariables(
		const QList<std::shared_ptr<Variable> > &variables, int index,
		VisualizationTabWidget *tabWidget)
		{
trabillard Drag of product	r868	// Note: the AcceptMimeDataFunction (set on the drop container) ensure there is a single and
		// compatible variable here
		if (variables.count() > 1) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropVariables, dropping multiple variables, operation "
		"aborted.");
		return;
trabillard Drop of product in variables	r870	}
trabillard Drag of product	r868
trabillard drop of variables in the visualization	r850	tabWidget->createZone(variables, index);
Alexandre Leroux Adds scrollbar to tabs	r307	}