HG_REPOSITORIES/LPP/INSTRUMENTATION/USERS/JEANDET/qtcharts Commit - r386:fe666a26d3fa

Review corrections for pie

Jani Honkonen -

r386:fe666a26d3fa

parent child

Context file:

r386:fe666a26d3fa

Collapse all files

example/piechart/main.cpp +2 -2

                  //! [1]
                  //! [2]
-                 series->enableHoverHighlight(true);
-                 series->enableClickExplodes(true);
+                 series->setHoverHighlighting();
+                 series->setClickExplodes();
                  //! [2]
                  window.setCentralWidget(chartView);

src/piechart/qpieseries.cpp +6 -11

                  The pie series defines a pie chart which consists of pie slices which are QPieSlice objects.
                  The slices can have any values as the QPieSeries will calculate its relative value to the sum of all slices.
-                 The actual slice size (span) is determined by that relative value.
+                 The actual slice size is determined by that relative value.
-                 By default the pie is defined as full but it can be a partial pie.
+                 By default the pie is defined as a full pie but it can be a partial pie.
                  This can be done by setting a starting angle and angle span to the series.
-                 Example on how to create a chart with pie series:
-                 \snippet ../example/piechart/main.cpp 1
-                 To help with the most common user intercation scenarions there some convenience functions. Specifically
-                 exploding and higlighting:
-                 \snippet ../example/piechart/main.cpp 2
+                 To help with the most common user interaction scenarions there some convenience functions.
+                 Like exploding a slice when clicked and higlighting when user hovers over a slice.
              */
              /*!
                  \sa QPieSlice::isExploded(), QPieSlice::setExploded(), QPieSlice::setExplodeDistance()
              */
-             void QPieSeries::enableClickExplodes(bool enable)
+             void QPieSeries::setClickExplodes(bool enable)
              {
                  if (enable)
                      connect(this, SIGNAL(clicked(QPieSlice*)), this, SLOT(toggleExploded(QPieSlice*)));
                  \sa QPieSlice::isExploded(), QPieSlice::setExploded()
              */
-             void QPieSeries::enableHoverHighlight(bool enable)
+             void QPieSeries::setHoverHighlighting(bool enable)
              {
                  if (enable) {
                      connect(this, SIGNAL(hoverEnter(QPieSlice*)), this, SLOT(highlightOn(QPieSlice*)));

src/piechart/qpieseries.h +3 -6

                  void clear();
                  int count() const;
                  QList<QPieSlice*> slices() const;
                  void setSizeFactor(qreal sizeFactor);
                  qreal sizeFactor() const;
                  void setPosition(PiePosition position);
                  PiePosition position() const;
                  void setSpan(qreal startAngle, qreal angleSpan);
-                 void setLabelsVisible(bool visible);
-                 void enableClickExplodes(bool enable);
-                 void enableHoverHighlight(bool enable);
+                 void setLabelsVisible(bool visible = true);
+                 void setClickExplodes(bool enable = true);
+                 void setHoverHighlighting(bool enable = true);
                  // TODO: find slices?
                  // QList<QPieSlice*> findByValue(qreal value);

src/piechart/qpieslice.cpp +3 -2

              /*!
                  Returns the percentage of this slice compared to all slices in the same series.
+                 The returned value ranges from 0 to 1.0.
                  Updated internally after the slice is added to the series.
              */
              /*!
                  Sets this slice \a exploded.
-                 \sa isExploded(), setExplodeDistance(), QPieSeries::enableClickExplodes()
+                 \sa isExploded(), setExplodeDistance(), QPieSeries::setClickExplodes()
              */
              void QPieSlice::setExploded(bool exploded)
              {
              /*!
                  Sets the explosion \a distance of this slice.
                  It is the distance the slice is moved away from the pie center.
-                 \sa explodeDistance(), isExploded(), QPieSeries::enableClickExplodes()
+                 \sa explodeDistance(), isExploded(), QPieSeries::setClickExplodes()
              */
              void QPieSlice::setExplodeDistance(qreal distance)
              {

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages