HG_REPOSITORIES/LPP/INSTRUMENTATION/USERS/JEANDET/qtcharts Commit - r2427:b3d485323aa9

Fix crash when changing the values to empty model with logarithmic axis...

Miikka Heikkinen -

r2427:b3d485323aa9

parent child

Context file:

r2427:b3d485323aa9

Collapse all files

README +2 -1

             - Fixed: Using setLineVisible(false) on a QBarCategoryAxis gives blurry text
             - Fixed: Set the range to min and max for default axes from previously added series
             - Fixed: Axes use incorrect bounding rectangle to calculate sizeHint when labels are in non-default angle
-            - Fixes: Axis titles can slightly overlap with axis labels and axis lines
+            - Fixed: Axis titles can slightly overlap with axis labels and axis lines
+            - Fixed: Charts crashes when changing the values to empty model with logarithmic axis
             Known Issues
             ============

src/xychart/xychart.cpp +9 -11

                 QVector<QPointF> points;
-                if (m_dirty) {
+                if (m_dirty || m_points.isEmpty()) {
                     points = domain()->calculateGeometryPoints(m_series->points());
                 } else {
                     points = m_points;
                     QPointF point = domain()->calculateGeometryPoint(m_series->points()[index], m_validData);
-                    if (!m_validData) {
+                    if (!m_validData)
                         m_points.clear();
-                        return;
+                    else
+                        points.insert(index, point);
-                    points.insert(index, point);
                 }
                 updateChart(m_points, points, index);
                 QVector<QPointF> points;
-                if (m_dirty) {
+                if (m_dirty || m_points.isEmpty()) {
                     points = domain()->calculateGeometryPoints(m_series->points());
                 } else {
                     points = m_points;
                 QVector<QPointF> points;
-                if (m_dirty) {
+                if (m_dirty || m_points.isEmpty()) {
                     points = domain()->calculateGeometryPoints(m_series->points());
                 } else {
                     QPointF point = domain()->calculateGeometryPoint(m_series->points()[index], m_validData);
-                    if (!m_validData) {
+                    if (!m_validData)
                         m_points.clear();
-                        return;
                     points = m_points;
-                    points.replace(index, point);
+                    if (m_validData)
+                        points.replace(index, point);
                 }
                 updateChart(m_points, points, index);

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages