HG_REPOSITORIES/LPP/INSTRUMENTATION/USERS/JEANDET/qtcharts Commit - r204:a4ba86638d8d

Fix a major memory leak

Jani Honkonen -

r204:a4ba86638d8d

parent child

Context file:

r204:a4ba86638d8d

src/chartdataset.cpp +1 0

             {
                 // TODO: we should check the series not already added
                 m_chartSeries << series;
+                series->setParent(this); // take ownership
                 m_domainIndex = 0;
                 m_domains.resize(1);

src/piechart/qpieseries.cpp +1 -2

             QPieSeries::~QPieSeries()
             {
-                // slices destroyed by parent object
-                qDebug() << "~QPieSeries";
             }
             bool QPieSeries::setData(QList<qreal> data)

src/qchartview.cpp +1 -1

             QChartView::QChartView(QWidget *parent) :
             QGraphicsView(parent),
-            m_scene(new QGraphicsScene()),
+            m_scene(new QGraphicsScene(this)),
             m_chart(new QChart()),
             m_rubberBand(0),
             m_verticalRubberBand(false),

src/qchartview.h +1 -1

                 //implement from QWidget
                 void resizeEvent(QResizeEvent *event);
-                void addSeries(QChartSeries* series);
+                void addSeries(QChartSeries* series); // takes ownership
                 // Convenience function
                 QChartSeries* createSeries(QChartSeries::QChartSeriesType type);

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages