HG_REPOSITORIES/LPP/INSTRUMENTATION/USERS/JEANDET/qtcharts Commit - r2477:56fd46a39576

0

src/animations/axisanimation.cpp +6 0

              {
                  if (state() != QAbstractAnimation::Stopped) stop();
+             //  TODO: cannot return even if layout is empty
+             //  New layout is not set properly without it (crash)
+             //    if (newLayout.count() == 0)
+             //        return;
                  switch (m_type) {
                  case ZoomOutAnimation: {
                      QRectF rect = m_axis->gridGeometry();
              {
                  if (state() != QAbstractAnimation::Stopped) { //workaround
                      QVector<qreal> vector = qvariant_cast<QVector<qreal> >(value);
+             //        Q_ASSERT(vector.count() != 0);
                      m_axis->setLayout(vector);
                      m_axis->updateGeometry();
                  }

0

src/areachart/areachartitem.cpp +2 0

              QTCOMMERCIALCHART_BEGIN_NAMESPACE
+             //TODO: optimize : remove points which are not visible
              AreaChartItem::AreaChartItem(QAreaSeries *areaSeries, QGraphicsItem* item)
                  : ChartItem(areaSeries->d_func(),item),
                    m_series(areaSeries),

0

src/axis/barcategoryaxis/qbarcategoryaxis.cpp +4 0

                              setRange(d->m_minCategory, d->m_categories.last());
                          } else {
                              d->updateCategoryDomain();
+                             //TODO:: d->emitUpdated();
                          }
                      } else {
                          setRange(QString::null, QString::null);
                      setRange(d->m_minCategory, d->m_categories.last());
                  } else {
                      d->updateCategoryDomain();
+                     //TODO:: d->emitUpdated();
                  }
                  emit categoriesChanged();
                          setRange(newCategory, d->m_maxCategory);
                      } else if (d->m_maxCategory == oldCategory) {
                          setRange(d->m_minCategory, newCategory);
+                     } else {
+                         //TODO:: d->emitUpdated();
                      }
                      emit categoriesChanged();
                      emit countChanged();

0

src/axis/categoryaxis/chartcategoryaxisx.cpp +1 0

              void ChartCategoryAxisX::updateGeometry()
              {
+                 //TODO: this is not optimal when many categories :( , create only visible lables
                  setLabels(m_axis->categoriesLabels() << "");
                  HorizontalAxis::updateGeometry();
              }

0

src/axis/categoryaxis/qcategoryaxis.cpp +2 0

                              d->m_categoriesMap.insert(label, range);
                          }
                      }
+                     //TODO:: d->emitUpdated();
                  }
              }
                      Range range = d->m_categoriesMap.value(oldLabel);
                      d->m_categoriesMap.remove(oldLabel);
                      d->m_categoriesMap.insert(newLabel, range);
+                     //TODO:: d->emitUpdated();
                  }
              }

0

src/axis/qabstractaxis.cpp +5 0

                  return d_ptr->m_axisPen;
              }
+             //TODO: remove me 2.0
              void QAbstractAxis::setLinePenColor(QColor color)
              {
                  QPen p = d_ptr->m_axisPen;
              {
                  return d_ptr->m_labelsAngle;
              }
+             //TODO: remove me 2.0
              void QAbstractAxis::setLabelsColor(QColor color)
              {
                  QBrush b = d_ptr->m_labelsBrush;
              /*!
                Returns the orientation in which the axis is being used (Vertical or Horizontal)
              */
+             // NOTE: should have const but it breaks BC:
+             // http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Change_the_CV-qualifiers_of_a_member_function
              Qt::Orientation QAbstractAxis::orientation()
              {
                  return d_ptr->orientation();
                  bool axisX = m_orientation == Qt::Horizontal;
+                 //TODO: introduce axis brush
                  if (m_visible) {
                      if (m_arrowVisible) {
                          if (forced || pen == m_axisPen) {

0

src/axis/qabstractaxis.h +1 -1

                  void setShadesBorderColor(QColor color);
                  QColor shadesBorderColor() const;
-                 Qt::Orientation orientation();
+                 Qt::Orientation orientation(); //TODO: missing const <- BC (2.0)
                  Qt::Alignment alignment() const;
                  //range handling

0

src/axis/valueaxis/qvalueaxis.h +1 0

                  void setLabelFormat(const QString &format);
                  QString labelFormat() const;
+                 //TODO: deprecated! (2.0)
                  void setNiceNumbersEnabled(bool enable = true);
                  bool niceNumbersEnabled() const;

0

src/axis/valueaxis/qvalueaxis_p.h +1 -1

                  int m_tickCount;
                  QString m_format;
                  bool m_applying;
-                 bool m_niceNumbersEnabled;
+                 bool m_niceNumbersEnabled; //TODO: this deprecated (2.0)
                  Q_DECLARE_PUBLIC(QValueAxis)
              };

0

src/chartpresenter_p.h +1 0

                  void startAnimation(ChartAnimation *animation);
+                 //TODO refactor
                  void setState(State state,QPointF point);
                  State state() const { return m_state; }
                  QPointF statePoint() const { return m_statePoint; }

0

src/chartthememanager.cpp +3 0

                      qreal h = color.hsvHueF();
                      qreal s = color.hsvSaturationF();
+                     // TODO: tune the algorithm to give nice results with most base colors defined in
+                     // most themes. The rest of the gradients we can define manually in theme specific
+                     // implementation.
                      QColor start = color;
                      start.setHsvF(h, 0.0, 1.0);
                      g.setColorAt(0.0, start);

0

src/legend/qlegendmarker_p.h +1 0

              QTCOMMERCIALCHART_BEGIN_NAMESPACE
+             // TODO: check these
              class QAbstractSeries;
              class QAreaSeries;
              class QXYSeries;

0

src/qchart.cpp +9 0

                  return d_ptr->m_presenter->geometry();
              }
+             ///*!
+             //    TODO: Dummy.
+             //    Adjust the ranges of the axes so that all the data of the specified \a series is visible
+             // */
+             //void QChart::adjustViewToSeries(QAbstractSeries* series)
+             //{
+             //    //
+             //}
              /*!
               Sets animation \a options for the chart
               */

0

src/scatterchart/scatterchartitem.cpp +1 0

                  setOpacity(m_series->opacity());
                  if (recreate) {
+                     // TODO: optimize handleUpdate to recreate points only in case shape changed
                      deletePoints(count);
                      createPoints(count);

0

src/xychart/xychart.cpp +2 0

              QTCOMMERCIALCHART_BEGIN_NAMESPACE
+             //TODO: optimize : remove points which are not visible
              XYChart::XYChart(QXYSeries *series,QGraphicsItem* item):
                    ChartItem(series->d_func(),item),
                    m_series(series),

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages