HG_REPOSITORIES/LPP/INSTRUMENTATION/USERS/JEANDET/qtcharts Commit - r915:5580e2c7f492

Bugfix in barchartmodel max -> return 0if no count

Michal Klocek -

r915:5580e2c7f492

parent child

Context file:

r915:5580e2c7f492

src/barchart/barchartmodel.cpp +1 -2

             qreal BarChartModel::max() const
             {
-                Q_ASSERT(m_dataModel.count() > 0);
+                if (m_dataModel.count() == 0) return 0;
                 // TODO: make min and max members and update them when data changes.
                 // This is slower since they are checked every time, even if data is same since previous call.
                 qreal max = INT_MIN;

test/auto/qchart/tst_qchart.cpp +1 -2

                 m_view->show();
                 QTest::qWaitForWindowShown(m_view);
                 if(!axis) axis = m_chart->axisY();
-                //m_chart->addSeries(series,axis);
+                m_chart->addSeries(series,axis);
                 QCOMPARE(m_chart->axisY(series),axis);
             }
                 QFETCH(QChart::AnimationOption, animationOptions);
                 m_chart->setAnimationOptions(animationOptions);
                 QCOMPARE(m_chart->animationOptions(), animationOptions);
             }
             void tst_QChart::axisX_data()

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages