HG_REPOSITORIES/LPP/INSTRUMENTATION/USERS/JEANDET/qtcharts Commit - r1494:0e4d11fde6b8

Removed unnecessary signals from QPieSlice

Tero Ahola -

r1494:0e4d11fde6b8

parent child

Context file:

r1494:0e4d11fde6b8

Collapse all files

src/piechart/piechartitem.cpp +11 -5

             /****************************************************************************
             **
             ** Copyright (C) 2012 Digia Plc
             ** All rights reserved.
             ** For any questions to Digia, please use contact form at http://qt.digia.com
             **
             ** This file is part of the Qt Commercial Charts Add-on.
             **
             ** $QT_BEGIN_LICENSE$
             ** Licensees holding valid Qt Commercial licenses may use this file in
             ** accordance with the Qt Commercial License Agreement provided with the
             ** Software or, alternatively, in accordance with the terms contained in
             ** a written agreement between you and Digia.
             **
             ** If you have questions regarding the use of this file, please use
             ** contact form at http://qt.digia.com
             ** $QT_END_LICENSE$
             **
             ****************************************************************************/
             #include "piechartitem_p.h"
             #include "piesliceitem_p.h"
             #include "qpieslice.h"
             #include "qpieslice_p.h"
             #include "qpieseries.h"
             #include "qpieseries_p.h"
             #include "chartpresenter_p.h"
             #include "chartdataset_p.h"
             #include "chartanimator_p.h"
             #include <QPainter>
             #include <QTimer>
             QTCOMMERCIALCHART_BEGIN_NAMESPACE
             PieChartItem::PieChartItem(QPieSeries *series, ChartPresenter* presenter)
                 :ChartItem(presenter),
                 m_series(series)
             {
                 Q_ASSERT(series);
                 QPieSeriesPrivate *p = QPieSeriesPrivate::fromSeries(series);
                 connect(series, SIGNAL(visibleChanged()), this, SLOT(handleSeriesVisibleChanged()));
                 connect(series, SIGNAL(added(QList<QPieSlice*>)), this, SLOT(handleSlicesAdded(QList<QPieSlice*>)));
                 connect(series, SIGNAL(removed(QList<QPieSlice*>)), this, SLOT(handleSlicesRemoved(QList<QPieSlice*>)));
                 connect(p, SIGNAL(horizontalPositionChanged()), this, SLOT(updateLayout()));
                 connect(p, SIGNAL(verticalPositionChanged()), this, SLOT(updateLayout()));
                 connect(p, SIGNAL(pieSizeChanged()), this, SLOT(updateLayout()));
                 connect(p, SIGNAL(calculatedDataChanged()), this, SLOT(updateLayout()));
                 // Note: the following does not affect as long as the item does not have anything to paint
                 setZValue(ChartPresenter::PieSeriesZValue);
                 // Note: will not create slice items until we have a proper rectangle to draw on.
             }
             PieChartItem::~PieChartItem()
             {
                 // slices deleted automatically through QGraphicsItem
             }
             void PieChartItem::handleGeometryChanged(const QRectF& rect)
             {
                 prepareGeometryChange();
                 m_rect = rect;
                 updateLayout();
                 // This is for delayed initialization of the slice items during startup.
                 // It ensures that startup animation originates from the correct position.
                 if (m_sliceItems.isEmpty())
                     handleSlicesAdded(m_series->slices());
             }
             void PieChartItem::handleDomainChanged(qreal minX, qreal maxX, qreal minY, qreal maxY)
             {
                 Q_UNUSED(minX);
                 Q_UNUSED(maxX);
                 Q_UNUSED(minY);
                 Q_UNUSED(maxY);
                 // does not apply to pie
             }
             void PieChartItem::rangeXChanged(qreal min, qreal max, int tickXCount)
             {
                 Q_UNUSED(min);
                 Q_UNUSED(max);
                 Q_UNUSED(tickXCount);
                 // does not apply to pie
             }
             void PieChartItem::rangeYChanged(qreal min, qreal max, int tickYCount)
             {
                 Q_UNUSED(min);
                 Q_UNUSED(max);
                 Q_UNUSED(tickYCount);
                 // does not apply to pie
             }
             void PieChartItem::updateLayout()
             {
                 // find pie center coordinates
                 m_pieCenter.setX(m_rect.left() + (m_rect.width() * m_series->horizontalPosition()));
                 m_pieCenter.setY(m_rect.top() + (m_rect.height() * m_series->verticalPosition()));
                 // find maximum radius for pie
                 m_pieRadius = m_rect.height() / 2;
                 if (m_rect.width() < m_rect.height())
                     m_pieRadius = m_rect.width() / 2;
                 // apply size factor
                 m_pieRadius *= m_series->pieSize();
                 // set layouts for existing slice items
                 foreach (QPieSlice* slice, m_series->slices()) {
                     PieSliceItem *sliceItem = m_sliceItems.value(slice);
                     if (sliceItem) {
                         PieSliceData sliceData = updateSliceGeometry(slice);
                         if (animator())
                             animator()->updateAnimation(this, sliceItem, sliceData);
                         else
                             sliceItem->setLayout(sliceData);
                     }
                 }
                 update();
             }
             void PieChartItem::handleSlicesAdded(QList<QPieSlice*> slices)
             {
                 // delay creating slice items until there is a proper rectangle
                 if (!m_rect.isValid() && m_sliceItems.isEmpty())
                     return;
                 presenter()->chartTheme()->decorate(m_series, presenter()->dataSet()->seriesIndex(m_series));
                 bool startupAnimation = m_sliceItems.isEmpty();
                 foreach (QPieSlice *slice, slices) {
                     PieSliceItem* sliceItem = new PieSliceItem(this);
                     m_sliceItems.insert(slice, sliceItem);
-                    // Note: do need to connect to slice valueChanged() etc.
+                    // Note: no need to connect to slice valueChanged() etc.
                     // This is handled through calculatedDataChanged signal.
                     connect(slice, SIGNAL(labelChanged()), this, SLOT(handleSliceChanged()));
                     connect(slice, SIGNAL(labelVisibleChanged()), this, SLOT(handleSliceChanged()));
-                    connect(slice, SIGNAL(explodedChanged()), this, SLOT(handleSliceChanged()));
                     connect(slice, SIGNAL(penChanged()), this, SLOT(handleSliceChanged()));
                     connect(slice, SIGNAL(brushChanged()), this, SLOT(handleSliceChanged()));
                     connect(slice, SIGNAL(labelBrushChanged()), this, SLOT(handleSliceChanged()));
                     connect(slice, SIGNAL(labelFontChanged()), this, SLOT(handleSliceChanged()));
-                    connect(slice, SIGNAL(labelPositionChanged()), this, SLOT(handleSliceChanged()));
-                    connect(slice, SIGNAL(labelArmLengthFactorChanged()), this, SLOT(handleSliceChanged()));
+                    QPieSlicePrivate *p = QPieSlicePrivate::fromSlice(slice);
-                    connect(slice, SIGNAL(explodeDistanceFactorChanged()), this, SLOT(handleSliceChanged()));
+                    connect(p, SIGNAL(labelPositionChanged()), this, SLOT(handleSliceChanged()));
+                    connect(p, SIGNAL(explodedChanged()), this, SLOT(handleSliceChanged()));
+                    connect(p, SIGNAL(labelArmLengthFactorChanged()), this, SLOT(handleSliceChanged()));
+                    connect(p, SIGNAL(explodeDistanceFactorChanged()), this, SLOT(handleSliceChanged()));
                     connect(sliceItem, SIGNAL(clicked(Qt::MouseButtons)), slice, SIGNAL(clicked()));
                     connect(sliceItem, SIGNAL(hovered(bool)), slice, SIGNAL(hovered(bool)));
                     PieSliceData sliceData = updateSliceGeometry(slice);
                     if (animator())
                         animator()->addAnimation(this, sliceItem, sliceData, startupAnimation);
                     else
                         sliceItem->setLayout(sliceData);
                 }
             }
             void PieChartItem::handleSlicesRemoved(QList<QPieSlice*> slices)
             {
                 presenter()->chartTheme()->decorate(m_series, presenter()->dataSet()->seriesIndex(m_series));
                 foreach (QPieSlice *slice, slices) {
                     PieSliceItem *sliceItem = m_sliceItems.value(slice);
                     // this can happen if you call append() & remove() in a row so that PieSliceItem is not even created
                     if (!sliceItem)
                         continue;
                     m_sliceItems.remove(slice);
                     if (animator())
                         animator()->removeAnimation(this, sliceItem); // animator deletes the PieSliceItem
                     else
                         delete sliceItem;
                 }
             }
             void PieChartItem::handleSliceChanged()
             {
                 QPieSlice* slice = qobject_cast<QPieSlice *>(sender());
+                if (!slice) {
+                    QPieSlicePrivate* slicep = qobject_cast<QPieSlicePrivate *>(sender());
+                    slice = slicep->q_ptr;
+                }
                 Q_ASSERT(m_sliceItems.contains(slice));
                 PieSliceItem *sliceItem = m_sliceItems.value(slice);
                 PieSliceData sliceData = updateSliceGeometry(slice);
                 if (animator())
                     animator()->updateAnimation(this, sliceItem, sliceData);
                 else
                     sliceItem->setLayout(sliceData);
                 update();
             }
             void PieChartItem::handleSeriesVisibleChanged()
             {
                 setVisible(m_series->isVisible());
             }
             PieSliceData PieChartItem::updateSliceGeometry(QPieSlice *slice)
             {
                 PieSliceData &sliceData = QPieSlicePrivate::fromSlice(slice)->m_data;
                 sliceData.m_center = PieSliceItem::sliceCenter(m_pieCenter, m_pieRadius, slice);
                 sliceData.m_radius = m_pieRadius;
                 return sliceData;
             }
             #include "moc_piechartitem_p.cpp"
             QTCOMMERCIALCHART_END_NAMESPACE

src/piechart/qpieslice.cpp +4 -48

             /****************************************************************************
             **
             ** Copyright (C) 2012 Digia Plc
             ** All rights reserved.
             ** For any questions to Digia, please use contact form at http://qt.digia.com
             **
             ** This file is part of the Qt Commercial Charts Add-on.
             **
             ** $QT_BEGIN_LICENSE$
             ** Licensees holding valid Qt Commercial licenses may use this file in
             ** accordance with the Qt Commercial License Agreement provided with the
             ** Software or, alternatively, in accordance with the terms contained in
             ** a written agreement between you and Digia.
             **
             ** If you have questions regarding the use of this file, please use
             ** contact form at http://qt.digia.com
             ** $QT_END_LICENSE$
             **
             ****************************************************************************/
             #include "qpieslice.h"
             #include "qpieslice_p.h"
             QTCOMMERCIALCHART_BEGIN_NAMESPACE
             /*!
                 \class QPieSlice
                 \brief Defines a slice in pie series.
                 This object defines the properties of a single slice in a QPieSeries.
                 In addition to the obvious value and label properties the user can also control
                 the visual appearance of a slice. By modifying the visual appearance also means that
                 the user is overriding the default appearance set by the theme.
                 Note that if the user has customized slices and theme is changed all customizations will be lost.
                 To enable user interaction with the pie some basic signals are provided about clicking and hovering.
             */
             /*!
                 \qmlclass PieSlice QPieSlice
                 PieSlice defines the properties of a single slice in a PieSeries. The element should be used
                 as a child for a PieSeries. For example:
                 \snippet ../examples/qmlpiechart/qml/qmlpiechart/main.qml 2
                 An alternative (dynamic) method for adding slices to a PieSeries is using PieSeries.append
                 method.
                 \snippet ../examples/qmlpiechart/qml/qmlpiechart/main.qml 4
                 In that case you may want to use PieSeries.at or PieSeries.find to access the properties of
                 an individual PieSlice instance.
                 \snippet ../examples/qmlpiechart/qml/qmlpiechart/main.qml 5
                 \sa PieSeries
             */
             /*!
              \enum QPieSlice::LabelPosition
              This enum describes the position of the slice label.
              \value LabelOutside Label is outside the slice with an arm.
              \value LabelInside Label is centered inside the slice.
              */
             /*!
                 \property QPieSlice::label
                 Label of the slice.
                 \sa labelVisible, labelBrush, labelFont, labelArmLengthFactor
             */
             /*!
                 \qmlproperty string PieSlice::label
                 Label (text) of the slice.
             */
             /*!
                 \fn void QPieSlice::labelChanged()
                 This signal emitted when the slice label has been changed.
                 \sa label
             */
             /*!
                 \qmlsignal PieSlice::labelChanged()
                 This signal emitted when the slice label has been changed.
                 \sa label
             */
             /*!
                 \property QPieSlice::value
                 Value of the slice.
                 Note that if users sets a negative value it is converted to a positive value.
                 \sa percentage(), QPieSeries::sum()
             */
             /*!
                 \qmlproperty real PieSlice::value
                 Value of the slice. Note that if users sets a negative value it is converted to a positive value.
             */
             /*!
                 \fn void QPieSlice::valueChanged()
                 This signal is emitted when the slice value changes.
                 \sa value
             */
             /*!
                 \qmlsignal PieSlice::valueChanged()
                 This signal is emitted when the slice value changes.
                 \sa value
             */
             /*!
                 \property QPieSlice::labelVisible
                 Defines the visibility of slice label. By default the label is not visible.
                 \sa label, labelBrush, labelFont, labelArmLengthFactor
             */
             /*!
                 \qmlproperty bool PieSlice::labelVisible
                 Defines the visibility of slice label. By default the label is not visible.
             */
             /*!
                 \fn void QPieSlice::labelVisibleChanged()
                 This signal emitted when visibility of the slice label has changed.
                 \sa labelVisible
             */
             /*!
                 \qmlsignal PieSlice::labelVisibleChanged()
                 This signal emitted when visibility of the slice label has changed.
                 \sa labelVisible
             */
             /*!
                 \property QPieSlice::exploded
                 If set to true the slice is "exploded" away from the pie.
                 \sa explodeDistanceFactor
             */
             /*!
                 \qmlproperty bool PieSlice::exploded
                 If set to true the slice is "exploded" away from the pie.
                 \sa explodeDistanceFactor
             */
             /*!
-                \fn void QPieSlice::explodedChanged()
-                This signal is emitted the the slice has been exploded from the pie or is returned back to the pie.
-                \sa exploded
-            */
-            /*!
-                \qmlsignal PieSlice::explodedChanged()
-                This signal is emitted the the slice has been exploded from the pie or is returned back to the pie.
-                \sa exploded
-            */
-            /*!
                 \property QPieSlice::pen
                 Pen used to draw the slice border.
             */
             /*!
                 \fn void QPieSlice::penChanged()
                 This signal is emitted when the pen of the slice has changed.
                 \sa pen
             */
             /*!
                 \property QPieSlice::borderColor
                 Color used to draw the slice border.
                 This is a convenience property for modifying the slice pen.
                 \sa pen, borderWidth
             */
             /*!
                 \qmlproperty color PieSlice::borderColor
                 Color used to draw the slice border (pen color).
                 \sa borderWidth
             */
             /*!
                 \fn void QPieSlice::borderColorChanged()
                 This signal is emitted when slice border color changes.
                 \sa pen, borderColor
             */
             /*!
                 \qmlsignal PieSlice::borderColorChanged()
                 This signal is emitted when slice border color changes.
                 \sa borderColor
             */
             /*!
                 \property QPieSlice::borderWidth
                 Width of the slice border.
                 This is a convenience property for modifying the slice pen.
                 \sa pen, borderColor
             */
             /*!
                 \qmlproperty int PieSlice::borderWidth
                 Width of the slice border.
                 This is a convenience property for modifying the slice pen.
                 \sa borderColor
             */
             /*!
                 \fn void QPieSlice::borderWidthChanged()
                 This signal is emitted when slice border width changes.
                 \sa pen, borderWidth
             */
             /*!
                 \qmlsignal PieSlice::borderWidthChanged()
                 This signal is emitted when slice border width changes.
                 \sa borderWidth
             */
             /*!
                 \property QPieSlice::brush
                 Brush used to draw the slice.
             */
             /*!
                 \fn void QPieSlice::brushChanged()
                 This signal is emitted when the brush of the slice has changed.
                 \sa brush
             */
             /*!
                 \property QPieSlice::color
                 Fill (brush) color of the slice.
                 This is a convenience property for modifying the slice brush.
                 \sa brush
             */
             /*!
                 \qmlproperty color PieSlice::color
                 Fill (brush) color of the slice.
             */
             /*!
                 \fn void QPieSlice::colorChanged()
                 This signal is emitted when slice color changes.
                 \sa brush
             */
             /*!
                 \qmlsignal PieSlice::colorChanged()
                 This signal is emitted when slice color changes.
             */
             /*!
                 \property QPieSlice::labelBrush
                 Brush used to draw label and label arm of the slice.
                 \sa label, labelVisible, labelFont, labelArmLengthFactor
             */
             /*!
                 \fn void QPieSlice::labelBrushChanged()
                 This signal is emitted when the label pen of the slice has changed.
                 \sa labelBrush
             */
             /*!
                 \property QPieSlice::labelColor
                 Color used to draw the slice label.
                 This is a convenience property for modifying the slice label brush.
                 \sa labelBrush
             */
             /*!
                 \qmlproperty color PieSlice::labelColor
                 Color used to draw the slice label.
             */
             /*!
                 \fn void QPieSlice::labelColorChanged()
                 This signal is emitted when slice label color changes.
                 \sa labelColor
             */
             /*!
                 \qmlsignal PieSlice::labelColorChanged()
                 This signal is emitted when slice label color changes.
                 \sa labelColor
             */
             /*!
                 \property QPieSlice::labelFont
                 Font used for drawing label text.
                 \sa label, labelVisible, labelArmLengthFactor
             */
             /*!
                 \fn void QPieSlice::labelFontChanged()
                 This signal is emitted when the label font of the slice has changed.
                 \sa labelFont
             */
             /*!
                 \property QPieSlice::labelPosition
                 Position of the slice label.
                 \sa label, labelVisible
             */
             /*!
                 \qmlproperty LabelPosition PieSlice::labelPosition
                 Position of the slice label. One of PieSlice.LabelOutside or PieSlice.LabelInside.
                 \sa labelVisible
             */
             /*!
-                \fn void QPieSlice::labelPositionChanged()
-                This signal is emitted when the label position of the slice has changed.
-                \sa labelPosition
-            */
-            /*!
-                \qmlsignal PieSlice::labelPositionChanged()
-                This signal is emitted when the label position of the slice has changed.
-                \sa labelPosition
-            */
-            /*!
                 \property QPieSlice::labelArmLengthFactor
                 Defines the length of the label arm.
                 The factor is relative to pie radius. For example:
 .0 means the length is the same as the radius.
 .5 means the length is half of the radius.
                 By default the arm length is 0.15
                 \sa label, labelVisible, labelBrush, labelFont
             */
             /*!
                 \qmlproperty real PieSlice::labelArmLengthFactor
                 Defines the length of the label arm.
                 The factor is relative to pie radius. For example:
 .0 means the length is the same as the radius.
 .5 means the length is half of the radius.
                 By default the arm length is 0.15
                 \sa labelVisible
             */
             /*!
-                \fn void QPieSlice::labelArmLengthFactorChanged()
-                This signal is emitted when the label arm factor of the slice has changed.
-                \sa labelArmLengthFactor
-            */
-            /*!
-                \qmlsignal PieSlice::labelArmLengthFactorChanged()
-                This signal is emitted when the label arm factor of the slice has changed.
-                \sa labelArmLengthFactor
-            */
-            /*!
                 \property QPieSlice::explodeDistanceFactor
                 When the slice is exploded this factor defines how far the slice is exploded away from the pie.
                 The factor is relative to pie radius. For example:
 .0 means the distance is the same as the radius.
 .5 means the distance is half of the radius.
                 By default the distance is is 0.15
                 \sa exploded
             */
             /*!
                 \qmlproperty real PieSlice::explodeDistanceFactor
                 When the slice is exploded this factor defines how far the slice is exploded away from the pie.
                 The factor is relative to pie radius. For example:
 .0 means the distance is the same as the radius.
 .5 means the distance is half of the radius.
                 By default the distance is is 0.15
                 \sa exploded
             */
             /*!
-                \fn void QPieSlice::explodeDistanceFactorChanged()
-                This signal is emitted when the explode distance factor of the slice has changed.
-                \sa explodeDistanceFactor
-            */
-            /*!
-                \qmlsignal PieSlice::explodeDistanceFactorChanged()
-                This signal is emitted when the explode distance factor of the slice has changed.
-                \sa explodeDistanceFactor
-            */
-            /*!
                 \property QPieSlice::percentage
                 Percentage of the slice compared to the sum of all slices in the series.
                 The actual value ranges from 0.0 to 1.0.
                 Updated automatically once the slice is added to the series.
                 \sa value, QPieSeries::sum
             */
             /*!
                 \qmlproperty real PieSlice::percentage
                 Percentage of the slice compared to the sum of all slices in the series.
                 The actual value ranges from 0.0 to 1.0.
                 Updated automatically once the slice is added to the series.
             */
             /*!
                 \fn void QPieSlice::percentageChanged()
                 This signal is emitted when the percentage of the slice has changed.
                 \sa percentage
             */
             /*!
                 \qmlsignal void PieSlice::percentageChanged()
                 This signal is emitted when the percentage of the slice has changed.
                 \sa percentage
             */
             /*!
                 \property QPieSlice::startAngle
                 Defines the starting angle of this slice in the series it belongs to.
                 Full pie is 360 degrees where 0 degrees is at 12 a'clock.
                 Updated automatically once the slice is added to the series.
             */
             /*!
                 \qmlproperty real PieSlice::startAngle
                 Defines the starting angle of this slice in the series it belongs to.
                 Full pie is 360 degrees where 0 degrees is at 12 a'clock.
                 Updated automatically once the slice is added to the series.
             */
             /*!
                 \fn void QPieSlice::startAngleChanged()
                 This signal is emitted when the starting angle f the slice has changed.
                 \sa startAngle
             */
             /*!
                 \qmlsignal PieSlice::startAngleChanged()
                 This signal is emitted when the starting angle f the slice has changed.
                 \sa startAngle
             */
             /*!
                 \property QPieSlice::angleSpan
                 Span of the slice in degrees.
                 Full pie is 360 degrees where 0 degrees is at 12 a'clock.
                 Updated automatically once the slice is added to the series.
             */
             /*!
                 \qmlproperty real PieSlice::angleSpan
                 Span of the slice in degrees.
                 Full pie is 360 degrees where 0 degrees is at 12 a'clock.
                 Updated automatically once the slice is added to the series.
             */
             /*!
                 \fn void QPieSlice::angleSpanChanged()
                 This signal is emitted when the angle span of the slice has changed.
                 \sa angleSpan
             */
             /*!
                 \qmlsignal PieSlice::angleSpanChanged()
                 This signal is emitted when the angle span of the slice has changed.
                 \sa angleSpan
             */
             /*!
                 \fn void QPieSlice::clicked()
                 This signal is emitted when user has clicked the slice.
                 \sa QPieSeries::clicked()
             */
             /*!
                 \qmlsignal PieSlice::onClicked()
                 This signal is emitted when user has clicked the slice.
             */
             /*!
                 \fn void QPieSlice::hovered(bool state)
                 This signal is emitted when user has hovered over or away from the slice.
                 \a state is true when user has hovered over the slice and false when hover has moved away from the slice.
                 \sa QPieSeries::hovered()
             */
             /*!
                 \qmlsignal PieSlice::onHovered(bool state)
                 This signal is emitted when user has hovered over or away from the slice.
                 \a state is true when user has hovered over the slice and false when hover has moved away from the slice.
             */
             /*!
                 Constructs an empty slice with a \a parent.
                 \sa QPieSeries::append(), QPieSeries::insert()
             */
             QPieSlice::QPieSlice(QObject *parent)
                 :QObject(parent),
                 d_ptr(new QPieSlicePrivate(this))
             {
             }
             /*!
                 Constructs an empty slice with given \a value, \a label and a \a parent.
                 \sa QPieSeries::append(), QPieSeries::insert()
             */
             QPieSlice::QPieSlice(QString label, qreal value, QObject *parent)
                 :QObject(parent),
                 d_ptr(new QPieSlicePrivate(this))
             {
                 setValue(value);
                 setLabel(label);
             }
             /*!
                 Destroys the slice.
                 User should not delete the slice if it has been added to the series.
             */
             QPieSlice::~QPieSlice()
             {
             }
             void QPieSlice::setLabel(QString label)
             {
                 if (d_ptr->m_data.m_labelText != label) {
                     d_ptr->m_data.m_labelText = label;
                     emit labelChanged();
                 }
             }
             QString QPieSlice::label() const
             {
                 return d_ptr->m_data.m_labelText;
             }
             void QPieSlice::setValue(qreal value)
             {
                 value = qAbs(value); // negative values not allowed
                 if (!qFuzzyIsNull(d_ptr->m_data.m_value - value)) {
                     d_ptr->m_data.m_value = value;
                     emit valueChanged();
                 }
             }
             qreal QPieSlice::value() const
             {
                 return d_ptr->m_data.m_value;
             }
             void QPieSlice::setLabelVisible(bool visible)
             {
                 if (d_ptr->m_data.m_isLabelVisible != visible) {
                     d_ptr->m_data.m_isLabelVisible = visible;
                     emit labelVisibleChanged();
                 }
             }
             bool QPieSlice::isLabelVisible() const
             {
                 return d_ptr->m_data.m_isLabelVisible;
             }
             void QPieSlice::setExploded(bool exploded)
             {
                 if (d_ptr->m_data.m_isExploded != exploded) {
                     d_ptr->m_data.m_isExploded = exploded;
-                    emit explodedChanged();
+                    emit d_ptr->explodedChanged();
                 }
             }
             QPieSlice::LabelPosition QPieSlice::labelPosition()
             {
                 return d_ptr->m_data.m_labelPosition;
             }
             void QPieSlice::setLabelPosition(LabelPosition position)
             {
                 if (d_ptr->m_data.m_labelPosition != position) {
                     d_ptr->m_data.m_labelPosition = position;
-                    emit labelPositionChanged();
+                    emit d_ptr->labelPositionChanged();
                 }
             }
             bool QPieSlice::isExploded() const
             {
                 return d_ptr->m_data.m_isExploded;
             }
             void QPieSlice::setPen(const QPen &pen)
             {
                 d_ptr->setPen(pen, false);
             }
             QPen QPieSlice::pen() const
             {
                 return d_ptr->m_data.m_slicePen;
             }
             QColor QPieSlice::borderColor()
             {
                 return pen().color();
             }
             void QPieSlice::setBorderColor(QColor color)
             {
                 QPen p = pen();
                 if (color != p.color()) {
                     p.setColor(color);
                     setPen(p);
                 }
             }
             int QPieSlice::borderWidth()
             {
                 return pen().width();
             }
             void QPieSlice::setBorderWidth(int width)
             {
                 QPen p = pen();
                 if (width != p.width()) {
                     p.setWidth(width);
                     setPen(p);
                 }
             }
             void QPieSlice::setBrush(const QBrush &brush)
             {
                 d_ptr->setBrush(brush, false);
             }
             QBrush QPieSlice::brush() const
             {
                 return d_ptr->m_data.m_sliceBrush;
             }
             QColor QPieSlice::color()
             {
                 return brush().color();
             }
             void QPieSlice::setColor(QColor color)
             {
                 QBrush b = brush();
                 if (color != b.color()) {
                     b.setColor(color);
                     setBrush(b);
                 }
             }
             void QPieSlice::setLabelBrush(const QBrush &brush)
             {
                 d_ptr->setLabelBrush(brush, false);
             }
             QBrush QPieSlice::labelBrush() const
             {
                 return d_ptr->m_data.m_labelBrush;
             }
             QColor QPieSlice::labelColor()
             {
                 return labelBrush().color();
             }
             void QPieSlice::setLabelColor(QColor color)
             {
                 QBrush b = labelBrush();
                 if (color != b.color()) {
                     b.setColor(color);
                     setLabelBrush(b);
                 }
             }
             void QPieSlice::setLabelFont(const QFont &font)
             {
                 d_ptr->setLabelFont(font, false);
             }
             QFont QPieSlice::labelFont() const
             {
                 return d_ptr->m_data.m_labelFont;
             }
             void QPieSlice::setLabelArmLengthFactor(qreal factor)
             {
                 if (!qFuzzyIsNull(d_ptr->m_data.m_labelArmLengthFactor - factor)) {
                     d_ptr->m_data.m_labelArmLengthFactor = factor;
-                    emit labelArmLengthFactorChanged();
+                    emit d_ptr->labelArmLengthFactorChanged();
                 }
             }
             qreal QPieSlice::labelArmLengthFactor() const
             {
                 return d_ptr->m_data.m_labelArmLengthFactor;
             }
             void QPieSlice::setExplodeDistanceFactor(qreal factor)
             {
                 if (!qFuzzyIsNull(d_ptr->m_data.m_explodeDistanceFactor - factor)) {
                     d_ptr->m_data.m_explodeDistanceFactor = factor;
-                    emit explodeDistanceFactorChanged();
+                    emit d_ptr->explodeDistanceFactorChanged();
                 }
             }
             qreal QPieSlice::explodeDistanceFactor() const
             {
                 return d_ptr->m_data.m_explodeDistanceFactor;
             }
             qreal QPieSlice::percentage() const
             {
                 return d_ptr->m_data.m_percentage;
             }
             qreal QPieSlice::startAngle() const
             {
                 return d_ptr->m_data.m_startAngle;
             }
             qreal QPieSlice::angleSpan() const
             {
                 return d_ptr->m_data.m_angleSpan;
             }
             /*!
               Returns the series that this slice belongs to.
               \sa QPieSeries::append()
             */
             QPieSeries *QPieSlice::series() const
             {
                 return d_ptr->m_series;
             }
             QPieSlicePrivate::QPieSlicePrivate(QPieSlice *parent)
                 :QObject(parent),
                 q_ptr(parent),
                 m_series(0)
             {
             }
             QPieSlicePrivate::~QPieSlicePrivate()
             {
             }
             QPieSlicePrivate *QPieSlicePrivate::fromSlice(QPieSlice *slice)
             {
                 return slice->d_func();
             }
             void QPieSlicePrivate::setPen(const QPen &pen, bool themed)
             {
                 if (m_data.m_slicePen != pen) {
                     QPen oldPen = m_data.m_slicePen;
                     m_data.m_slicePen = pen;
                     m_data.m_slicePen.setThemed(themed);
                     emit q_ptr->penChanged();
                     if (oldPen.color() != pen.color())
                         emit q_ptr->borderColorChanged();
                     if (oldPen.width() != pen.width())
                         emit q_ptr->borderWidthChanged();
                 }
             }
             void QPieSlicePrivate::setBrush(const QBrush &brush, bool themed)
             {
                 if (m_data.m_sliceBrush != brush) {
                     QBrush oldBrush = m_data.m_sliceBrush;
                     m_data.m_sliceBrush = brush;
                     m_data.m_sliceBrush.setThemed(themed);
                     emit q_ptr->brushChanged();
                     if (oldBrush.color() != brush.color())
                         emit q_ptr->colorChanged();
                 }
             }
             void QPieSlicePrivate::setLabelBrush(const QBrush &brush, bool themed)
             {
                 if (m_data.m_labelBrush != brush) {
                     QBrush oldBrush = m_data.m_labelBrush;
                     m_data.m_labelBrush = brush;
                     m_data.m_labelBrush.setThemed(themed);
                     emit q_ptr->labelBrushChanged();
                     if (oldBrush.color() != brush.color())
                         emit q_ptr->labelColorChanged();
                 }
             }
             void QPieSlicePrivate::setLabelFont(const QFont &font, bool themed)
             {
                 if (m_data.m_labelFont != font) {
                     m_data.m_labelFont = font;
                     m_data.m_labelFont.setThemed(themed);
                     emit q_ptr->labelFontChanged();
                 }
             }
             void QPieSlicePrivate::setPercentage(qreal percentage)
             {
                 if (!qFuzzyIsNull(m_data.m_percentage - percentage)) {
                     m_data.m_percentage = percentage;
                     emit q_ptr->percentageChanged();
                 }
             }
             void QPieSlicePrivate::setStartAngle(qreal angle)
             {
                 if (!qFuzzyIsNull(m_data.m_startAngle - angle)) {
                     m_data.m_startAngle = angle;
                     emit q_ptr->startAngleChanged();
                 }
             }
             void QPieSlicePrivate::setAngleSpan(qreal span)
             {
                 if (!qFuzzyIsNull(m_data.m_angleSpan - span)) {
                     m_data.m_angleSpan = span;
                     emit q_ptr->angleSpanChanged();
                 }
             }
             QTCOMMERCIALCHART_END_NAMESPACE
             QTCOMMERCIALCHART_USE_NAMESPACE
             #include "moc_qpieslice.cpp"
             #include "moc_qpieslice_p.cpp"

src/piechart/qpieslice.h +6 -10

             /****************************************************************************
             **
             ** Copyright (C) 2012 Digia Plc
             ** All rights reserved.
             ** For any questions to Digia, please use contact form at http://qt.digia.com
             **
             ** This file is part of the Qt Commercial Charts Add-on.
             **
             ** $QT_BEGIN_LICENSE$
             ** Licensees holding valid Qt Commercial licenses may use this file in
             ** accordance with the Qt Commercial License Agreement provided with the
             ** Software or, alternatively, in accordance with the terms contained in
             ** a written agreement between you and Digia.
             **
             ** If you have questions regarding the use of this file, please use
             ** contact form at http://qt.digia.com
             ** $QT_END_LICENSE$
             **
             ****************************************************************************/
             #ifndef QPIESLICE_H
             #define QPIESLICE_H
             #include <qchartglobal.h>
             #include <QObject>
             #include <QPen>
             #include <QBrush>
             #include <QFont>
             QTCOMMERCIALCHART_BEGIN_NAMESPACE
             class QPieSlicePrivate;
             class QPieSeries;
             class QTCOMMERCIALCHART_EXPORT QPieSlice : public QObject
             {
                 Q_OBJECT
                 Q_ENUMS(LabelPosition)
                 Q_PROPERTY(QString label READ label WRITE setLabel NOTIFY labelChanged)
                 Q_PROPERTY(qreal value READ value WRITE setValue NOTIFY valueChanged)
                 Q_PROPERTY(bool labelVisible READ isLabelVisible WRITE setLabelVisible NOTIFY labelVisibleChanged)
-                Q_PROPERTY(LabelPosition labelPosition READ labelPosition WRITE setLabelPosition NOTIFY labelPositionChanged)
+                Q_PROPERTY(LabelPosition labelPosition READ labelPosition WRITE setLabelPosition)
-                Q_PROPERTY(bool exploded READ isExploded WRITE setExploded NOTIFY explodedChanged)
+                Q_PROPERTY(bool exploded READ isExploded WRITE setExploded)
                 Q_PROPERTY(QPen pen READ pen WRITE setPen NOTIFY penChanged)
                 Q_PROPERTY(QColor borderColor READ borderColor WRITE setBorderColor NOTIFY borderColorChanged)
                 Q_PROPERTY(int borderWidth READ borderWidth WRITE setBorderWidth NOTIFY borderWidthChanged)
                 Q_PROPERTY(QBrush brush READ brush WRITE setBrush NOTIFY brushChanged)
                 Q_PROPERTY(QColor color READ color WRITE setColor NOTIFY colorChanged)
                 Q_PROPERTY(QBrush labelBrush READ labelBrush WRITE setLabelBrush NOTIFY labelBrushChanged)
                 Q_PROPERTY(QColor labelColor READ labelColor WRITE setLabelColor NOTIFY labelColorChanged)
                 Q_PROPERTY(QFont labelFont READ labelFont WRITE setLabelFont NOTIFY labelFontChanged)
-                Q_PROPERTY(qreal labelArmLengthFactor READ labelArmLengthFactor WRITE setLabelArmLengthFactor NOTIFY labelArmLengthFactorChanged)
+                Q_PROPERTY(qreal labelArmLengthFactor READ labelArmLengthFactor WRITE setLabelArmLengthFactor)
-                Q_PROPERTY(qreal explodeDistanceFactor READ explodeDistanceFactor WRITE setExplodeDistanceFactor NOTIFY explodeDistanceFactorChanged)
+                Q_PROPERTY(qreal explodeDistanceFactor READ explodeDistanceFactor WRITE setExplodeDistanceFactor)
                 Q_PROPERTY(qreal percentage READ percentage NOTIFY percentageChanged)
                 Q_PROPERTY(qreal startAngle READ startAngle NOTIFY startAngleChanged)
                 Q_PROPERTY(qreal angleSpan READ angleSpan NOTIFY angleSpanChanged)
             public:
                 enum LabelPosition {
                     LabelOutside,
                     LabelInside
                 };
             public:
                 explicit QPieSlice(QObject *parent = 0);
                 QPieSlice(QString label, qreal value, QObject *parent = 0);
                 virtual ~QPieSlice();
                 void setLabel(QString label);
                 QString label() const;
                 void setValue(qreal value);
                 qreal value() const;
                 void setLabelVisible(bool visible = true);
                 bool isLabelVisible() const;
                 LabelPosition labelPosition();
                 void setLabelPosition(LabelPosition position);
                 void setExploded(bool exploded = true);
                 bool isExploded() const;
                 void setPen(const QPen &pen);
                 QPen pen() const;
                 QColor borderColor();
                 void setBorderColor(QColor color);
                 int borderWidth();
                 void setBorderWidth(int width);
                 void setBrush(const QBrush &brush);
                 QBrush brush() const;
                 QColor color();
                 void setColor(QColor color);
                 void setLabelBrush(const QBrush &brush);
                 QBrush labelBrush() const;
                 QColor labelColor();
                 void setLabelColor(QColor color);
                 void setLabelFont(const QFont &font);
                 QFont labelFont() const;
                 void setLabelArmLengthFactor(qreal factor);
                 qreal labelArmLengthFactor() const;
                 void setExplodeDistanceFactor(qreal factor);
                 qreal explodeDistanceFactor() const;
                 qreal percentage() const;
                 qreal startAngle() const;
                 qreal angleSpan() const;
                 QPieSeries *series() const;
             Q_SIGNALS:
+                void clicked();
+                void hovered(bool state);
                 void labelChanged();
                 void valueChanged();
                 void labelVisibleChanged();
-                void labelPositionChanged();
-                void explodedChanged();
                 void penChanged();
                 void brushChanged();
                 void labelBrushChanged();
                 void labelFontChanged();
-                void labelArmLengthFactorChanged();
-                void explodeDistanceFactorChanged();
                 void percentageChanged();
                 void startAngleChanged();
                 void angleSpanChanged();
                 void colorChanged();
                 void borderColorChanged();
                 void borderWidthChanged();
                 void labelColorChanged();
-                void clicked();
-                void hovered(bool state);
             private:
                 QPieSlicePrivate * const d_ptr;
                 Q_DECLARE_PRIVATE(QPieSlice)
                 Q_DISABLE_COPY(QPieSlice)
             };
             QTCOMMERCIALCHART_END_NAMESPACE
             #endif // QPIESLICE_H

src/piechart/qpieslice_p.h +6 0

             /****************************************************************************
             **
             ** Copyright (C) 2012 Digia Plc
             ** All rights reserved.
             ** For any questions to Digia, please use contact form at http://qt.digia.com
             **
             ** This file is part of the Qt Commercial Charts Add-on.
             **
             ** $QT_BEGIN_LICENSE$
             ** Licensees holding valid Qt Commercial licenses may use this file in
             ** accordance with the Qt Commercial License Agreement provided with the
             ** Software or, alternatively, in accordance with the terms contained in
             ** a written agreement between you and Digia.
             **
             ** If you have questions regarding the use of this file, please use
             ** contact form at http://qt.digia.com
             ** $QT_END_LICENSE$
             **
             ****************************************************************************/
             //  W A R N I N G
             //  -------------
             //
             // This file is not part of the QtCommercial Chart API.  It exists purely as an
             // implementation detail.  This header file may change from version to
             // version without notice, or even be removed.
             //
             // We mean it.
             #ifndef QPIESLICE_P_H
             #define QPIESLICE_P_H
             #include <QObject>
             #include "qpieslice.h"
             #include "pieslicedata_p.h"
             QTCOMMERCIALCHART_BEGIN_NAMESPACE
             class QPieSeries;
             class QPieSlicePrivate : public QObject
             {
                 Q_OBJECT
             public:
                 QPieSlicePrivate(QPieSlice *parent);
                 ~QPieSlicePrivate();
                 static QPieSlicePrivate* fromSlice(QPieSlice *slice);
                 void setPen(const QPen &pen, bool themed);
                 void setBrush(const QBrush &brush, bool themed);
                 void setLabelBrush(const QBrush &brush, bool themed);
                 void setLabelFont(const QFont &font, bool themed);
                 void setPercentage(qreal percentage);
                 void setStartAngle(qreal angle);
                 void setAngleSpan(qreal span);
+            Q_SIGNALS:
+                void labelPositionChanged();
+                void explodedChanged();
+                void labelArmLengthFactorChanged();
+                void explodeDistanceFactorChanged();
             private:
                 friend class QPieSeries;
                 friend class QPieSeriesPrivate;
                 friend class ChartTheme;
                 friend class PieChartItem;
                 QPieSlice * const q_ptr;
                 Q_DECLARE_PUBLIC(QPieSlice)
                 PieSliceData m_data;
                 QPieSeries *m_series;
             };
             QTCOMMERCIALCHART_END_NAMESPACE
             #endif // QPIESLICE_P_H

tests/auto/qpieslice/tst_qpieslice.cpp 0 -8

             /****************************************************************************
             **
             ** Copyright (C) 2012 Digia Plc
             ** All rights reserved.
             ** For any questions to Digia, please use contact form at http://qt.digia.com
             **
             ** This file is part of the Qt Commercial Charts Add-on.
             **
             ** $QT_BEGIN_LICENSE$
             ** Licensees holding valid Qt Commercial licenses may use this file in
             ** accordance with the Qt Commercial License Agreement provided with the
             ** Software or, alternatively, in accordance with the terms contained in
             ** a written agreement between you and Digia.
             **
             ** If you have questions regarding the use of this file, please use
             ** contact form at http://qt.digia.com
             ** $QT_END_LICENSE$
             **
             ****************************************************************************/
             #include <QtTest/QtTest>
             #include <tst_definitions.h>
             #include <qchartview.h>
             #include <qchart.h>
             #include <qpieslice.h>
             #include <qpieseries.h>
             QTCOMMERCIALCHART_USE_NAMESPACE
             class tst_qpieslice : public QObject
             {
                 Q_OBJECT
             public slots:
                 void initTestCase();
                 void cleanupTestCase();
                 void init();
                 void cleanup();
             private slots:
                 void construction();
                 void changedSignals();
                 void customize();
                 void mouseClick();
                 void mouseHover();
             private:
             private:
             };
             void tst_qpieslice::initTestCase()
             {
             }
             void tst_qpieslice::cleanupTestCase()
             {
             }
             void tst_qpieslice::init()
             {
             }
             void tst_qpieslice::cleanup()
             {
             }
             void tst_qpieslice::construction()
             {
                 // no params
                 QPieSlice slice1;
                 QCOMPARE(slice1.value(), 0.0);
                 QVERIFY(slice1.label().isEmpty());
                 QVERIFY(!slice1.isLabelVisible());
                 QVERIFY(!slice1.isExploded());
                 QCOMPARE(slice1.pen(), QPen());
                 QCOMPARE(slice1.brush(), QBrush());
                 QCOMPARE(slice1.labelBrush(), QBrush());
                 QCOMPARE(slice1.labelFont(), QFont());
                 QCOMPARE(slice1.labelArmLengthFactor(), 0.15); // default value
                 QCOMPARE(slice1.explodeDistanceFactor(), 0.15); // default value
                 QCOMPARE(slice1.percentage(), 0.0);
                 QCOMPARE(slice1.startAngle(), 0.0);
                 QCOMPARE(slice1.angleSpan(), 0.0);
                 // value and label params
                 QPieSlice slice2("foobar", 1.0);
                 QCOMPARE(slice2.value(), 1.0);
                 QCOMPARE(slice2.label(), QString("foobar"));
                 QVERIFY(!slice2.isLabelVisible());
                 QVERIFY(!slice2.isExploded());
                 QCOMPARE(slice2.pen(), QPen());
                 QCOMPARE(slice2.brush(), QBrush());
                 QCOMPARE(slice2.labelBrush(), QBrush());
                 QCOMPARE(slice2.labelFont(), QFont());
                 QCOMPARE(slice2.labelArmLengthFactor(), 0.15); // default value
                 QCOMPARE(slice2.explodeDistanceFactor(), 0.15); // default value
                 QCOMPARE(slice2.percentage(), 0.0);
                 QCOMPARE(slice2.startAngle(), 0.0);
                 QCOMPARE(slice2.angleSpan(), 0.0);
             }
             void tst_qpieslice::changedSignals()
             {
                 QPieSlice slice;
                 QSignalSpy valueSpy(&slice, SIGNAL(valueChanged()));
                 QSignalSpy labelSpy(&slice, SIGNAL(labelChanged()));
-                QSignalSpy explodedSpy(&slice, SIGNAL(explodedChanged()));
                 QSignalSpy penSpy(&slice, SIGNAL(penChanged()));
                 QSignalSpy brushSpy(&slice, SIGNAL(brushChanged()));
                 QSignalSpy labelBrushSpy(&slice, SIGNAL(labelBrushChanged()));
                 QSignalSpy labelFontSpy(&slice, SIGNAL(labelFontChanged()));
-                QSignalSpy labelPositionSpy(&slice, SIGNAL(labelPositionChanged()));
-                QSignalSpy labelArmLengthFactorSpy(&slice, SIGNAL(labelArmLengthFactorChanged()));
-                QSignalSpy explodeDistanceFactorSpy(&slice, SIGNAL(explodeDistanceFactorChanged()));
                 QSignalSpy colorSpy(&slice, SIGNAL(colorChanged()));
                 QSignalSpy borderColorSpy(&slice, SIGNAL(borderColorChanged()));
                 QSignalSpy borderWidthSpy(&slice, SIGNAL(borderWidthChanged()));
                 QSignalSpy labelColorSpy(&slice, SIGNAL(labelColorChanged()));
                 // percentageChanged(), startAngleChanged() and angleSpanChanged() signals tested at tst_qpieseries::calculatedValues()
                 // set everything twice to see we do not get unnecessary signals
                 slice.setValue(1.0);
                 slice.setValue(-1.0);
                 QCOMPARE(slice.value(), 1.0);
                 slice.setLabel("foobar");
                 slice.setLabel("foobar");
                 slice.setLabelVisible();
                 slice.setLabelVisible();
                 slice.setExploded();
                 slice.setExploded();
                 slice.setPen(QPen(Qt::red));
                 slice.setPen(QPen(QBrush(Qt::red), 3));
                 slice.setBrush(QBrush(Qt::red));
                 slice.setBrush(QBrush(Qt::red));
                 slice.setLabelBrush(QBrush(Qt::green));
                 slice.setLabelBrush(QBrush(Qt::green));
                 slice.setLabelFont(QFont("Tahoma"));
                 slice.setLabelFont(QFont("Tahoma"));
                 slice.setLabelPosition(QPieSlice::LabelInside);
                 slice.setLabelPosition(QPieSlice::LabelInside);
                 slice.setLabelArmLengthFactor(0.1);
                 slice.setLabelArmLengthFactor(0.1);
                 slice.setExplodeDistanceFactor(0.1);
                 slice.setExplodeDistanceFactor(0.1);
                 TRY_COMPARE(valueSpy.count(), 1);
                 TRY_COMPARE(labelSpy.count(), 1);
-                TRY_COMPARE(explodedSpy.count(), 1);
                 TRY_COMPARE(penSpy.count(), 2);
                 TRY_COMPARE(brushSpy.count(), 1);
                 TRY_COMPARE(labelBrushSpy.count(), 1);
                 TRY_COMPARE(labelFontSpy.count(), 1);
-                TRY_COMPARE(labelPositionSpy.count(), 1);
-                TRY_COMPARE(labelArmLengthFactorSpy.count(), 1);
-                TRY_COMPARE(explodeDistanceFactorSpy.count(), 1);
                 TRY_COMPARE(colorSpy.count(), 1);
                 TRY_COMPARE(borderColorSpy.count(), 1);
                 TRY_COMPARE(borderWidthSpy.count(), 1);
                 TRY_COMPARE(labelColorSpy.count(), 1);
             }
             void tst_qpieslice::customize()
             {
                 // create a pie series
                 QPieSeries *series = new QPieSeries();
                 QPieSlice *s1 = series->append("slice 1", 1);
                 QPieSlice *s2 = series->append("slice 2", 2);
                 series->append("slice 3", 3);
                 // customize a slice
                 QPen p1(Qt::red);
                 s1->setPen(p1);
                 QBrush b1(Qt::red);
                 s1->setBrush(b1);
                 s1->setLabelBrush(b1);
                 QFont f1("Consolas");
                 s1->setLabelFont(f1);
                 // add series to the chart
                 QChartView view(new QChart());
                 view.resize(200, 200);
                 view.chart()->addSeries(series);
                 view.show();
                 QTest::qWaitForWindowShown(&view);
                 //QTest::qWait(1000);
                 // check that customizations persist
                 QCOMPARE(s1->pen(), p1);
                 QCOMPARE(s1->brush(), b1);
                 QCOMPARE(s1->labelBrush(), b1);
                 QCOMPARE(s1->labelFont(), f1);
                 // remove a slice
                 series->remove(s2);
                 QCOMPARE(s1->pen(), p1);
                 QCOMPARE(s1->brush(), b1);
                 QCOMPARE(s1->labelBrush(), b1);
                 QCOMPARE(s1->labelFont(), f1);
                 // add a slice
                 series->append("slice 4", 4);
                 QCOMPARE(s1->pen(), p1);
                 QCOMPARE(s1->brush(), b1);
                 QCOMPARE(s1->labelBrush(), b1);
                 QCOMPARE(s1->labelFont(), f1);
                 // insert a slice
                 series->insert(0, new QPieSlice("slice 5", 5));
                 QCOMPARE(s1->pen(), p1);
                 QCOMPARE(s1->brush(), b1);
                 QCOMPARE(s1->labelBrush(), b1);
                 QCOMPARE(s1->labelFont(), f1);
                 // change theme
                 // theme will overwrite customizations
                 view.chart()->setTheme(QChart::ChartThemeHighContrast);
                 QVERIFY(s1->pen() != p1);
                 QVERIFY(s1->brush() != b1);
                 QVERIFY(s1->labelBrush() != b1);
                 QVERIFY(s1->labelFont() != f1);
             }
             void tst_qpieslice::mouseClick()
             {
                 // create a pie series
                 QPieSeries *series = new QPieSeries();
                 series->setPieSize(1.0);
                 QPieSlice *s1 = series->append("slice 1", 1);
                 QPieSlice *s2 = series->append("slice 2", 2);
                 QPieSlice *s3 = series->append("slice 3", 3);
                 QSignalSpy clickSpy1(s1, SIGNAL(clicked()));
                 QSignalSpy clickSpy2(s2, SIGNAL(clicked()));
                 QSignalSpy clickSpy3(s3, SIGNAL(clicked()));
                 // add series to the chart
                 QChartView view(new QChart());
                 view.chart()->legend()->setVisible(false);
                 view.resize(200, 200);
                 view.chart()->addSeries(series);
                 view.show();
                 QTest::qWaitForWindowShown(&view);
                 // simulate clicks
                 // pie rectangle: QRectF(60,60 121x121)
                 QTest::mouseClick(view.viewport(), Qt::LeftButton, 0,  QPoint(139, 85)); // inside slice 1
                 QTest::mouseClick(view.viewport(), Qt::LeftButton, 0,  QPoint(146, 136)); // inside slice 2
                 QTest::mouseClick(view.viewport(), Qt::LeftButton, 0,  QPoint(91, 119)); // inside slice 3
                 QTest::mouseClick(view.viewport(), Qt::LeftButton, 0,  QPoint(70, 70)); // inside pie rectangle but not inside a slice
                 QTest::mouseClick(view.viewport(), Qt::LeftButton, 0,  QPoint(170, 170)); // inside pie rectangle but not inside a slice
                 QCoreApplication::processEvents(QEventLoop::AllEvents, 1000);
                 QCOMPARE(clickSpy1.count(), 1);
                 QCOMPARE(clickSpy2.count(), 1);
                 QCOMPARE(clickSpy3.count(), 1);
             }
             void tst_qpieslice::mouseHover()
             {
                 // create a pie series
                 QPieSeries *series = new QPieSeries();
                 series->setPieSize(1.0);
                 QPieSlice *s1 = series->append("slice 1", 1);
                 series->append("slice 2", 2);
                 series->append("slice 3", 3);
                 // add series to the chart
                 QChartView view(new QChart());
                 view.chart()->legend()->setVisible(false);
                 view.resize(200, 200);
                 view.chart()->addSeries(series);
                 view.show();
                 QTest::qWaitForWindowShown(&view);
                 // first move to right top corner
                 QTest::mouseMove(view.viewport(), QPoint(200, 0));
                 QCoreApplication::processEvents(QEventLoop::AllEvents, 1000);
                 // move inside slice rectangle but NOT the actual slice
                 // pie rectangle: QRectF(60,60 121x121)
                 QSignalSpy hoverSpy(s1, SIGNAL(hovered(bool)));
                 QTest::mouseMove(view.viewport(), QPoint(170, 70));
                 TRY_COMPARE(hoverSpy.count(), 0);
                 // move inside the slice
                 QTest::mouseMove(view.viewport(), QPoint(139, 85));
                 TRY_COMPARE(hoverSpy.count(), 1);
                 QCOMPARE(qvariant_cast<bool>(hoverSpy.at(0).at(0)), true);
                 // move outside the slice
                 QTest::mouseMove(view.viewport(), QPoint(200, 0));
                 TRY_COMPARE(hoverSpy.count(), 2);
                 QCOMPARE(qvariant_cast<bool>(hoverSpy.at(1).at(0)), false);
             }
             QTEST_MAIN(tst_qpieslice)
             #include "tst_qpieslice.moc"

tests/qmlchartproperties/qml/qmlchartproperties/PieEditor.qml 0 -4

             /****************************************************************************
             **
             ** Copyright (C) 2012 Digia Plc
             ** All rights reserved.
             ** For any questions to Digia, please use contact form at http://qt.digia.com
             **
             ** This file is part of the Qt Commercial Charts Add-on.
             **
             ** $QT_BEGIN_LICENSE$
             ** Licensees holding valid Qt Commercial licenses may use this file in
             ** accordance with the Qt Commercial License Agreement provided with the
             ** Software or, alternatively, in accordance with the terms contained in
             ** a written agreement between you and Digia.
             **
             ** If you have questions regarding the use of this file, please use
             ** contact form at http://qt.digia.com
             ** $QT_END_LICENSE$
             **
             ****************************************************************************/
             import QtQuick 1.0
             import QtCommercial.Chart 1.0
             Flow {
                 id: flow
                 spacing: 5
                 flow: Flow.TopToBottom
                 property variant series
                 onSeriesChanged: {
                     if (series && series.name == "pie") {
                         seriesConnections.target = series;
                         sliceConnections.target = series.at(0);
                     } else {
                         seriesConnections.target = null;
                         sliceConnections.target = null;
                     }
                 }
                 Connections {
                     id: seriesConnections
                     target: null
                     onVisibleChanged:           console.log("series.onVisibleChanged: " + series.visible);
                     onCountChanged:             console.log("series.onCountChanged: " + series.count);
                     onSumChanged:               console.log("series.onSumChanged: " + series.sum);
                 }
                 Connections {
                     id: sliceConnections
                     target: null
                     onValueChanged:             console.log("slice.onValueChanged: " + series.at(0).value);
                     onLabelVisibleChanged:      console.log("slice.onLabelVisibleChanged: " + series.at(0).labelVisible);
-                    onLabelPositionChanged:     console.log("slice.onLabelPositionChanged: " + series.at(0).labelPosition);
-                    onExplodedChanged:          console.log("slice.onExplodedChanged: " + series.at(0).exploded);
                     onPenChanged:               console.log("slice.onPenChanged: " + series.at(0).pen);
                     onBorderColorChanged:       console.log("slice.onBorderColorChanged: " + series.at(0).borderColor);
                     onBorderWidthChanged:       console.log("slice.onBorderWidthChanged: " + series.at(0).borderWidth);
                     onBrushChanged:             console.log("slice.onBrushChanged: " + series.at(0).brush);
                     onColorChanged:             console.log("slice.onColorChanged: " + series.at(0).color);
                     onLabelColorChanged:        console.log("slice.onLabelColorChanged: " + series.at(0).labelColor);
                     onLabelBrushChanged:        console.log("slice.onLabelBrushChanged: " + series.at(0).labelBrush);
                     onLabelFontChanged:         console.log("slice.onLabelFontChanged: " + series.at(0).labelFont);
-                    onLabelArmLengthFactorChanged:  console.log("slice.onLabelArmLengthFactorChanged: " + series.at(0).labelArmLengthFactor);
-                    onExplodeDistanceFactorChanged: console.log("slice.onExplodeDistanceFactorChanged: " + series.at(0).explodeDistanceFactor);
                     onPercentageChanged:        console.log("slice.onPercentageChanged: " + series.at(0).percentage);
                     onStartAngleChanged:        console.log("slice.onStartAngleChanged: " + series.at(0).startAngle);
                     onAngleSpanChanged:         console.log("slice.onAngleSpanChanged: " + series.at(0).angleSpan);
                     onClicked:                  console.log("slice.onClicked");
                     onHovered:                  console.log("slice.onHovered: " + state);
                 }
                 Button {
                     text: "visible"
                     onClicked: series.visible = !series.visible;
                 }
                 Button {
                     text: "series hpos +"
                     onClicked: series.horizontalPosition += 0.1;
                 }
                 Button {
                     text: "series hpos -"
                     onClicked: series.horizontalPosition -= 0.1;
                 }
                 Button {
                     text: "series vpos +"
                     onClicked: series.verticalPosition += 0.1;
                 }
                 Button {
                     text: "series vpos -"
                     onClicked: series.verticalPosition -= 0.1;
                 }
                 Button {
                     text: "series size +"
                     onClicked: series.size += 0.1;
                 }
                 Button {
                     text: "series size -"
                     onClicked: series.size -= 0.1;
                 }
                 Button {
                     text: "series start angle +"
                     onClicked: series.startAngle += 1.1;
                 }
                 Button {
                     text: "series start angle -"
                     onClicked: series.startAngle -= 1.1;
                 }
                 Button {
                     text: "series end angle +"
                     onClicked: series.endAngle += 1.1;
                 }
                 Button {
                     text: "series end angle -"
                     onClicked: series.endAngle -= 1.1;
                 }
                 Button {
                     text: "slice color"
                     onClicked: series.at(0).color = main.nextColor();
                 }
                 Button {
                     text: "slice border color"
                     onClicked: series.at(0).borderColor = main.nextColor();
                 }
                 Button {
                     text: "slice border width +"
                     onClicked: series.at(0).borderWidth++;
                 }
                 Button {
                     text: "slice border width -"
                     onClicked: series.at(0).borderWidth--;
                 }
                 Button {
                     text: "slice label visible"
                     onClicked: series.at(0).labelVisible = !series.at(0).labelVisible;
                 }
                 Button {
                     text: "slice label position inside"
                     onClicked: series.at(0).labelPosition = PieSlice.LabelInside;
                 }
                 Button {
                     text: "slice label position outside"
                     onClicked: series.at(0).labelPosition = PieSlice.LabelOutside;
                 }
                 Button {
                     text: "slice label arm len +"
                     onClicked: series.at(0).labelArmLengthFactor += 0.1;
                 }
                 Button {
                     text: "slice label arm len -"
                     onClicked: series.at(0).labelArmLengthFactor -= 0.1;
                 }
                 Button {
                     text: "slice label color"
                     onClicked: series.at(0).labelColor = main.nextColor();
                 }
                 Button {
                     text: "slice exploded"
                     onClicked: series.at(0).exploded = !series.at(0).exploded;
                 }
                 Button {
                     text: "slice explode dist +"
                     onClicked: series.at(0).explodeDistanceFactor += 0.1;
                 }
                 Button {
                     text: "slice explode dist -"
                     onClicked: series.at(0).explodeDistanceFactor -= 0.1;
                 }
             }

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages