From b5f96ea8740c778c2005c4bfd93ffb7c05b07aa6 2012-09-07 12:43:36 From: Jani Honkonen Date: 2012-09-07 12:43:36 Subject: [PATCH] remove todo comments for release --- diff --git a/plugins/designer/qchartsplugin.cpp b/plugins/designer/qchartsplugin.cpp index 10767bf..f71e8e6 100644 --- a/plugins/designer/qchartsplugin.cpp +++ b/plugins/designer/qchartsplugin.cpp @@ -27,12 +27,12 @@ QTCOMMERCIALCHART_USE_NAMESPACE QChartsPlugin::QChartsPlugin(QObject *parent) : QObject(parent) { - // TODO Auto-generated constructor stub + } QChartsPlugin::~QChartsPlugin() { - // TODO Auto-generated destructor stub + } QString QChartsPlugin::name() const diff --git a/src/areachart/areachartitem.cpp b/src/areachart/areachartitem.cpp index 9b8783b..b678156 100644 --- a/src/areachart/areachartitem.cpp +++ b/src/areachart/areachartitem.cpp @@ -31,7 +31,6 @@ QTCOMMERCIALCHART_BEGIN_NAMESPACE -//TODO: optimize : remove points which are not visible AreaChartItem::AreaChartItem(QAreaSeries *areaSeries, ChartPresenter *presenter) : ChartItem(presenter), diff --git a/src/axis/chartaxis.cpp b/src/axis/chartaxis.cpp index cdf79be..fdbabcc 100644 --- a/src/axis/chartaxis.cpp +++ b/src/axis/chartaxis.cpp @@ -352,7 +352,7 @@ qreal ChartAxis::minimumHeight() void ChartAxis::axisSelected() { - qDebug()<<"TODO: axis clicked"; + } diff --git a/src/axis/datetimeaxis/chartdatetimeaxisx.cpp b/src/axis/datetimeaxis/chartdatetimeaxisx.cpp index a732951..4cbab64 100644 --- a/src/axis/datetimeaxis/chartdatetimeaxisx.cpp +++ b/src/axis/datetimeaxis/chartdatetimeaxisx.cpp @@ -127,7 +127,6 @@ void ChartDateTimeAxisX::updateGeometry() void ChartDateTimeAxisX::handleAxisUpdated() { - //TODO:: fix this QDateTimeAxis* axis = qobject_cast(m_chartAxis); m_tickCount = axis->tickCount(); ChartAxis::handleAxisUpdated(); diff --git a/src/axis/datetimeaxis/chartdatetimeaxisy.cpp b/src/axis/datetimeaxis/chartdatetimeaxisy.cpp index 07fc0dd..eabd458 100644 --- a/src/axis/datetimeaxis/chartdatetimeaxisy.cpp +++ b/src/axis/datetimeaxis/chartdatetimeaxisy.cpp @@ -132,7 +132,6 @@ void ChartDateTimeAxisY::updateGeometry() void ChartDateTimeAxisY::handleAxisUpdated() { - //TODO:: fix this QDateTimeAxis* axis = qobject_cast(m_chartAxis); m_tickCount = axis->tickCount(); ChartAxis::handleAxisUpdated(); diff --git a/src/axis/datetimeaxis/qdatetimeaxis_p.h b/src/axis/datetimeaxis/qdatetimeaxis_p.h index 491c580..27034a2 100644 --- a/src/axis/datetimeaxis/qdatetimeaxis_p.h +++ b/src/axis/datetimeaxis/qdatetimeaxis_p.h @@ -49,7 +49,7 @@ class QDateTimeAxisPrivate : public QAbstractAxisPrivate void handleDomainUpdated(); qreal min(){ return m_min.toMSecsSinceEpoch(); } qreal max(){ return m_max.toMSecsSinceEpoch(); } - int count() const { /*TODO:*/ return 0;} + int count() const { return 0;} protected: void setMin(const QVariant &min); diff --git a/src/axis/valueaxis/chartvalueaxisx.cpp b/src/axis/valueaxis/chartvalueaxisx.cpp index c7ebe96..6a9a0f9 100644 --- a/src/axis/valueaxis/chartvalueaxisx.cpp +++ b/src/axis/valueaxis/chartvalueaxisx.cpp @@ -112,7 +112,6 @@ void ChartValueAxisX::updateGeometry() void ChartValueAxisX::handleAxisUpdated() { - //TODO:: fix this QValueAxis* axis = qobject_cast(m_chartAxis); m_tickCount = axis->tickCount(); ChartAxis::handleAxisUpdated(); diff --git a/src/axis/valueaxis/chartvalueaxisy.cpp b/src/axis/valueaxis/chartvalueaxisy.cpp index ea50eb3..811c354 100644 --- a/src/axis/valueaxis/chartvalueaxisy.cpp +++ b/src/axis/valueaxis/chartvalueaxisy.cpp @@ -117,7 +117,6 @@ void ChartValueAxisY::updateGeometry() void ChartValueAxisY::handleAxisUpdated() { - //TODO:: fix this QValueAxis* axis = qobject_cast(m_chartAxis); m_tickCount = axis->tickCount(); ChartAxis::handleAxisUpdated(); diff --git a/src/chartdataset.cpp b/src/chartdataset.cpp index 2b4e227..8325849 100644 --- a/src/chartdataset.cpp +++ b/src/chartdataset.cpp @@ -155,7 +155,6 @@ void ChartDataSet::createAxes(QAbstractAxis::AxisTypes type, Qt::Orientation ori { QMapIterator i(m_seriesDomainMap); - // TODO: Add a descriptive comment of what happens here if (type.testFlag(QAbstractAxis::AxisTypeValue) && type.testFlag(QAbstractAxis::AxisTypeBarCategory)) { while (i.hasNext()) { i.next(); diff --git a/src/chartlayout.cpp b/src/chartlayout.cpp index 98a30ab..2036dfc 100644 --- a/src/chartlayout.cpp +++ b/src/chartlayout.cpp @@ -81,7 +81,6 @@ void ChartLayout::setGeometry(const QRectF& rect) QMargins chartMargins = m_chartMargins; - //TODO multiple axis handling; chartMargins.setLeft(qMax(m_chartMargins.left(),int(axisWidth + 2*m_marginTiny))); chartMargins.setBottom(qMax(m_chartMargins.bottom(),int(axisHeight + 2* m_marginTiny))); diff --git a/src/chartpresenter_p.h b/src/chartpresenter_p.h index 7a78cfd..2788b4d 100644 --- a/src/chartpresenter_p.h +++ b/src/chartpresenter_p.h @@ -31,7 +31,7 @@ #define CHARTPRESENTER_H #include "qchartglobal.h" -#include "qchart.h" //becouse of QChart::ChartThemeId //TODO +#include "qchart.h" #include #include diff --git a/src/charttheme.cpp b/src/charttheme.cpp index a655d6d..6f24543 100644 --- a/src/charttheme.cpp +++ b/src/charttheme.cpp @@ -316,9 +316,6 @@ void ChartTheme::generateSeriesGradients() qreal h = color.hsvHueF(); qreal s = color.hsvSaturationF(); - // TODO: tune the algorithm to give nice results with most base colors defined in - // most themes. The rest of the gradients we can define manually in theme specific - // implementation. QColor start = color; start.setHsvF(h, 0.0, 1.0); g.setColorAt(0.0, start); diff --git a/src/legend/legendmarker.cpp b/src/legend/legendmarker.cpp index e6c370f..8aa3542 100644 --- a/src/legend/legendmarker.cpp +++ b/src/legend/legendmarker.cpp @@ -154,7 +154,7 @@ QSizeF LegendMarker::sizeHint(Qt::SizeHint which, const QSizeF& constraint) cons void LegendMarker::mousePressEvent(QGraphicsSceneMouseEvent *event) { QGraphicsObject::mousePressEvent(event); - qDebug()<<"Not implemented"; //TODO: selected signal removed for now + qDebug()<<"Not implemented"; } ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// diff --git a/src/legend/qlegend.cpp b/src/legend/qlegend.cpp index a4e3b1b..b18b261 100644 --- a/src/legend/qlegend.cpp +++ b/src/legend/qlegend.cpp @@ -502,8 +502,6 @@ void QLegendPrivate::handleSeriesRemoved(QAbstractSeries *series) void QLegendPrivate::handleSeriesUpdated(QAbstractSeries *series) { - // TODO: find out which markers are are added or removed. Update them - // TODO: better implementation handleSeriesRemoved(series); Domain domain; handleSeriesAdded(series, &domain); @@ -511,7 +509,6 @@ void QLegendPrivate::handleSeriesUpdated(QAbstractSeries *series) void QLegendPrivate::handleUpdatePieSeries() { - //TODO: reimplement to be optimal QPieSeries* series = qobject_cast (sender()); Q_ASSERT(series); handleSeriesRemoved(series); diff --git a/src/legend/qlegend_p.h b/src/legend/qlegend_p.h index 24eb9fe..f1b67a7 100644 --- a/src/legend/qlegend_p.h +++ b/src/legend/qlegend_p.h @@ -59,7 +59,7 @@ public Q_SLOTS: void handleSeriesAdded(QAbstractSeries *series, Domain *domain); void handleSeriesRemoved(QAbstractSeries *series); void handleSeriesUpdated(QAbstractSeries *series); - void handleUpdatePieSeries(); //TODO remove this function + void handleUpdatePieSeries(); void handleSeriesVisibleChanged(); private: diff --git a/src/qabstractseries.cpp b/src/qabstractseries.cpp index d26fb8f..005fa0b 100644 --- a/src/qabstractseries.cpp +++ b/src/qabstractseries.cpp @@ -162,11 +162,6 @@ QChart* QAbstractSeries::chart() const return d_ptr->m_chart; } -//void QAbstractSeries::adjustView() -//{ -// //TODO: -//} - /*! \brief Sets the visibility of the series to true diff --git a/src/qchart.cpp b/src/qchart.cpp index f9f971f..36be915 100644 --- a/src/qchart.cpp +++ b/src/qchart.cpp @@ -390,15 +390,6 @@ QRectF QChart::plotArea() const return d_ptr->m_presenter->geometry(); } -///*! -// TODO: Dummy. -// Adjest the ranges of the axes so that all the data of the specified \a series is visible -// */ -//void QChart::adjustViewToSeries(QAbstractSeries* series) -//{ -// // -//} - /*! Sets animation \a options for the chart */ diff --git a/src/scatterchart/scatterchartitem.cpp b/src/scatterchart/scatterchartitem.cpp index b2535be..809f8e9 100644 --- a/src/scatterchart/scatterchartitem.cpp +++ b/src/scatterchart/scatterchartitem.cpp @@ -176,7 +176,6 @@ void ScatterChartItem::handleUpdated() m_shape = m_series->markerShape(); if(recreate) { - // TODO: optimize handleUpdate to recreate points only in case shape changed deletePoints(count); createPoints(count); diff --git a/src/xychart/xychart.cpp b/src/xychart/xychart.cpp index e97a360..b3ed1f5 100644 --- a/src/xychart/xychart.cpp +++ b/src/xychart/xychart.cpp @@ -30,8 +30,6 @@ QTCOMMERCIALCHART_BEGIN_NAMESPACE -//TODO: optimize : remove points which are not visible - XYChart::XYChart(QXYSeries *series, ChartPresenter *presenter):ChartElement(presenter), m_minX(0), m_maxX(0),