From 6223c1214e9dd8082c086fc382a5d4d866e7c2d0 2012-05-21 07:16:30 From: Jani Honkonen Date: 2012-05-21 07:16:30 Subject: [PATCH] Remove scaledomain ect. warnings from pie. Not going to be implemented (for now at least). --- diff --git a/src/piechart/piechartitem.cpp b/src/piechart/piechartitem.cpp index a25ffc1..b054007 100644 --- a/src/piechart/piechartitem.cpp +++ b/src/piechart/piechartitem.cpp @@ -61,6 +61,31 @@ void PieChartItem::handleGeometryChanged(const QRectF& rect) updateLayout(); } +void PieChartItem::handleDomainChanged(qreal minX, qreal maxX, qreal minY, qreal maxY) +{ + Q_UNUSED(minX); + Q_UNUSED(maxX); + Q_UNUSED(minY); + Q_UNUSED(maxY); + // does not apply to pie +} + +void PieChartItem::rangeXChanged(qreal min, qreal max, int tickXCount) +{ + Q_UNUSED(min); + Q_UNUSED(max); + Q_UNUSED(tickXCount); + // does not apply to pie +} + +void PieChartItem::rangeYChanged(qreal min, qreal max, int tickYCount) +{ + Q_UNUSED(min); + Q_UNUSED(max); + Q_UNUSED(tickYCount); + // does not apply to pie +} + void PieChartItem::initialize() { handleSlicesAdded(m_series->slices()); diff --git a/src/piechart/piechartitem_p.h b/src/piechart/piechartitem_p.h index 0b9cd58..d00b94a 100644 --- a/src/piechart/piechartitem_p.h +++ b/src/piechart/piechartitem_p.h @@ -45,10 +45,9 @@ public: public Q_SLOTS: // from Chart virtual void handleGeometryChanged(const QRectF &rect); - // TODO: Do we have actual need for these at all? What is the use case for pie? - //virtual void handleDomainChanged(qreal minX, qreal maxX, qreal minY, qreal maxY); - //virtual void rangeXChanged(qreal min, qreal max, int tickXCount); - //virtual void rangeYChanged(qreal min, qreal max, int tickYCount); + virtual void handleDomainChanged(qreal minX, qreal maxX, qreal minY, qreal maxY); + virtual void rangeXChanged(qreal min, qreal max, int tickXCount); + virtual void rangeYChanged(qreal min, qreal max, int tickYCount); void initialize(); void updateLayout(); diff --git a/src/piechart/qpieseries.cpp b/src/piechart/qpieseries.cpp index 076a2ae..0ce2106 100644 --- a/src/piechart/qpieseries.cpp +++ b/src/piechart/qpieseries.cpp @@ -782,9 +782,7 @@ bool QPieSeriesPrivate::setRealValue(qreal &value, qreal newValue, qreal max, qr void QPieSeriesPrivate::scaleDomain(Domain& domain) { Q_UNUSED(domain); -#ifndef QT_NO_DEBUG - qWarning() << __FILE__<<__FUNCTION__<<"not implemented"; -#endif + // does not apply to pie } Chart* QPieSeriesPrivate::createGraphics(ChartPresenter* presenter)