HG_REPOSITORIES/LPP/INSTRUMENTATION/USERS/JEANDET/qtcharts Files · src/chartitem.cpp

Fix crash when removing pie series from chart...

Fix crash when removing pie series from chart Connections cleanup in PieChartItem destructor didn't account for the possibility of series already having been destroyed. Changed m_series to QPointer so that it'll notice when series gets destroyed, and also added cleaning of slices to series destructor. Task-number: QTRD-1946 Change-Id: I651347bfcfbe7cd78dd26220a811fea5c8071fce Reviewed-by: Mika Salmela Reviewed-by: Mika Salmela <mika.salmela@digia.com>

Miikka Heikkinen - - Load All Authors

File last commit:

r2432:53927f716a3d


                r2475:9e35a3a169ed

Download file

             chartitem.cpp
        
                    47 lines
            
             | 1.3 KiB
            
                | text/x-c
            
             |
                CppLexer
            
             / src / chartitem.cpp
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Michal Klocek
    
Refactors internals...

              r2273
            
      /****************************************************************************

      **

        Miikka Heikkinen
    
Fixed the copyright year 2012 -> 2013

              r2432
            
      ** Copyright (C) 2013 Digia Plc

        Michal Klocek
    
Refactors internals...

              r2273
            
      ** All rights reserved.

      ** For any questions to Digia, please use contact form at http://qt.digia.com

      **

      ** This file is part of the Qt Commercial Charts Add-on.

      **

      ** $QT_BEGIN_LICENSE$

      ** Licensees holding valid Qt Commercial licenses may use this file in

      ** accordance with the Qt Commercial License Agreement provided with the

      ** Software or, alternatively, in accordance with the terms contained in

      ** a written agreement between you and Digia.

      **

      ** If you have questions regarding the use of this file, please use

      ** contact form at http://qt.digia.com

      ** $QT_END_LICENSE$

      **

      ****************************************************************************/

      #include "chartitem_p.h"

      #include "qabstractseries_p.h"

        Marek Rosa
    
Domains added

              r2275
            
      #include "abstractdomain_p.h"

        Michal Klocek
    
Refactors internals...

              r2273
            
      QTCOMMERCIALCHART_BEGIN_NAMESPACE

      ChartItem::ChartItem(QAbstractSeriesPrivate *series,QGraphicsItem* item):

            ChartElement(item),

        Marek Rosa
    
Negative values with log axis handled

              r2356
            
            m_validData(true),

        Michal Klocek
    
Refactors internals...

              r2273
            
            m_series(series)

      {

      }

        Michal Klocek
    
Domain not sharable again

              r2285
            
      AbstractDomain* ChartItem::domain() const

        Michal Klocek
    
Refactors internals...

              r2273
            
      {

          return m_series->domain();

      }

      void ChartItem::handleDomainUpdated()

      {

          qWarning() <<  __FUNCTION__<< "Slot not implemented";

      }

      #include "moc_chartitem_p.cpp"

      QTCOMMERCIALCHART_END_NAMESPACE

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Michal Klocek Refactors internals...	r2273	/****************************************************************************
		**
Miikka Heikkinen Fixed the copyright year 2012 -> 2013	r2432	** Copyright (C) 2013 Digia Plc
Michal Klocek Refactors internals...	r2273	** All rights reserved.
		** For any questions to Digia, please use contact form at http://qt.digia.com
		**
		** This file is part of the Qt Commercial Charts Add-on.
		**
		** $QT_BEGIN_LICENSE$
		** Licensees holding valid Qt Commercial licenses may use this file in
		** accordance with the Qt Commercial License Agreement provided with the
		** Software or, alternatively, in accordance with the terms contained in
		** a written agreement between you and Digia.
		**
		** If you have questions regarding the use of this file, please use
		** contact form at http://qt.digia.com
		** $QT_END_LICENSE$
		**
		****************************************************************************/

		#include "chartitem_p.h"
		#include "qabstractseries_p.h"
Marek Rosa Domains added	r2275	#include "abstractdomain_p.h"
Michal Klocek Refactors internals...	r2273
		QTCOMMERCIALCHART_BEGIN_NAMESPACE

		ChartItem::ChartItem(QAbstractSeriesPrivate series,QGraphicsItem item):
		ChartElement(item),
Marek Rosa Negative values with log axis handled	r2356	m_validData(true),
Michal Klocek Refactors internals...	r2273	m_series(series)
		{

		}

Michal Klocek Domain not sharable again	r2285	AbstractDomain* ChartItem::domain() const
Michal Klocek Refactors internals...	r2273	{
		return m_series->domain();
		}

		void ChartItem::handleDomainUpdated()
		{
		qWarning() << __FUNCTION__<< "Slot not implemented";
		}

		#include "moc_chartitem_p.cpp"

		QTCOMMERCIALCHART_END_NAMESPACE