HG_REPOSITORIES/LPP/INSTRUMENTATION/USERS/JEANDET/qtcharts Files · src/barchart/stackedbarchartitem.cpp

minor code review fixes, part n

sauimone - - Load All Authors

File last commit:

r763:4467255a8e44


                r763:4467255a8e44

Download file

             stackedbarchartitem.cpp
        
                    83 lines
            
             | 2.6 KiB
            
                | text/x-c
            
             |
                CppLexer
            
             / src / barchart / stackedbarchartitem.cpp
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        sauimone
    
combined barpresenterbase and barpresenter. renamed barchartpresenters to barchartitems

              r666
            
      #include "stackedbarchartitem_p.h"

        sauimone
    
renamed bar.h to bar_p.h

              r118
            
      #include "bar_p.h"

        sauimone
    
Floating values to bar charts

              r263
            
      #include "barvalue_p.h"

        sauimone
    
Added pen & brush to QBarSet

              r214
            
      #include "qbarset.h"

        sauimone
    
added missing example files :)

              r96
            
      #include <QDebug>

      QTCOMMERCIALCHART_BEGIN_NAMESPACE

        Michal Klocek
    
Refactors chartitem...

              r677
            
      StackedBarChartItem::StackedBarChartItem(QBarSeries *series, ChartPresenter *presenter) :

        Tero Ahola
    
Code review: Fixed simple issues in Bar and Legend

              r737
            
          BarChartItem(series, presenter)

        sauimone
    
added missing example files :)

              r96
            
      {

      }

        sauimone
    
combined barpresenterbase and barpresenter. renamed barchartpresenters to barchartitems

              r666
            
      StackedBarChartItem::~StackedBarChartItem()

        sauimone
    
updating drilldown example. Needs some more thinking

              r438
            
      {

      }

        sauimone
    
animations to stacked and percent barchart

              r694
            
      QVector<QRectF> StackedBarChartItem::calculateLayout()

        sauimone
    
added missing example files :)

              r96
            
      {

        sauimone
    
animations to stacked and percent barchart

              r694
            
          QVector<QRectF> layout;

        sauimone
    
Fixed layout for barcharts

              r473
            
          // Use temporary qreals for accurancy (we might get some compiler warnings... :)

        Michal Klocek
    
Refactors barchart axis hadnling...

              r679
            
        sauimone
    
minor code review fixes, part n

              r763
            
          qreal maxSum = m_series->maxCategorySum();

        sauimone
    
barchart domain fix

              r674
            
          // Domain:

        sauimone
    
minor code review fixes, part n

              r763
            
          if (m_domainMaxY > maxSum) {

              maxSum = m_domainMaxY;

        sauimone
    
barchart domain fix

              r674
            
          }

        Michal Klocek
    
Refactors barchart axis hadnling...

              r679
            
          qreal height = geometry().height();

          qreal width = geometry().width();

        sauimone
    
minor code review fixes, part n

              r763
            
          qreal scale = (height /  m_series->maxCategorySum());

          qreal categotyCount = m_series->categoryCount();

        Tero Ahola
    
Code review: Fixed simple issues in Bar and Legend

              r737
            
          qreal barWidth = width / (categotyCount * 2);

          qreal xStep = width / categotyCount;

          qreal xPos = xStep / 2 - barWidth / 2;

        Michal Klocek
    
Refactors barchart axis hadnling...

              r679
            
        sauimone
    
Fixed layout for barcharts

              r473
            
          int itemIndex(0);

        Michal Klocek
    
Refactors barchart axis hadnling...

              r679
            
          for (int category = 0; category < categotyCount; category++) {

              qreal yPos = height;

        sauimone
    
minor code review fixes, part n

              r763
            
              for (int set=0; set < m_series->barsetCount(); set++) {

                  qreal barHeight = m_series->valueAt(set, category) * scale;

                  Bar* bar = m_bars.at(itemIndex);

                  bar->setPen(m_series->barsetAt(set)->pen());

                  bar->setBrush(m_series->barsetAt(set)->brush());

        Tero Ahola
    
Code review: Fixed simple issues in Bar and Legend

              r737
            
                  QRectF rect(xPos, yPos-barHeight, barWidth, barHeight);

        sauimone
    
animations to stacked and percent barchart

              r694
            
                  layout.append(rect);

        sauimone
    
added missing example files :)

              r96
            
                  itemIndex++;

        sauimone
    
Some fixes to bar charts. Now bars draw almost correctly

              r97
            
                  yPos -= barHeight;

        sauimone
    
added missing example files :)

              r96
            
              }

        sauimone
    
fixing layout bug on stacked bar chart

              r98
            
              xPos += xStep;

        sauimone
    
added missing example files :)

              r96
            
          }

        sauimone
    
cleanup on barseries. removed old commented out separator code

              r654
            
        sauimone
    
Floating values to bar charts

              r263
            
          // Position floating values

          itemIndex = 0;

        Michal Klocek
    
Refactors barchart axis hadnling...

              r679
            
          xPos = (width/categotyCount);

        sauimone
    
minor code review fixes, part n

              r763
            
          for (int category=0; category < m_series->categoryCount(); category++) {

        Michal Klocek
    
Refactors barchart axis hadnling...

              r679
            
              qreal yPos = height;

        sauimone
    
minor code review fixes, part n

              r763
            
              for (int set=0; set < m_series->barsetCount(); set++) {

                  qreal barHeight = m_series->valueAt(set, category) * scale;

                  BarValue* value = m_floatingValues.at(itemIndex);

        sauimone
    
Floating values to bar charts

              r263
            
        sauimone
    
minor code review fixes, part n

              r763
            
                  QBarSet* barSet = m_series->barsetAt(set);

        Tero Ahola
    
Code review: Fixed simple issues in Bar and Legend

              r737
            
                  value->resize(100, 50);  // TODO: proper layout for this.

                  value->setPos(xPos, yPos-barHeight / 2);

        sauimone
    
better use of gradients in barcharts

              r512
            
                  value->setPen(barSet->floatingValuePen());

        sauimone
    
Floating values to bar charts

              r263
            
        sauimone
    
minor code review fixes, part n

              r763
            
                  if (m_series->valueAt(set, category) != 0) {

                      value->setValueString(QString::number(m_series->valueAt(set,category)));

        sauimone
    
updated barchart examples. minor fixes

              r276
            
                  } else {

                      value->setValueString(QString(""));

                  }

        sauimone
    
Floating values to bar charts

              r263
            
                  itemIndex++;

                  yPos -= barHeight;

              }

              xPos += xStep;

        sauimone
    
prototyping separators with stacked bars

              r119
            
          }

        sauimone
    
animations to stacked and percent barchart

              r694
            
          return layout;

        sauimone
    
added missing example files :)

              r96
            
      }

        sauimone
    
combined barpresenterbase and barpresenter. renamed barchartpresenters to barchartitems

              r666
            
      #include "moc_stackedbarchartitem_p.cpp"

        sauimone
    
moved tooltip to presenter

              r288
            
        sauimone
    
added missing example files :)

              r96
            
      QTCOMMERCIALCHART_END_NAMESPACE

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

sauimone combined barpresenterbase and barpresenter. renamed barchartpresenters to barchartitems	r666	#include "stackedbarchartitem_p.h"
sauimone renamed bar.h to bar_p.h	r118	#include "bar_p.h"
sauimone Floating values to bar charts	r263	#include "barvalue_p.h"
sauimone Added pen & brush to QBarSet	r214	#include "qbarset.h"
sauimone added missing example files :)	r96	#include <QDebug>

		QTCOMMERCIALCHART_BEGIN_NAMESPACE

Michal Klocek Refactors chartitem...	r677	StackedBarChartItem::StackedBarChartItem(QBarSeries series, ChartPresenter presenter) :
Tero Ahola Code review: Fixed simple issues in Bar and Legend	r737	BarChartItem(series, presenter)
sauimone added missing example files :)	r96	{
		}

sauimone combined barpresenterbase and barpresenter. renamed barchartpresenters to barchartitems	r666	StackedBarChartItem::~StackedBarChartItem()
sauimone updating drilldown example. Needs some more thinking	r438	{
		}

sauimone animations to stacked and percent barchart	r694	QVector<QRectF> StackedBarChartItem::calculateLayout()
sauimone added missing example files :)	r96	{
sauimone animations to stacked and percent barchart	r694	QVector<QRectF> layout;
sauimone Fixed layout for barcharts	r473	// Use temporary qreals for accurancy (we might get some compiler warnings... :)
Michal Klocek Refactors barchart axis hadnling...	r679
sauimone minor code review fixes, part n	r763	qreal maxSum = m_series->maxCategorySum();
sauimone barchart domain fix	r674	// Domain:
sauimone minor code review fixes, part n	r763	if (m_domainMaxY > maxSum) {
		maxSum = m_domainMaxY;
sauimone barchart domain fix	r674	}

Michal Klocek Refactors barchart axis hadnling...	r679	qreal height = geometry().height();
		qreal width = geometry().width();
sauimone minor code review fixes, part n	r763	qreal scale = (height / m_series->maxCategorySum());
		qreal categotyCount = m_series->categoryCount();
Tero Ahola Code review: Fixed simple issues in Bar and Legend	r737	qreal barWidth = width / (categotyCount * 2);
		qreal xStep = width / categotyCount;
		qreal xPos = xStep / 2 - barWidth / 2;
Michal Klocek Refactors barchart axis hadnling...	r679
sauimone Fixed layout for barcharts	r473	int itemIndex(0);
Michal Klocek Refactors barchart axis hadnling...	r679	for (int category = 0; category < categotyCount; category++) {
		qreal yPos = height;
sauimone minor code review fixes, part n	r763	for (int set=0; set < m_series->barsetCount(); set++) {
		qreal barHeight = m_series->valueAt(set, category) * scale;
		Bar* bar = m_bars.at(itemIndex);
		bar->setPen(m_series->barsetAt(set)->pen());
		bar->setBrush(m_series->barsetAt(set)->brush());
Tero Ahola Code review: Fixed simple issues in Bar and Legend	r737	QRectF rect(xPos, yPos-barHeight, barWidth, barHeight);
sauimone animations to stacked and percent barchart	r694	layout.append(rect);
sauimone added missing example files :)	r96	itemIndex++;
sauimone Some fixes to bar charts. Now bars draw almost correctly	r97	yPos -= barHeight;
sauimone added missing example files :)	r96	}
sauimone fixing layout bug on stacked bar chart	r98	xPos += xStep;
sauimone added missing example files :)	r96	}
sauimone cleanup on barseries. removed old commented out separator code	r654
sauimone Floating values to bar charts	r263	// Position floating values
		itemIndex = 0;
Michal Klocek Refactors barchart axis hadnling...	r679	xPos = (width/categotyCount);
sauimone minor code review fixes, part n	r763	for (int category=0; category < m_series->categoryCount(); category++) {
Michal Klocek Refactors barchart axis hadnling...	r679	qreal yPos = height;
sauimone minor code review fixes, part n	r763	for (int set=0; set < m_series->barsetCount(); set++) {
		qreal barHeight = m_series->valueAt(set, category) * scale;
		BarValue* value = m_floatingValues.at(itemIndex);
sauimone Floating values to bar charts	r263
sauimone minor code review fixes, part n	r763	QBarSet* barSet = m_series->barsetAt(set);
Tero Ahola Code review: Fixed simple issues in Bar and Legend	r737	value->resize(100, 50); // TODO: proper layout for this.
		value->setPos(xPos, yPos-barHeight / 2);
sauimone better use of gradients in barcharts	r512	value->setPen(barSet->floatingValuePen());
sauimone Floating values to bar charts	r263
sauimone minor code review fixes, part n	r763	if (m_series->valueAt(set, category) != 0) {
		value->setValueString(QString::number(m_series->valueAt(set,category)));
sauimone updated barchart examples. minor fixes	r276	} else {
		value->setValueString(QString(""));
		}
sauimone Floating values to bar charts	r263
		itemIndex++;
		yPos -= barHeight;
		}
		xPos += xStep;
sauimone prototyping separators with stacked bars	r119	}
sauimone animations to stacked and percent barchart	r694	return layout;
sauimone added missing example files :)	r96	}

sauimone combined barpresenterbase and barpresenter. renamed barchartpresenters to barchartitems	r666	#include "moc_stackedbarchartitem_p.cpp"
sauimone moved tooltip to presenter	r288
sauimone added missing example files :)	r96	QTCOMMERCIALCHART_END_NAMESPACE