##// END OF EJS Templates
fixed fc24 rpm build support.
Alexis Jeandet -
r110:bb586b1394df 0.6 draft
parent child
Show More
@@ -1,372 +1,373
1 1 %global upstream_name socexplorer-0.7-0
2 2
3 3 Name: socexplorer
4 4 Version: 0.7
5 5 Release: 0%{?dist}
6 6 Summary: SocExplorer is an open source generic System On Chip testing software/framework.
7 7 Group: Development/Tools
8 8 License: GPLv2+
9 9 URL: https://hephaistos.lpp.polytechnique.fr/redmine/projects/socexplorer
10 10 Source0: https://hephaistos.lpp.polytechnique.fr/redmine/attachments/download/376/%{upstream_name}.zip
11 11
12 12 BuildRequires: python2-devel
13 13 BuildRequires: qt5-qtbase-devel
14 14 BuildRequires: qt5-qtwebkit-devel
15 15 BuildRequires: qt5-qttools-static
16 16 BuildRequires: qt5-qttools-devel
17 17 BuildRequires: qt5-qtsvg-devel
18 18 BuildRequires: qt5-qtxmlpatterns-devel
19 19 BuildRequires: qt5-qtmultimedia-devel
20 20 BuildRequires: elfutils-libelf-devel
21 21 BuildRequires: qt5-pythonqt-devel
22 22 BuildRequires: mercurial
23 23 %if 0%{?fedora} <= 22
24 24 BuildRequires: appdata-tools
25 25 %endif
26 26 %if 0%{?fedora} >= 23
27 27 BuildRequires: libappstream-glib
28 28 %endif
29 29 BuildRequires: desktop-file-utils
30 30
31 31 Requires(post): python2
32 32 Requires(post): qt5-qtbase
33 33 Requires(post): qt5-qtwebkit
34 34 Requires(post): qt5-qtsvg
35 35 Requires(post): qt5-qtxmlpatterns
36 36 Requires(post): elfutils-libelf
37 37 Requires(post): qt5-pythonqt
38 38
39 39 Provides: socexplorer = 0.7-0
40 40
41 41 %description
42 42 SocExplorer is an open source generic System On Chip testing software/framework. We write this software for the development and the validation of our instrument, the Low Frequency Receiver(LFR) for the Solar Orbiter mission. This instrument is based on an actel FPGA hosting a LEON3FT processor and some peripherals. To make it more collaborative, we use a plugin based system, the main executable is SocExplorer then all the functionality are provided by plugins. Like this everybody can provide his set of plugins to handle a new SOC or just a new peripheral. SocExplorer uses PythonQt to allow user to automate some tasks such as loading some plugins, configuring them and talking with his device.
43 43
44 44 %package devel
45 45 Summary: SocExplorer is an open source generic System On Chip testing software/framework.
46 46 Group: Development/Tools
47 47 Requires: %{name}%{?_isa} = %{version}-%{release}
48 48 Requires: python2-devel
49 49 Requires: qt5-qtbase-devel
50 50 Requires: qt5-qtwebkit-devel
51 51 Requires: qt5-qttools-static
52 52 Requires: qt5-qttools-devel
53 53 Requires: qt5-qtsvg-devel
54 54 Requires: qt5-qtxmlpatterns-devel
55 55 Requires: qt5-qtmultimedia-devel
56 56 Requires: elfutils-libelf-devel
57 57 Requires: qt5-pythonqt-devel
58 58 Requires: mercurial
59 59 %if 0%{?fedora} <= 22
60 60 Requires: appdata-tools
61 61 %endif
62 62 %if 0%{?fedora} >= 23
63 63 Requires: libappstream-glib
64 64 %endif
65 65 Requires: desktop-file-utils
66 66
67 67 %description devel
68 68 Header files and development libraries for SocExplorer package. SocExplorer is an open source generic System On Chip testing software/framework.
69 69
70 %global debug_package %{nil}
70 71 %prep
71 72 %setup -q -n %{upstream_name}
72 73
73 74
74 75
75 76 %build
76 77 %{_qt5_qmake}
77 78
78 79 make %{?_smp_mflags}
79 80
80 81 %install
81 82 make install INSTALL_ROOT=%{buildroot}
82 83 appstream-util validate-relax %{buildroot}/%{_datadir}/appdata/socexplorer.appdata.xml
83 84 desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/socexplorer.desktop
84 85
85 86 %post -p /sbin/ldconfig
86 87
87 88 %postun -p /sbin/ldconfig
88 89
89 90 %files
90 91 /etc/SocExplorer/python/PygmentsHighlighter.py
91 92 /etc/SocExplorer/python/PygmentsHighlighter.pyc
92 93 /etc/SocExplorer/python/PygmentsHighlighter.pyo
93 94 /etc/SocExplorer/python/PythonCompleter.py
94 95 /etc/SocExplorer/python/PythonCompleter.pyc
95 96 /etc/SocExplorer/python/PythonCompleter.pyo
96 97 /etc/SocExplorer/python/module_completion.py
97 98 /etc/SocExplorer/python/module_completion.pyc
98 99 /etc/SocExplorer/python/module_completion.pyo
99 100 /etc/SocExplorer/python/pygments/__init__.py
100 101 /etc/SocExplorer/python/pygments/__init__.pyc
101 102 /etc/SocExplorer/python/pygments/__init__.pyo
102 103 /etc/SocExplorer/python/pygments/cmdline.py
103 104 /etc/SocExplorer/python/pygments/cmdline.pyc
104 105 /etc/SocExplorer/python/pygments/cmdline.pyo
105 106 /etc/SocExplorer/python/pygments/console.py
106 107 /etc/SocExplorer/python/pygments/console.pyc
107 108 /etc/SocExplorer/python/pygments/console.pyo
108 109 /etc/SocExplorer/python/pygments/filter.py
109 110 /etc/SocExplorer/python/pygments/filter.pyc
110 111 /etc/SocExplorer/python/pygments/filter.pyo
111 112 /etc/SocExplorer/python/pygments/filters/__init__.py
112 113 /etc/SocExplorer/python/pygments/filters/__init__.pyc
113 114 /etc/SocExplorer/python/pygments/filters/__init__.pyo
114 115 /etc/SocExplorer/python/pygments/formatter.py
115 116 /etc/SocExplorer/python/pygments/formatter.pyc
116 117 /etc/SocExplorer/python/pygments/formatter.pyo
117 118 /etc/SocExplorer/python/pygments/formatters/__init__.py
118 119 /etc/SocExplorer/python/pygments/formatters/__init__.pyc
119 120 /etc/SocExplorer/python/pygments/formatters/__init__.pyo
120 121 /etc/SocExplorer/python/pygments/formatters/_mapping.py
121 122 /etc/SocExplorer/python/pygments/formatters/_mapping.pyc
122 123 /etc/SocExplorer/python/pygments/formatters/_mapping.pyo
123 124 /etc/SocExplorer/python/pygments/formatters/bbcode.py
124 125 /etc/SocExplorer/python/pygments/formatters/bbcode.pyc
125 126 /etc/SocExplorer/python/pygments/formatters/bbcode.pyo
126 127 /etc/SocExplorer/python/pygments/formatters/html.py
127 128 /etc/SocExplorer/python/pygments/formatters/html.pyc
128 129 /etc/SocExplorer/python/pygments/formatters/html.pyo
129 130 /etc/SocExplorer/python/pygments/formatters/img.py
130 131 /etc/SocExplorer/python/pygments/formatters/img.pyc
131 132 /etc/SocExplorer/python/pygments/formatters/img.pyo
132 133 /etc/SocExplorer/python/pygments/formatters/latex.py
133 134 /etc/SocExplorer/python/pygments/formatters/latex.pyc
134 135 /etc/SocExplorer/python/pygments/formatters/latex.pyo
135 136 /etc/SocExplorer/python/pygments/formatters/other.py
136 137 /etc/SocExplorer/python/pygments/formatters/other.pyc
137 138 /etc/SocExplorer/python/pygments/formatters/other.pyo
138 139 /etc/SocExplorer/python/pygments/formatters/rtf.py
139 140 /etc/SocExplorer/python/pygments/formatters/rtf.pyc
140 141 /etc/SocExplorer/python/pygments/formatters/rtf.pyo
141 142 /etc/SocExplorer/python/pygments/formatters/svg.py
142 143 /etc/SocExplorer/python/pygments/formatters/svg.pyc
143 144 /etc/SocExplorer/python/pygments/formatters/svg.pyo
144 145 /etc/SocExplorer/python/pygments/formatters/terminal.py
145 146 /etc/SocExplorer/python/pygments/formatters/terminal.pyc
146 147 /etc/SocExplorer/python/pygments/formatters/terminal.pyo
147 148 /etc/SocExplorer/python/pygments/formatters/terminal256.py
148 149 /etc/SocExplorer/python/pygments/formatters/terminal256.pyc
149 150 /etc/SocExplorer/python/pygments/formatters/terminal256.pyo
150 151 /etc/SocExplorer/python/pygments/lexer.py
151 152 /etc/SocExplorer/python/pygments/lexer.pyc
152 153 /etc/SocExplorer/python/pygments/lexer.pyo
153 154 /etc/SocExplorer/python/pygments/lexers/__init__.py
154 155 /etc/SocExplorer/python/pygments/lexers/__init__.pyc
155 156 /etc/SocExplorer/python/pygments/lexers/__init__.pyo
156 157 /etc/SocExplorer/python/pygments/lexers/_asybuiltins.py
157 158 /etc/SocExplorer/python/pygments/lexers/_asybuiltins.pyc
158 159 /etc/SocExplorer/python/pygments/lexers/_asybuiltins.pyo
159 160 /etc/SocExplorer/python/pygments/lexers/_clbuiltins.py
160 161 /etc/SocExplorer/python/pygments/lexers/_clbuiltins.pyc
161 162 /etc/SocExplorer/python/pygments/lexers/_clbuiltins.pyo
162 163 /etc/SocExplorer/python/pygments/lexers/_luabuiltins.py
163 164 /etc/SocExplorer/python/pygments/lexers/_luabuiltins.pyc
164 165 /etc/SocExplorer/python/pygments/lexers/_luabuiltins.pyo
165 166 /etc/SocExplorer/python/pygments/lexers/_mapping.py
166 167 /etc/SocExplorer/python/pygments/lexers/_mapping.pyc
167 168 /etc/SocExplorer/python/pygments/lexers/_mapping.pyo
168 169 /etc/SocExplorer/python/pygments/lexers/_phpbuiltins.py
169 170 /etc/SocExplorer/python/pygments/lexers/_phpbuiltins.pyc
170 171 /etc/SocExplorer/python/pygments/lexers/_phpbuiltins.pyo
171 172 /etc/SocExplorer/python/pygments/lexers/_postgres_builtins.py
172 173 /etc/SocExplorer/python/pygments/lexers/_postgres_builtins.pyc
173 174 /etc/SocExplorer/python/pygments/lexers/_postgres_builtins.pyo
174 175 /etc/SocExplorer/python/pygments/lexers/_scilab_builtins.py
175 176 /etc/SocExplorer/python/pygments/lexers/_scilab_builtins.pyc
176 177 /etc/SocExplorer/python/pygments/lexers/_scilab_builtins.pyo
177 178 /etc/SocExplorer/python/pygments/lexers/_vimbuiltins.py
178 179 /etc/SocExplorer/python/pygments/lexers/_vimbuiltins.pyc
179 180 /etc/SocExplorer/python/pygments/lexers/_vimbuiltins.pyo
180 181 /etc/SocExplorer/python/pygments/lexers/agile.py
181 182 /etc/SocExplorer/python/pygments/lexers/agile.pyc
182 183 /etc/SocExplorer/python/pygments/lexers/agile.pyo
183 184 /etc/SocExplorer/python/pygments/lexers/asm.py
184 185 /etc/SocExplorer/python/pygments/lexers/asm.pyc
185 186 /etc/SocExplorer/python/pygments/lexers/asm.pyo
186 187 /etc/SocExplorer/python/pygments/lexers/compiled.py
187 188 /etc/SocExplorer/python/pygments/lexers/compiled.pyc
188 189 /etc/SocExplorer/python/pygments/lexers/compiled.pyo
189 190 /etc/SocExplorer/python/pygments/lexers/dotnet.py
190 191 /etc/SocExplorer/python/pygments/lexers/dotnet.pyc
191 192 /etc/SocExplorer/python/pygments/lexers/dotnet.pyo
192 193 /etc/SocExplorer/python/pygments/lexers/functional.py
193 194 /etc/SocExplorer/python/pygments/lexers/functional.pyc
194 195 /etc/SocExplorer/python/pygments/lexers/functional.pyo
195 196 /etc/SocExplorer/python/pygments/lexers/hdl.py
196 197 /etc/SocExplorer/python/pygments/lexers/hdl.pyc
197 198 /etc/SocExplorer/python/pygments/lexers/hdl.pyo
198 199 /etc/SocExplorer/python/pygments/lexers/jvm.py
199 200 /etc/SocExplorer/python/pygments/lexers/jvm.pyc
200 201 /etc/SocExplorer/python/pygments/lexers/jvm.pyo
201 202 /etc/SocExplorer/python/pygments/lexers/math.py
202 203 /etc/SocExplorer/python/pygments/lexers/math.pyc
203 204 /etc/SocExplorer/python/pygments/lexers/math.pyo
204 205 /etc/SocExplorer/python/pygments/lexers/other.py
205 206 /etc/SocExplorer/python/pygments/lexers/other.pyc
206 207 /etc/SocExplorer/python/pygments/lexers/other.pyo
207 208 /etc/SocExplorer/python/pygments/lexers/parsers.py
208 209 /etc/SocExplorer/python/pygments/lexers/parsers.pyc
209 210 /etc/SocExplorer/python/pygments/lexers/parsers.pyo
210 211 /etc/SocExplorer/python/pygments/lexers/shell.py
211 212 /etc/SocExplorer/python/pygments/lexers/shell.pyc
212 213 /etc/SocExplorer/python/pygments/lexers/shell.pyo
213 214 /etc/SocExplorer/python/pygments/lexers/special.py
214 215 /etc/SocExplorer/python/pygments/lexers/special.pyc
215 216 /etc/SocExplorer/python/pygments/lexers/special.pyo
216 217 /etc/SocExplorer/python/pygments/lexers/sql.py
217 218 /etc/SocExplorer/python/pygments/lexers/sql.pyc
218 219 /etc/SocExplorer/python/pygments/lexers/sql.pyo
219 220 /etc/SocExplorer/python/pygments/lexers/templates.py
220 221 /etc/SocExplorer/python/pygments/lexers/templates.pyc
221 222 /etc/SocExplorer/python/pygments/lexers/templates.pyo
222 223 /etc/SocExplorer/python/pygments/lexers/text.py
223 224 /etc/SocExplorer/python/pygments/lexers/text.pyc
224 225 /etc/SocExplorer/python/pygments/lexers/text.pyo
225 226 /etc/SocExplorer/python/pygments/lexers/web.py
226 227 /etc/SocExplorer/python/pygments/lexers/web.pyc
227 228 /etc/SocExplorer/python/pygments/lexers/web.pyo
228 229 /etc/SocExplorer/python/pygments/plugin.py
229 230 /etc/SocExplorer/python/pygments/plugin.pyc
230 231 /etc/SocExplorer/python/pygments/plugin.pyo
231 232 /etc/SocExplorer/python/pygments/scanner.py
232 233 /etc/SocExplorer/python/pygments/scanner.pyc
233 234 /etc/SocExplorer/python/pygments/scanner.pyo
234 235 /etc/SocExplorer/python/pygments/style.py
235 236 /etc/SocExplorer/python/pygments/style.pyc
236 237 /etc/SocExplorer/python/pygments/style.pyo
237 238 /etc/SocExplorer/python/pygments/styles/__init__.py
238 239 /etc/SocExplorer/python/pygments/styles/__init__.pyc
239 240 /etc/SocExplorer/python/pygments/styles/__init__.pyo
240 241 /etc/SocExplorer/python/pygments/styles/autumn.py
241 242 /etc/SocExplorer/python/pygments/styles/autumn.pyc
242 243 /etc/SocExplorer/python/pygments/styles/autumn.pyo
243 244 /etc/SocExplorer/python/pygments/styles/borland.py
244 245 /etc/SocExplorer/python/pygments/styles/borland.pyc
245 246 /etc/SocExplorer/python/pygments/styles/borland.pyo
246 247 /etc/SocExplorer/python/pygments/styles/bw.py
247 248 /etc/SocExplorer/python/pygments/styles/bw.pyc
248 249 /etc/SocExplorer/python/pygments/styles/bw.pyo
249 250 /etc/SocExplorer/python/pygments/styles/colorful.py
250 251 /etc/SocExplorer/python/pygments/styles/colorful.pyc
251 252 /etc/SocExplorer/python/pygments/styles/colorful.pyo
252 253 /etc/SocExplorer/python/pygments/styles/default.py
253 254 /etc/SocExplorer/python/pygments/styles/default.pyc
254 255 /etc/SocExplorer/python/pygments/styles/default.pyo
255 256 /etc/SocExplorer/python/pygments/styles/emacs.py
256 257 /etc/SocExplorer/python/pygments/styles/emacs.pyc
257 258 /etc/SocExplorer/python/pygments/styles/emacs.pyo
258 259 /etc/SocExplorer/python/pygments/styles/friendly.py
259 260 /etc/SocExplorer/python/pygments/styles/friendly.pyc
260 261 /etc/SocExplorer/python/pygments/styles/friendly.pyo
261 262 /etc/SocExplorer/python/pygments/styles/fruity.py
262 263 /etc/SocExplorer/python/pygments/styles/fruity.pyc
263 264 /etc/SocExplorer/python/pygments/styles/fruity.pyo
264 265 /etc/SocExplorer/python/pygments/styles/manni.py
265 266 /etc/SocExplorer/python/pygments/styles/manni.pyc
266 267 /etc/SocExplorer/python/pygments/styles/manni.pyo
267 268 /etc/SocExplorer/python/pygments/styles/monokai.py
268 269 /etc/SocExplorer/python/pygments/styles/monokai.pyc
269 270 /etc/SocExplorer/python/pygments/styles/monokai.pyo
270 271 /etc/SocExplorer/python/pygments/styles/murphy.py
271 272 /etc/SocExplorer/python/pygments/styles/murphy.pyc
272 273 /etc/SocExplorer/python/pygments/styles/murphy.pyo
273 274 /etc/SocExplorer/python/pygments/styles/native.py
274 275 /etc/SocExplorer/python/pygments/styles/native.pyc
275 276 /etc/SocExplorer/python/pygments/styles/native.pyo
276 277 /etc/SocExplorer/python/pygments/styles/pastie.py
277 278 /etc/SocExplorer/python/pygments/styles/pastie.pyc
278 279 /etc/SocExplorer/python/pygments/styles/pastie.pyo
279 280 /etc/SocExplorer/python/pygments/styles/perldoc.py
280 281 /etc/SocExplorer/python/pygments/styles/perldoc.pyc
281 282 /etc/SocExplorer/python/pygments/styles/perldoc.pyo
282 283 /etc/SocExplorer/python/pygments/styles/rrt.py
283 284 /etc/SocExplorer/python/pygments/styles/rrt.pyc
284 285 /etc/SocExplorer/python/pygments/styles/rrt.pyo
285 286 /etc/SocExplorer/python/pygments/styles/tango.py
286 287 /etc/SocExplorer/python/pygments/styles/tango.pyc
287 288 /etc/SocExplorer/python/pygments/styles/tango.pyo
288 289 /etc/SocExplorer/python/pygments/styles/trac.py
289 290 /etc/SocExplorer/python/pygments/styles/trac.pyc
290 291 /etc/SocExplorer/python/pygments/styles/trac.pyo
291 292 /etc/SocExplorer/python/pygments/styles/vim.py
292 293 /etc/SocExplorer/python/pygments/styles/vim.pyc
293 294 /etc/SocExplorer/python/pygments/styles/vim.pyo
294 295 /etc/SocExplorer/python/pygments/styles/vs.py
295 296 /etc/SocExplorer/python/pygments/styles/vs.pyc
296 297 /etc/SocExplorer/python/pygments/styles/vs.pyo
297 298 /etc/SocExplorer/python/pygments/token.py
298 299 /etc/SocExplorer/python/pygments/token.pyc
299 300 /etc/SocExplorer/python/pygments/token.pyo
300 301 /etc/SocExplorer/python/pygments/unistring.py
301 302 /etc/SocExplorer/python/pygments/unistring.pyc
302 303 /etc/SocExplorer/python/pygments/unistring.pyo
303 304 /etc/SocExplorer/python/pygments/util.py
304 305 /etc/SocExplorer/python/pygments/util.pyc
305 306 /etc/SocExplorer/python/pygments/util.pyo
306 307 /etc/SocExplorer/plugin.conf.d/plugins.conf
307 308 %{_bindir}/SocExplorer_TCP_Terminal
308 309 %{_bindir}/socexplorer
309 310 %{_datadir}/SocExplorer/icon.png
310 311 %{_datadir}/SocExplorer/Grlib.xml
311 312 %{_datadir}/SocExplorer/LPP.xml
312 313 %{_datadir}/SocExplorer/IAP.xml
313 314 %{_datadir}/applications/socexplorer.desktop
314 315 %{_datadir}/appdata/socexplorer.appdata.xml
315 316 %{_qt5_libdir}/libsocexplorercommon.so*
316 317 %{_qt5_libdir}/libsocexplorerengine.so*
317 318
318 319
319 320 %files devel
320 321 %{_qt5_headerdir}/SocExplorer/
321 322 %{_qt5_archdatadir}/mkspecs/features/socexplorerplugin.prf
322 323 /usr/share/qtcreator/templates/wizards/SocExplorerPlugin/plugin.cpp
323 324 /usr/share/qtcreator/templates/wizards/SocExplorerPlugin/plugin.h
324 325 /usr/share/qtcreator/templates/wizards/SocExplorerPlugin/project.pro
325 326 /usr/share/qtcreator/templates/wizards/SocExplorerPlugin/wizard.xml
326 327
327 328
328 329 %changelog
329 330 * Tue Apr 19 2016 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.7
330 331 - Updated to 0.7 version.
331 332
332 333 * Fri Jan 22 2016 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.6
333 334 - Added Fedora 23 support.
334 335
335 336 * Mon Oct 26 2015 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.6
336 337 - Updated LPP IPs registers definition list(LPP.xml).
337 338
338 339 * Fri Apr 17 2015 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.6
339 340 - Updated abstractbinary file lib to expose new feature.
340 341
341 342 * Fri Apr 3 2015 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.6
342 343 - Fix some remaining mistakes.
343 344
344 345 * Thu Apr 2 2015 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.6
345 346 -Uses r80 as source.
346 347 -Removed GenericPySysdriver interface, now socexplorer plugins can be subclassed in python.
347 348
348 349 * Thu Mar 26 2015 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.5
349 350 -Uses r77 as source.
350 351
351 352 * Mon Mar 9 2015 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.4
352 353 - Uses r75 as source.
353 354
354 355 * Tue Feb 10 2015 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.4
355 356 - Uses r74 as source.
356 357
357 358 * Fri Feb 6 2015 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.4
358 359 - Reseted patches uses r73 as source.
359 360
360 361 * Tue Dec 30 2014 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.4
361 362 - Reseted patches uses r72 as source.
362 363
363 364 * Sun Jun 29 2014 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.4
364 365 - Reseted patches uses r69 as source.
365 366
366 367 * Sat Jun 28 2014 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.4
367 368 - Applied patch r65 to install also plugin as RPM
368 369 - Applied patch r66 to install xml soc descriptions in /usr/share/SocExplorer
369 370 - Applied patch r67 to add appdata for gnome-software visibility
370 371
371 372 * Tue Jun 24 2014 Alexis Jeandet <alexis.jeandet@member.fsf.org> - 0.4
372 373 - Initial Fedora packaging
General Comments 0
You need to be logged in to leave comments. Login now