GIT_REPOSITORIES/LPP/Users/mperrinel/SciQLop-fork Commit - r763:fb27cebc64ba

Few corrections

perrinel -

r763:fb27cebc64ba

parent child

Context file:

r763:fb27cebc64ba

core/include/Data/SqpIterator.h +5 -1

             #ifndef SCIQLOP_SQPITERATOR_H
             #define SCIQLOP_SQPITERATOR_H
             #include "CoreGlobal.h"
             /**
              * @brief The SqpIterator class represents an iterator used in SciQlop. It defines all operators
              * needed for a standard forward iterator
              * @tparam T the type of object handled in iterator
              * @sa http://www.cplusplus.com/reference/iterator/
              */
             template <typename T>
             class SCIQLOP_CORE_EXPORT SqpIterator {
             public:
                 using iterator_category = std::random_access_iterator_tag;
                 using value_type = const T;
                 using difference_type = std::ptrdiff_t;
                 using pointer = value_type *;
                 using reference = value_type &;
                 explicit SqpIterator(T value) : m_CurrentValue{std::move(value)} {}
                 virtual ~SqpIterator() noexcept = default;
                 SqpIterator(const SqpIterator &) = default;
-                SqpIterator &operator=(SqpIterator other) { swap(m_CurrentValue, other.m_CurrentValue); }
+                SqpIterator &operator=(SqpIterator other)
+                {
+                    swap(m_CurrentValue, other.m_CurrentValue);
+                    return *this;
+                }
                 SqpIterator &operator++()
                 {
                     m_CurrentValue.next();
                     return *this;
                 }
                 SqpIterator &operator--()
                 {
                     m_CurrentValue.prev();
                     return *this;
                 }
                 SqpIterator operator++(int)const
                 {
                     auto result = *this;
                     this->operator++();
                     return result;
                 }
                 SqpIterator operator--(int)const
                 {
                     auto result = *this;
                     this->operator--();
                     return result;
                 }
                 SqpIterator &operator+=(int offset)
                 {
                     if (offset >= 0) {
                         m_CurrentValue.next(offset);
                     }
                     else {
                         while (offset++) {
                             m_CurrentValue.prev();
                         }
                     }
                     return *this;
                 }
                 SqpIterator &operator-=(int offset) { return *this += -offset; }
                 SqpIterator operator+(int offset) const
                 {
                     auto result = *this;
                     result += offset;
                     return result;
                 }
                 SqpIterator operator-(int offset) const
                 {
                     auto result = *this;
                     result -= offset;
                     return result;
                 }
                 int operator-(const SqpIterator &other) const
                 {
                     return m_CurrentValue.distance(other.m_CurrentValue);
                 }
                 const T *operator->() const { return &m_CurrentValue; }
                 const T &operator*() const { return m_CurrentValue; }
                 T *operator->() { return &m_CurrentValue; }
                 T &operator*() { return m_CurrentValue; }
                 T &operator[](int offset) const { return m_CurrentValue.advance(offset); }
                 bool operator==(const SqpIterator &other) const
                 {
                     return m_CurrentValue.equals(other.m_CurrentValue);
                 }
                 bool operator!=(const SqpIterator &other) const { return !(*this == other); }
                 bool operator>(const SqpIterator &other) const { return other.m_CurrentValue.lowerThan(*this); }
                 bool operator<(const SqpIterator &other) const
                 {
                     return m_CurrentValue.lowerThan(other.m_CurrentValue);
                 }
                 bool operator>=(const SqpIterator &other) const { return !(*this < other); }
                 bool operator<=(const SqpIterator &other) const { return !(*this > other); }
             private:
                 T m_CurrentValue;
             };
             #endif // SCIQLOP_SQPITERATOR_H

core/src/Data/DataSeriesIterator.cpp 0 -1

             #include "Data/DataSeriesIterator.h"
             DataSeriesIteratorValue::DataSeriesIteratorValue(
                 std::unique_ptr<DataSeriesIteratorValue::Impl> impl)
                     : m_Impl{std::move(impl)}
             {
             }
             DataSeriesIteratorValue::DataSeriesIteratorValue(const DataSeriesIteratorValue &other)
                     : m_Impl{other.m_Impl->clone()}
             {
             }
             DataSeriesIteratorValue &DataSeriesIteratorValue::operator=(DataSeriesIteratorValue other)
             {
                 m_Impl->swap(*other.m_Impl);
                 return *this;
             }
             int DataSeriesIteratorValue::distance(const DataSeriesIteratorValue &other) const
             {
-                auto dist = m_Impl->distance(*other.m_Impl);
                 return m_Impl->distance(*other.m_Impl);
             }
             bool DataSeriesIteratorValue::equals(const DataSeriesIteratorValue &other) const
             {
                 return m_Impl->equals(*other.m_Impl);
             }
             bool DataSeriesIteratorValue::lowerThan(const DataSeriesIteratorValue &other) const
             {
                 return m_Impl->lowerThan(*other.m_Impl);
             }
             DataSeriesIteratorValue DataSeriesIteratorValue::advance(int offset) const
             {
                 return DataSeriesIteratorValue{m_Impl->advance(offset)};
             }
             void DataSeriesIteratorValue::next(int offset)
             {
                 m_Impl->next(offset);
             }
             void DataSeriesIteratorValue::prev()
             {
                 m_Impl->prev();
             }
             double DataSeriesIteratorValue::x() const
             {
                 return m_Impl->x();
             }
             double DataSeriesIteratorValue::value() const
             {
                 return m_Impl->value();
             }
             double DataSeriesIteratorValue::value(int componentIndex) const
             {
                 return m_Impl->value(componentIndex);
             }
             double DataSeriesIteratorValue::minValue() const
             {
                 return m_Impl->minValue();
             }
             double DataSeriesIteratorValue::maxValue() const
             {
                 return m_Impl->maxValue();
             }
             QVector<double> DataSeriesIteratorValue::values() const
             {
                 return m_Impl->values();
             }
             DataSeriesIteratorValue::Impl *DataSeriesIteratorValue::impl()
             {
                 return m_Impl.get();
             }

gui/src/Variable/VariableInspectorWidget.cpp +7 -3

             #include <Variable/RenameVariableDialog.h>
             #include <Variable/Variable.h>
             #include <Variable/VariableController.h>
             #include <Variable/VariableInspectorWidget.h>
             #include <Variable/VariableMenuHeaderWidget.h>
             #include <Variable/VariableModel.h>
             #include <ui_VariableInspectorWidget.h>
             #include <QMouseEvent>
             #include <QSortFilterProxyModel>
             #include <QStyledItemDelegate>
             #include <QWidgetAction>
             #include <SqpApplication.h>
             Q_LOGGING_CATEGORY(LOG_VariableInspectorWidget, "VariableInspectorWidget")
             class QProgressBarItemDelegate : public QStyledItemDelegate {
             public:
                 QProgressBarItemDelegate(QObject *parent) : QStyledItemDelegate{parent} {}
                 void paint(QPainter *painter, const QStyleOptionViewItem &option,
                            const QModelIndex &index) const
                 {
                     auto data = index.data(Qt::DisplayRole);
                     auto progressData = index.data(VariableRoles::ProgressRole);
                     if (data.isValid() && progressData.isValid()) {
                         auto name = data.value<QString>();
                         auto progress = progressData.value<double>();
                         if (progress > 0) {
                             auto cancelButtonWidth = 20;
                             auto progressBarOption = QStyleOptionProgressBar{};
                             auto progressRect = option.rect;
                             progressRect.setWidth(progressRect.width() - cancelButtonWidth);
                             progressBarOption.rect = progressRect;
                             progressBarOption.minimum = 0;
                             progressBarOption.maximum = 100;
                             progressBarOption.progress = progress;
                             progressBarOption.text
                                 = QString("%1 %2").arg(name).arg(QString::number(progress, 'f', 2) + "%");
                             progressBarOption.textVisible = true;
                             progressBarOption.textAlignment = Qt::AlignCenter;
                             QApplication::style()->drawControl(QStyle::CE_ProgressBar, &progressBarOption,
                                                                painter);
                             // Cancel button
                             auto buttonRect = QRect(progressRect.right(), option.rect.top(), cancelButtonWidth,
                                                     option.rect.height());
                             auto buttonOption = QStyleOptionButton{};
                             buttonOption.rect = buttonRect;
                             buttonOption.text = "X";
                             QApplication::style()->drawControl(QStyle::CE_PushButton, &buttonOption, painter);
                         }
                         else {
                             QStyledItemDelegate::paint(painter, option, index);
                         }
                     }
                     else {
                         QStyledItemDelegate::paint(painter, option, index);
                     }
                 }
                 bool editorEvent(QEvent *event, QAbstractItemModel *model, const QStyleOptionViewItem &option,
                                  const QModelIndex &index)
                 {
                     if (event->type() == QEvent::MouseButtonRelease) {
                         auto data = index.data(Qt::DisplayRole);
                         auto progressData = index.data(VariableRoles::ProgressRole);
                         if (data.isValid() && progressData.isValid()) {
                             auto cancelButtonWidth = 20;
                             auto progressRect = option.rect;
                             progressRect.setWidth(progressRect.width() - cancelButtonWidth);
                             // Cancel button
                             auto buttonRect = QRect(progressRect.right(), option.rect.top(), cancelButtonWidth,
                                                     option.rect.height());
                             auto e = (QMouseEvent *)event;
                             auto clickX = e->x();
                             auto clickY = e->y();
                             auto x = buttonRect.left();   // the X coordinate
                             auto y = buttonRect.top();    // the Y coordinate
                             auto w = buttonRect.width();  // button width
                             auto h = buttonRect.height(); // button height
                             if (clickX > x && clickX < x + w) {
                                 if (clickY > y && clickY < y + h) {
                                     auto variableModel = sqpApp->variableController().variableModel();
                                     variableModel->abortProgress(index);
                                 }
+                                return true;
                             }
                             else {
-                                QStyledItemDelegate::editorEvent(event, model, option, index);
+                                return QStyledItemDelegate::editorEvent(event, model, option, index);
                             }
                         }
                         else {
-                            QStyledItemDelegate::editorEvent(event, model, option, index);
+                            return QStyledItemDelegate::editorEvent(event, model, option, index);
                         }
                     }
                     else {
-                        QStyledItemDelegate::editorEvent(event, model, option, index);
+                        return QStyledItemDelegate::editorEvent(event, model, option, index);
                     }
+                    return QStyledItemDelegate::editorEvent(event, model, option, index);
                 }
             };
             VariableInspectorWidget::VariableInspectorWidget(QWidget *parent)
                     : QWidget{parent},
                       ui{new Ui::VariableInspectorWidget},
                       m_ProgressBarItemDelegate{new QProgressBarItemDelegate{this}}
             {
                 ui->setupUi(this);
                 // Sets model for table
                 //    auto sortFilterModel = new QSortFilterProxyModel{this};
                 //    sortFilterModel->setSourceModel(sqpApp->variableController().variableModel());
                 auto variableModel = sqpApp->variableController().variableModel();
                 ui->tableView->setModel(variableModel);
                 // Adds extra signal/slot between view and model, so the view can be updated instantly when
                 // there is a change of data in the model
                 connect(variableModel, SIGNAL(dataChanged(const QModelIndex &, const QModelIndex &)), this,
                         SLOT(refresh()));
                 ui->tableView->setSelectionModel(sqpApp->variableController().variableSelectionModel());
                 ui->tableView->setItemDelegateForColumn(0, m_ProgressBarItemDelegate);
                 // Fixes column sizes
                 auto model = ui->tableView->model();
                 const auto count = model->columnCount();
                 for (auto i = 0; i < count; ++i) {
                     ui->tableView->setColumnWidth(
                         i, model->headerData(i, Qt::Horizontal, Qt::SizeHintRole).toSize().width());
                 }
                 // Sets selection options
                 ui->tableView->setSelectionBehavior(QTableView::SelectRows);
                 ui->tableView->setSelectionMode(QTableView::ExtendedSelection);
                 // Connection to show a menu when right clicking on the tree
                 ui->tableView->setContextMenuPolicy(Qt::CustomContextMenu);
                 connect(ui->tableView, &QTableView::customContextMenuRequested, this,
                         &VariableInspectorWidget::onTableMenuRequested);
             }
             VariableInspectorWidget::~VariableInspectorWidget()
             {
                 delete ui;
             }
             void VariableInspectorWidget::onTableMenuRequested(const QPoint &pos) noexcept
             {
                 auto selectedRows = ui->tableView->selectionModel()->selectedRows();
                 // Gets the model to retrieve the underlying selected variables
                 auto model = sqpApp->variableController().variableModel();
                 auto selectedVariables = QVector<std::shared_ptr<Variable> >{};
                 for (const auto &selectedRow : qAsConst(selectedRows)) {
                     if (auto selectedVariable = model->variable(selectedRow.row())) {
                         selectedVariables.push_back(selectedVariable);
                     }
                 }
                 QMenu tableMenu{};
                 // Emits a signal so that potential receivers can populate the menu before displaying it
                 emit tableMenuAboutToBeDisplayed(&tableMenu, selectedVariables);
                 // Adds menu-specific actions
                 if (!selectedVariables.isEmpty()) {
                     tableMenu.addSeparator();
                     // 'Rename' and 'Duplicate' actions (only if one variable selected)
                     if (selectedVariables.size() == 1) {
                         auto selectedVariable = selectedVariables.front();
                         auto duplicateFun = [&selectedVariable]() {
                             sqpApp->variableController().cloneVariable(selectedVariable);
                         };
                         tableMenu.addAction(tr("Duplicate"), duplicateFun);
                         auto renameFun = [&selectedVariable, &model, this]() {
                             // Generates forbidden names (names associated to existing variables)
                             auto allVariables = model->variables();
                             auto forbiddenNames = QVector<QString>(allVariables.size());
                             std::transform(allVariables.cbegin(), allVariables.cend(), forbiddenNames.begin(),
                                            [](const auto &variable) { return variable->name(); });
                             RenameVariableDialog dialog{selectedVariable->name(), forbiddenNames, this};
                             if (dialog.exec() == QDialog::Accepted) {
                                 selectedVariable->setName(dialog.name());
                             }
                         };
                         tableMenu.addAction(tr("Rename..."), renameFun);
                     }
                     // 'Delete' action
                     auto deleteFun = [&selectedVariables]() {
                         sqpApp->variableController().deleteVariables(selectedVariables);
                     };
                     tableMenu.addAction(QIcon{":/icones/delete.png"}, tr("Delete"), deleteFun);
                 }
                 if (!tableMenu.isEmpty()) {
                     // Generates menu header (inserted before first action)
                     auto firstAction = tableMenu.actions().first();
                     auto headerAction = new QWidgetAction{&tableMenu};
                     headerAction->setDefaultWidget(new VariableMenuHeaderWidget{selectedVariables, &tableMenu});
                     tableMenu.insertAction(firstAction, headerAction);
                     // Displays menu
                     tableMenu.exec(QCursor::pos());
                 }
             }
             void VariableInspectorWidget::refresh() noexcept
             {
                 ui->tableView->viewport()->update();
             }

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages