GIT_REPOSITORIES/LPP/Users/mperrinel/SciQLop-fork Commit - r708:9aa695e50c87

Adds variable to model

Alexandre Leroux -

r708:9aa695e50c87

parent child

Context file:

r708:9aa695e50c87

core/include/Variable/VariableModel.h +8 0

                  explicit VariableModel(QObject *parent = nullptr);
                  /**
+                  * Adds an existing variable in the model.
+                  * @param variable the variable to add.
+                  * @remarks the variable's name is modified to avoid name duplicates
+                  * @remarks this method does nothing if the variable already exists in the model
+                  */
+                 void addVariable(std::shared_ptr<Variable> variable) noexcept;
+                 /**
                   * Creates a new variable in the model
                   * @param name the name of the new variable
                   * @param dateTime the dateTime of the new variable

core/src/Variable/VariableController.cpp +3 0

                  // Clones variable
                  auto duplicate = variable->clone();
+                 // Adds clone to model
+                 impl->m_VariableModel->addVariable(duplicate);
                  return duplicate;
              }

core/src/Variable/VariableModel.cpp +9 -5

              {
              }
-             std::shared_ptr<Variable> VariableModel::createVariable(const QString &name,
-                                                                     const SqpRange &dateTime,
-                                                                     const QVariantHash &metadata) noexcept
+             void VariableModel::addVariable(std::shared_ptr<Variable> variable) noexcept
              {
                  auto insertIndex = rowCount();
                  beginInsertRows({}, insertIndex, insertIndex);
-                 auto variable = std::make_shared<Variable>(name, dateTime, metadata);
                  impl->m_Variables.push_back(variable);
                  connect(variable.get(), &Variable::updated, this, &VariableModel::onVariableUpdated);
                  endInsertRows();
+             }
+             std::shared_ptr<Variable> VariableModel::createVariable(const QString &name,
+                                                                     const SqpRange &dateTime,
+                                                                     const QVariantHash &metadata) noexcept
+             {
+                 auto variable = std::make_shared<Variable>(name, dateTime, metadata);
+                 addVariable(variable);
                  return variable;
              }

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages