GIT_REPOSITORIES/LPP/Users/mperrinel/SciQLop-fork Commit - r842:5f082699d3e8

Integrates the drag&drop classes into the existing visualization classes.

trabillard -

r842:5f082699d3e8

parent child

Context file:

r842:5f082699d3e8

gui/include/Visualization/VisualizationGraphWidget.h +11 -1

              #define SCIQLOP_VISUALIZATIONGRAPHWIDGET_H
              #include "Visualization/IVisualizationWidget.h"
+             #include "Visualization/VisualizationDragWidget.h"
              #include <QLoggingCategory>
              #include <QWidget>
              class QCustomPlot;
              class SqpRange;
              class Variable;
+             class VisualizationZoneWidget;
              namespace Ui {
              class VisualizationGraphWidget;
              } // namespace Ui
-             class VisualizationGraphWidget : public QWidget, public IVisualizationWidget {
+             class VisualizationGraphWidget : public VisualizationDragWidget, public IVisualizationWidget {
                  Q_OBJECT
                  friend class QCustomPlotSynchronizer;
                  explicit VisualizationGraphWidget(const QString &name = {}, QWidget *parent = 0);
                  virtual ~VisualizationGraphWidget();
+                 VisualizationZoneWidget* parentZoneWidget() const noexcept;
                  /// If acquisition isn't enable, requestDataLoading signal cannot be emit
                  void enableAcquisition(bool enable);
                  /// Removes a variable from the graph
                  void removeVariable(std::shared_ptr<Variable> variable) noexcept;
+                 /// Returns the list of all variables used in the graph
+                 QList<std::shared_ptr<Variable>> variables() const;
                  void setYRange(const SqpRange &range);
                  SqpRange graphRange() const noexcept;
                  void setGraphRange(const SqpRange &range);
                  bool contains(const Variable &variable) const override;
                  QString name() const override;
+                 // VisualisationDragWidget
+                 QMimeData* mimeData() const override;
+                 bool isDragAllowed() const override;
              signals:
                  void synchronize(const SqpRange &range, const SqpRange &oldRange);

gui/include/Visualization/VisualizationTabWidget.h +16 -1

              #include <QLoggingCategory>
              #include <QWidget>
+             #include <QMimeData>
              Q_DECLARE_LOGGING_CATEGORY(LOG_VisualizationTabWidget)
                  /// Add a zone widget
                  void addZone(VisualizationZoneWidget *zoneWidget);
+                 void insertZone(int index, VisualizationZoneWidget *zoneWidget);
                  /**
                   * Creates a zone using a variable. The variable will be displayed in a new graph of the new
-                  * zone.
+                  * zone. The zone is added at the end.
                   * @param variable the variable for which to create the zone
                   * @return the pointer to the created zone
                   */
                  VisualizationZoneWidget *createZone(std::shared_ptr<Variable> variable);
+                 /**
+                  * Creates a zone using a list of variables. The variables will be displayed in a new graph of the new
+                  * zone. The zone is inserted at the specified index.
+                  * @param variables the variables for which to create the zone
+                  * @param index The index where the zone should be inserted in the layout
+                  * @return the pointer to the created zone
+                  */
+                 VisualizationZoneWidget *createZone(const QList<std::shared_ptr<Variable>>& variables, int index);
                  // IVisualizationWidget interface
                  void accept(IVisualizationWidgetVisitor *visitor) override;
                  bool canDrop(const Variable &variable) const override;
                  class VisualizationTabWidgetPrivate;
                  spimpl::unique_impl_ptr<VisualizationTabWidgetPrivate> impl;
+             private slots:
+                 void dropMimeData(int index, const QMimeData *mimeData);
              };
              #endif // SCIQLOP_VISUALIZATIONTABWIDGET_H

gui/include/Visualization/VisualizationZoneWidget.h +31 -2

              #define SCIQLOP_VISUALIZATIONZONEWIDGET_H
              #include "Visualization/IVisualizationWidget.h"
+             #include "Visualization/VisualizationDragWidget.h"
              #include <QLoggingCategory>
              #include <QWidget>
              class Variable;
              class VisualizationGraphWidget;
-             class VisualizationZoneWidget : public QWidget, public IVisualizationWidget {
+             class VisualizationZoneWidget : public VisualizationDragWidget, public IVisualizationWidget {
                  Q_OBJECT
              public:
                  explicit VisualizationZoneWidget(const QString &name = {}, QWidget *parent = 0);
                  virtual ~VisualizationZoneWidget();
-                 /// Add a graph widget
+                 /// Adds a graph widget
                  void addGraph(VisualizationGraphWidget *graphWidget);
+                  /// Inserts a graph widget
+                 void insertGraph(int index, VisualizationGraphWidget *graphWidget);
                  /**
                   * Creates a graph using a variable. The variable will be displayed in the new graph.
+                  * The graph is added at the end.
                   * @param variable the variable for which to create the graph
                   * @return the pointer to the created graph
                   */
                  VisualizationGraphWidget *createGraph(std::shared_ptr<Variable> variable);
+                 /**
+                  * Creates a graph using a variable. The variable will be displayed in the new graph.
+                  * The graph is inserted at the specified index.
+                  * @param variable the variable for which to create the graph
+                  * @param index The index where the graph should be inserted in the layout
+                  * @return the pointer to the created graph
+                  */
+                 VisualizationGraphWidget *createGraph(std::shared_ptr<Variable> variable, int index);
+                 /**
+                  * Creates a graph using a list of variables. The variables will be displayed in the new graph.
+                  * The graph is inserted at the specified index.
+                  * @param variables List of variables to be added to the graph
+                  * @param index The index where the graph should be inserted in the layout
+                  * @return the pointer to the created graph
+                  */
+                 VisualizationGraphWidget *createGraph(const QList<std::shared_ptr<Variable>> variables, int index);
                  // IVisualizationWidget interface
                  void accept(IVisualizationWidgetVisitor *visitor) override;
                  bool canDrop(const Variable &variable) const override;
                  bool contains(const Variable &variable) const override;
                  QString name() const override;
+                 // VisualisationDragWidget
+                 QMimeData* mimeData() const override;
+                 bool isDragAllowed() const override;
              protected:
                  void closeEvent(QCloseEvent *event) override;
                  void onVariableAdded(std::shared_ptr<Variable> variable);
                  /// Slot called when a variable is about to be removed from a graph contained in the zone
                  void onVariableAboutToBeRemoved(std::shared_ptr<Variable> variable);
+                 void dropMimeData(int index, const QMimeData* mimeData);
              };
              #endif // SCIQLOP_VISUALIZATIONZONEWIDGET_H

gui/src/Visualization/VisualizationGraphWidget.cpp +44 -1

              #include "Visualization/VisualizationDefs.h"
              #include "Visualization/VisualizationGraphHelper.h"
              #include "Visualization/VisualizationGraphRenderingDelegate.h"
+             #include "Visualization/VisualizationZoneWidget.h"
              #include "ui_VisualizationGraphWidget.h"
              #include <Data/ArrayData.h>
              #include <Data/IDataSeries.h>
              #include <Settings/SqpSettingsDefs.h>
              #include <SqpApplication.h>
+             #include <DragDropHelper.h>
              #include <Variable/Variable.h>
              #include <Variable/VariableController.h>
              };
              VisualizationGraphWidget::VisualizationGraphWidget(const QString &name, QWidget *parent)
-                     : QWidget{parent},
+                     : VisualizationDragWidget{parent},
                        ui{new Ui::VisualizationGraphWidget},
                        impl{spimpl::make_unique_impl<VisualizationGraphWidgetPrivate>(name)}
              {
                  delete ui;
              }
+             VisualizationZoneWidget *VisualizationGraphWidget::parentZoneWidget() const noexcept
+             {
+                 auto parent = parentWidget();
+                 do
+                 {
+                     parent = parent->parentWidget();
            


        

    

      

  

      
          

              

                    
                        
                        note
                    

              
          
          
              
  

  
    
  
  

  

    
        perrinel
    
  

          

          
              Wed, 25 Oct 2017 17:40:54
          


          

              
                
              

          

                    
                    

            
              
              

                
                    Comment #2335
                    
                

                      
                      
                        Edit
                      
                      
                        Delete
                      
              
            

            |
                 
                 

          
      
      
          parent can be null. don"t use do while :)
+                 } while (parent != nullptr && !qobject_cast<VisualizationZoneWidget*>(parent));
+                 return qobject_cast<VisualizationZoneWidget*>(parent);
+             }
              void VisualizationGraphWidget::enableAcquisition(bool enable)
              {
                  impl->m_DoAcquisition = enable;
                  ui->widget->replot();
              }
+             QList<std::shared_ptr<Variable>> VisualizationGraphWidget::variables() const
+             {
+                 auto variables = QList<std::shared_ptr<Variable>>{};
+                 for (auto it = std::cbegin(impl->m_VariableToPlotMultiMap); it != std::cend(impl->m_VariableToPlotMultiMap); ++it)
+                 {
+                     variables << it->first;
+                 }
+                 return variables;
+             }
              void VisualizationGraphWidget::setYRange(const SqpRange &range)
              {
                  ui->widget->yAxis->setRange(range.m_TStart, range.m_TEnd);
                  return impl->m_Name;
              }
+             QMimeData *VisualizationGraphWidget::mimeData() const
+             {
+                  auto *mimeData = new QMimeData;
            


        

    

      

  

      
          

              

                    
                        
                        note
                    

              
          
          
              
  

  
    
  
  

  

    
        perrinel
    
  

          

          
              Wed, 25 Oct 2017 17:41:42
          


          

              
                
              

          

                    
                    

            
              
              

                
                    Comment #2336
                    
                

                      
                      
                        Edit
                      
                      
                        Delete
                      
              
            

            |
                 
                 

          
      
      
          auto mimeData
+                  mimeData->setData(DragDropHelper::MIME_TYPE_GRAPH, QByteArray());
+                  return mimeData;
+             }
+             bool VisualizationGraphWidget::isDragAllowed() const
+             {
+                 return true;
+             }
              void VisualizationGraphWidget::closeEvent(QCloseEvent *event)
              {
                  Q_UNUSED(event);
              {
                  // Handles plot rendering when mouse is moving
                  impl->m_RenderingDelegate->onMouseMove(event);
+                 VisualizationDragWidget::mouseMoveEvent(event);
              }
              void VisualizationGraphWidget::onMouseWheel(QWheelEvent *event) noexcept
              void VisualizationGraphWidget::onMousePress(QMouseEvent *event) noexcept
              {
                  impl->m_IsCalibration = event->modifiers().testFlag(Qt::ControlModifier);
+                 plot().setInteraction(QCP::iRangeDrag, !event->modifiers().testFlag(Qt::AltModifier));
+                 VisualizationDragWidget::mousePressEvent(event);
              }
              void VisualizationGraphWidget::onMouseRelease(QMouseEvent *event) noexcept

gui/src/Visualization/VisualizationTabWidget.cpp +57 -5

              #include "ui_VisualizationTabWidget.h"
              #include "Visualization/VisualizationZoneWidget.h"
+             #include "Visualization/VisualizationGraphWidget.h"
+             #include "SqpApplication.h"
+             #include "DragDropHelper.h"
              Q_LOGGING_CATEGORY(LOG_VisualizationTabWidget, "VisualizationTabWidget")
              {
                  ui->setupUi(this);
+                 ui->dragDropContainer->setAcceptedMimeTypes({DragDropHelper::MIME_TYPE_GRAPH, DragDropHelper::MIME_TYPE_ZONE});
+                 connect(ui->dragDropContainer, &VisualizationDragDropContainer::dropOccured, this, &VisualizationTabWidget::dropMimeData);
                  // Widget is deleted when closed
                  setAttribute(Qt::WA_DeleteOnClose);
              }
              void VisualizationTabWidget::addZone(VisualizationZoneWidget *zoneWidget)
              {
-                 tabLayout().addWidget(zoneWidget);
+                 ui->dragDropContainer->addDragWidget(zoneWidget);
+             }
+             void VisualizationTabWidget::insertZone(int index, VisualizationZoneWidget *zoneWidget)
+             {
+                  ui->dragDropContainer->insertDragWidget(index, zoneWidget);
              }
              VisualizationZoneWidget *VisualizationTabWidget::createZone(std::shared_ptr<Variable> variable)
              {
-                 auto zoneWidget = new VisualizationZoneWidget{defaultZoneName(tabLayout()), this};
-                 this->addZone(zoneWidget);
+                 return createZone({variable}, -1);
+             }
+             VisualizationZoneWidget *VisualizationTabWidget::createZone(const QList<std::shared_ptr<Variable> > &variables, int index)
+             {
+                 auto zoneWidget = new VisualizationZoneWidget{defaultZoneName(*ui->dragDropContainer->layout()), this};
+                 this->insertZone(index, zoneWidget);
                  // Creates a new graph into the zone
-                 zoneWidget->createGraph(variable);
+                 zoneWidget->createGraph(variables, index);
                  return zoneWidget;
              }
              QLayout &VisualizationTabWidget::tabLayout() const noexcept
              {
-                 return *ui->scrollAreaWidgetContents->layout();
+                 return *ui->dragDropContainer->layout();
+             }
+             void VisualizationTabWidget::dropMimeData(int index, const QMimeData *mimeData)
+             {
+                 auto& helper = sqpApp->dragDropHelper();
+                 if (mimeData->hasFormat(DragDropHelper::MIME_TYPE_GRAPH))
+                 {
+                     auto graphWidget = static_cast<VisualizationGraphWidget*>(helper.getCurrentDragWidget());
+                     auto parentDragDropContainer = qobject_cast<VisualizationDragDropContainer*>(graphWidget->parentWidget());
+                     Q_ASSERT(parentDragDropContainer);
+                     auto nbGraph = parentDragDropContainer->countDragWidget();
+                     if (nbGraph == 1)
+                     {
+                         //This is the only graph in the previous zone, close the zone
+                         graphWidget->parentZoneWidget()->close();
+                     }
+                     else
+                     {
+                          //Close the graph
+                         graphWidget->close();
+                     }
+                     const auto& variables = graphWidget->variables();
+                     createZone(variables, index);
+                 }
+                 else if (mimeData->hasFormat(DragDropHelper::MIME_TYPE_ZONE))
+                 {
+                     //Simple move of the zone, no variable operation associated
+                     auto zoneWidget = static_cast<VisualizationZoneWidget*>(helper.getCurrentDragWidget());
+                     auto parentDragDropContainer = zoneWidget->parentWidget();
+                     parentDragDropContainer->layout()->removeWidget(zoneWidget);
+                     ui->dragDropContainer->insertDragWidget(index, zoneWidget);
+                 }
              }

gui/src/Visualization/VisualizationZoneWidget.cpp +98 -8

              #include <QUuid>
              #include <SqpApplication.h>
+             #include <DragDropHelper.h>
              #include <cmath>
+             #include <QLayout>
              Q_LOGGING_CATEGORY(LOG_VisualizationZoneWidget, "VisualizationZoneWidget")
              namespace {
              };
              VisualizationZoneWidget::VisualizationZoneWidget(const QString &name, QWidget *parent)
-                     : QWidget{parent},
+                     : VisualizationDragWidget{parent},
                        ui{new Ui::VisualizationZoneWidget},
                        impl{spimpl::make_unique_impl<VisualizationZoneWidgetPrivate>()}
              {
                  ui->zoneNameLabel->setText(name);
+                 ui->dragDropContainer->setAcceptedMimeTypes({DragDropHelper::MIME_TYPE_GRAPH});
+                 connect(ui->dragDropContainer, &VisualizationDragDropContainer::dropOccured, this, &VisualizationZoneWidget::dropMimeData);
                  // 'Close' options : widget is deleted when closed
                  setAttribute(Qt::WA_DeleteOnClose);
                  connect(ui->closeButton, &QToolButton::clicked, this, &VisualizationZoneWidget::close);
                  // Synchronize new graph with others in the zone
                  impl->m_Synchronizer->addGraph(*graphWidget);
-                 ui->visualizationZoneFrame->layout()->addWidget(graphWidget);
+                 ui->dragDropContainer->addDragWidget(graphWidget);
+             }
+             void VisualizationZoneWidget::insertGraph(int index, VisualizationGraphWidget *graphWidget)
+             {
+                 // Synchronize new graph with others in the zone
+                 impl->m_Synchronizer->addGraph(*graphWidget);
+                 ui->dragDropContainer->insertDragWidget(index, graphWidget);
              }
              VisualizationGraphWidget *VisualizationZoneWidget::createGraph(std::shared_ptr<Variable> variable)
              {
+                 return createGraph(variable, -1);
+             }
+             VisualizationGraphWidget *VisualizationZoneWidget::createGraph(std::shared_ptr<Variable> variable, int index)
+             {
                  auto graphWidget = new VisualizationGraphWidget{
-                     defaultGraphName(*ui->visualizationZoneFrame->layout()), this};
+                     defaultGraphName(*ui->dragDropContainer->layout()), this};
                  // Set graph properties
                                                                   const SqpRange &oldGraphRange) {
                      auto zoomType = VariableController::getZoomType(graphRange, oldGraphRange);
-                     auto frameLayout = ui->visualizationZoneFrame->layout();
+                     auto frameLayout = ui->dragDropContainer->layout();
                      for (auto i = 0; i < frameLayout->count(); ++i) {
                          auto graphChild
                              = dynamic_cast<VisualizationGraphWidget *>(frameLayout->itemAt(i)->widget());
                  auto range = SqpRange{};
                  // Apply visitor to graph children
-                 auto layout = ui->visualizationZoneFrame->layout();
+                 auto layout = ui->dragDropContainer->layout();
                  if (layout->count() > 0) {
                      // Case of a new graph in a existant zone
                      if (auto visualizationGraphWidget
                      range = variable->range();
                  }
-                 this->addGraph(graphWidget);
+                 this->insertGraph(index, graphWidget);
                  graphWidget->addVariable(variable, range);
                  return graphWidget;
              }
+             VisualizationGraphWidget *VisualizationZoneWidget::createGraph(const QList<std::shared_ptr<Variable> > variables, int index)
+             {
+                 if (variables.isEmpty())
+                     return nullptr;
+                 auto graphWidget = createGraph(variables.first(), index);
+                 for (auto variableIt = variables.cbegin() + 1; variableIt != variables.cend(); ++variableIt)
+                 {
+                     graphWidget->addVariable(*variableIt, graphWidget->graphRange());
+                 }
+                 return graphWidget;
+             }
              void VisualizationZoneWidget::accept(IVisualizationWidgetVisitor *visitor)
              {
                  if (visitor) {
                      // Apply visitor to graph children: widgets different from graphs are not visited (no
                      // action)
                      processGraphs(
-                         *ui->visualizationZoneFrame->layout(),
+                         *ui->dragDropContainer->layout(),
                          [visitor](VisualizationGraphWidget &graphWidget) { graphWidget.accept(visitor); });
                      visitor->visitLeave(this);
                  return ui->zoneNameLabel->text();
              }
+             QMimeData *VisualizationZoneWidget::mimeData() const
+             {
+                 auto *mimeData = new QMimeData;
+                 mimeData->setData(DragDropHelper::MIME_TYPE_ZONE, QByteArray());
+                 return mimeData;
+             }
+             bool VisualizationZoneWidget::isDragAllowed() const
+             {
+                 return true;
+             }
              void VisualizationZoneWidget::closeEvent(QCloseEvent *event)
              {
                  // Closes graphs in the zone
-                 processGraphs(*ui->visualizationZoneFrame->layout(),
+                 processGraphs(*ui->dragDropContainer->layout(),
                                [](VisualizationGraphWidget &graphWidget) { graphWidget.close(); });
                  // Delete synchronization group from variable controller
                                            Q_ARG(std::shared_ptr<Variable>, variable),
                                            Q_ARG(QUuid, impl->m_SynchronisationGroupId));
              }
+             void VisualizationZoneWidget::dropMimeData(int index, const QMimeData *mimeData)
+             {
+                 auto& helper = sqpApp->dragDropHelper();
+                 if (mimeData->hasFormat(DragDropHelper::MIME_TYPE_GRAPH))
+                 {
+                     auto graphWidget = static_cast<VisualizationGraphWidget*>(helper.getCurrentDragWidget());
+                     auto parentDragDropContainer = qobject_cast<VisualizationDragDropContainer*>(graphWidget->parentWidget());
+                     Q_ASSERT(parentDragDropContainer);
+                     const auto& variables = graphWidget->variables();
+                     if (!variables.empty())
+                     {
+                         if (parentDragDropContainer != ui->dragDropContainer)
+                         {
+                             //The drop didn't occur in the same zone
+                             auto previousParentZoneWidget = graphWidget->parentZoneWidget();
+                             auto nbGraph = parentDragDropContainer->countDragWidget();
+                             if (nbGraph == 1)
+                             {
+                                 //This is the only graph in the previous zone, close the zone
+                                 previousParentZoneWidget->close();
+                             }
+                             else
+                             {
+                                 //Close the graph
+                                 graphWidget->close();
+                             }
+                             //Creates the new graph in the zone
+                             createGraph(variables, index);
+                         }
+                         else
+                         {
+                             //The drop occurred in the same zone
+                             //Simple move of the graph, no variable operation associated
+                             parentDragDropContainer->layout()->removeWidget(graphWidget);
+                             ui->dragDropContainer->insertDragWidget(index, graphWidget);
+                         }
+                     }
+                 }
+             }

gui/ui/Visualization/VisualizationTabWidget.ui +11 0

                     <property name="bottomMargin">
                      <number>0</number>
                     </property>
+                    <item>
+                     <widget class="VisualizationDragDropContainer" name="dragDropContainer" native="true"/>
+                    </item>
                    </layout>
                   </widget>
                  </widget>
                 </item>
                </layout>
               </widget>
+              <customwidgets>
+               <customwidget>
+                <class>VisualizationDragDropContainer</class>
+                <extends>QWidget</extends>
+                <header>Visualization/VisualizationDragDropContainer.h</header>
+                <container>1</container>
+               </customwidget>
+              </customwidgets>
               <resources/>
               <connections/>
              </ui>

gui/ui/Visualization/VisualizationZoneWidget.ui +11 0

                    <property name="bottomMargin">
                     <number>0</number>
                    </property>
+                   <item>
+                    <widget class="VisualizationDragDropContainer" name="dragDropContainer" native="true"/>
+                   </item>
                   </layout>
                  </widget>
                 </item>
                </layout>
               </widget>
+              <customwidgets>
+               <customwidget>
+                <class>VisualizationDragDropContainer</class>
+                <extends>QWidget</extends>
+                <header>Visualization/VisualizationDragDropContainer.h</header>
+                <container>1</container>
+               </customwidget>
+              </customwidgets>
               <resources/>
               <connections/>
              </ui>

General Comments 6

trabillard

|

Pull request updated. Auto status change to "Under Review"

Changed commits:
  * 1 added
  * 0 removed

Changed files:
  * M gui/include/DragDropHelper.h
  * M gui/include/Visualization/VisualizationDragDropContainer.h
  * M gui/include/Visualization/VisualizationDragWidget.h
  * M gui/src/DragDropHelper.cpp
  * M gui/src/Visualization/VisualizationDragDropContainer.cpp
  * M gui/src/Visualization/VisualizationDragWidget.cpp
  * M gui/include/SqpApplication.h
  * M gui/include/Visualization/VisualizationGraphWidget.h
  * M gui/include/Visualization/VisualizationTabWidget.h
  * M gui/include/Visualization/VisualizationZoneWidget.h
  * M gui/src/SqpApplication.cpp
  * M gui/src/Visualization/VisualizationGraphWidget.cpp
  * M gui/src/Visualization/VisualizationTabWidget.cpp
  * M gui/src/Visualization/VisualizationZoneWidget.cpp
  * R core/include/Variable/VariableCacheStrategyFactory.h
  * R core/include/Variable/VariableSingleThresholdCacheStrategy.h
  * R core/tests/Variable/TestVariableSync.cpp
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/FileNotFound.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/NaNValue.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/NaNX.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/NoUnit.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/TooManyValues.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/ValidScalar1.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/ValidVector1.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/WrongDate.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/WrongUnit.txt
  * R plugins/amda/tests-resources/TestAmdaResultParser/amdaV2/WrongValue.txt
  * R plugins/mockplugin/include/MockDefs.h
  * R plugins/mockplugin/src/MockDefs.cpp
  * R core/include/Data/DataSeries.h
  * R core/include/Data/IDataSeries.h
  * R core/include/Data/VariableRequest.h
  * R core/include/Variable/Variable.h
  * R core/include/Variable/VariableCacheStrategy.h
  * R core/include/Variable/VariableController.h
  * R core/meson.build
  * R core/src/Data/VectorSeries.cpp
  * R core/src/Variable/Variable.cpp
  * R core/src/Variable/VariableAcquisitionWorker.cpp
  * R core/src/Variable/VariableController.cpp
  * R core/tests/Data/TestDataSeries.cpp
  * R core/tests/Variable/TestVariable.cpp
  * R core/tests/meson.build
  * R gui/meson.build
  * R gui/src/Variable/VariableInspectorWidget.cpp
  * R gui/src/Visualization/operations/RescaleAxeOperation.cpp
  * R plugins/amda/src/AmdaProvider.cpp
  * R plugins/amda/src/AmdaResultParser.cpp
  * R plugins/amda/tests/TestAmdaAcquisition.cpp
  * R plugins/amda/tests/TestAmdaResultParser.cpp
  * R plugins/mockplugin/include/CosinusProvider.h
  * R plugins/mockplugin/meson.build
  * R plugins/mockplugin/src/CosinusProvider.cpp
  * R plugins/mockplugin/src/MockPlugin.cpp
  * R plugins/mockplugin/tests/TestCosinusAcquisition.cpp
  * R core/src/Variable/VariableCacheStrategy.cpp

trabillard

|

Pull request updated. Auto status change to "Under Review"

Changed commits:
  * 1 added
  * 0 removed

Changed files:
  * M gui/include/Visualization/VisualizationDragDropContainer.h
  * M gui/include/Visualization/VisualizationDragWidget.h
  * M gui/src/Visualization/VisualizationDragDropContainer.cpp
  * M gui/src/Visualization/VisualizationGraphWidget.cpp
  * M gui/src/Visualization/VisualizationZoneWidget.cpp

perrinel

|

Status change > Approved

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages