From d6ec0a8c7ca012269d41efbc71f379884975b6e0 2017-06-19 09:05:39 From: Alexandre Leroux Date: 2017-06-19 09:05:39 Subject: [PATCH] Minor fixes --- diff --git a/core/src/DataSource/DataSourceController.cpp b/core/src/DataSource/DataSourceController.cpp index 2410176..bb87e87 100644 --- a/core/src/DataSource/DataSourceController.cpp +++ b/core/src/DataSource/DataSourceController.cpp @@ -1,5 +1,5 @@ -#include -#include +#include "DataSource/DataSourceController.h" +#include "DataSource/DataSourceItem.h" #include diff --git a/core/src/DataSource/DataSourceItem.cpp b/core/src/DataSource/DataSourceItem.cpp index c794bc2..16e0c53 100644 --- a/core/src/DataSource/DataSourceItem.cpp +++ b/core/src/DataSource/DataSourceItem.cpp @@ -30,7 +30,7 @@ DataSourceItem::DataSourceItem(DataSourceItemType type, QVector data) QVector DataSourceItem::actions() const noexcept { - QVector result{}; + auto result = QVector{}; std::transform(std::cbegin(impl->m_Actions), std::cend(impl->m_Actions), std::back_inserter(result), [](const auto &action) { return action.get(); }); diff --git a/core/src/Variable/VariableController.cpp b/core/src/Variable/VariableController.cpp index b7b0d44..7651e40 100644 --- a/core/src/Variable/VariableController.cpp +++ b/core/src/Variable/VariableController.cpp @@ -18,8 +18,11 @@ namespace { std::unique_ptr generateDefaultDataSeries(const IDataProvider &provider) noexcept { auto parameters = DataProviderParameters{ - static_cast(QDateTime{QDate{2017, 01, 01}}.toSecsSinceEpoch()), - static_cast(QDateTime{QDate{2017, 01, 03}}.toSecsSinceEpoch())}; + // Remarks : we don't use toSecsSinceEpoch() here (method is for Qt 5.8 or above) + static_cast(QDateTime{QDate{2017, 01, 01}, QTime{12, 00}}.toMSecsSinceEpoch() + / 1000.), + static_cast(QDateTime{QDate{2017, 01, 01}, QTime{12, 01}}.toMSecsSinceEpoch()) + / 1000.}; return provider.retrieveData(parameters); } diff --git a/core/vera-exclusions/exclusions.txt b/core/vera-exclusions/exclusions.txt index 24fe3c3..7946185 100644 --- a/core/vera-exclusions/exclusions.txt +++ b/core/vera-exclusions/exclusions.txt @@ -11,3 +11,6 @@ ArrayData\.h:\d+:.*IPSIS_S06.*found: (Dim) # Ignore false positive relative to an alias DataSourceItemAction\.h:\d+:.*IPSIS_S06.*found: (ExecuteFunction) + +# Ignore false positive relative to unnamed namespace +VariableController\.cpp:\d+:.*IPSIS_F13.*