GIT_REPOSITORIES/LPP/Users/mperrinel/SciQLop-fork Files · gui/src/Visualization/VisualizationTabWidget.cpp

Fix some glitches which occurred when dragging in the visualization something from the sides.

trabillard - - Load All Authors

File last commit:

r885:be7e4409e91c


                r886:4ed691514436

Download file

             VisualizationTabWidget.cpp
        
                    307 lines
            
             | 9.7 KiB
            
                | text/x-c
            
             |
                CppLexer
            
             / gui / src / Visualization / VisualizationTabWidget.cpp
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        perrinel
    
mv visualization -> Visualization...

              r95
            
      #include "Visualization/VisualizationTabWidget.h"

        Alexandre Leroux
    
Updates visitor interface...

              r207
            
      #include "Visualization/IVisualizationWidgetVisitor.h"

        perrinel
    
Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget

              r58
            
      #include "ui_VisualizationTabWidget.h"

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
      #include "Visualization/VisualizationGraphWidget.h"

        trabillard
    
Format changes

              r847
            
      #include "Visualization/VisualizationZoneWidget.h"

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
        trabillard
    
Manage drag&drop of empty graphs

              r844
            
      #include "Variable/VariableController.h"

        trabillard
    
Move Common MIME types constants in a Definition file in core module.

              r850
            
      #include "Common/MimeTypesDef.h"

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
      #include "DragDropHelper.h"

        trabillard
    
Format changes

              r847
            
      #include "SqpApplication.h"

        perrinel
    
Add the visualization gui classes

              r118
            
        Alexandre Leroux
    
Adds logs for null visitors

              r219
            
      Q_LOGGING_CATEGORY(LOG_VisualizationTabWidget, "VisualizationTabWidget")

        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
      namespace {

      /// Generates a default name for a new zone, according to the number of zones already displayed in

      /// the tab

      QString defaultZoneName(const QLayout &layout)

      {

          auto count = 0;

          for (auto i = 0; i < layout.count(); ++i) {

              if (dynamic_cast<VisualizationZoneWidget *>(layout.itemAt(i)->widget())) {

                  count++;

              }

          }

          return QObject::tr("Zone %1").arg(count + 1);

      }

        Alexandre Leroux
    
Handles desynchronisation when removing variable from a graph (2)...

              r738
            
      /**

       * Applies a function to all zones of the tab represented by its layout

       * @param layout the layout that contains zones

       * @param fun the function to apply to each zone

       */

      template <typename Fun>

      void processZones(QLayout &layout, Fun fun)

      {

          for (auto i = 0; i < layout.count(); ++i) {

              if (auto item = layout.itemAt(i)) {

                  if (auto visualizationZoneWidget

                      = dynamic_cast<VisualizationZoneWidget *>(item->widget())) {

                      fun(*visualizationZoneWidget);

                  }

              }

          }

      }

        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
      } // namespace

        Alexandre Leroux
    
Adds a name for a tab...

              r198
            
      struct VisualizationTabWidget::VisualizationTabWidgetPrivate {

          explicit VisualizationTabWidgetPrivate(const QString &name) : m_Name{name} {}

        perrinel
    
Add the visualization gui classes

              r118
            
        Alexandre Leroux
    
Adds a name for a tab...

              r198
            
          QString m_Name;

        trabillard
    
drop of variables in the visualization

              r852
            
          void dropGraph(int index, VisualizationTabWidget *tabWidget);

          void dropZone(int index, VisualizationTabWidget *tabWidget);

          void dropVariables(const QList<std::shared_ptr<Variable> > &variables, int index,

                             VisualizationTabWidget *tabWidget);

        Alexandre Leroux
    
Adds a name for a tab...

              r198
            
      };

      VisualizationTabWidget::VisualizationTabWidget(const QString &name, QWidget *parent)

              : QWidget{parent},

                ui{new Ui::VisualizationTabWidget},

                impl{spimpl::make_unique_impl<VisualizationTabWidgetPrivate>(name)}

        perrinel
    
Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget

              r58
            
      {

          ui->setupUi(this);

        Alexandre Leroux
    
Updates tab widget so it can be deleted when closed

              r267
            
        trabillard
    
Drag of the time widget on a graph

              r885
            
          ui->dragDropContainer->addAcceptedMimeType(

              MIME_TYPE_GRAPH, VisualizationDragDropContainer::DropBehavior::Inserted);

          ui->dragDropContainer->addAcceptedMimeType(

              MIME_TYPE_ZONE, VisualizationDragDropContainer::DropBehavior::Inserted);

          ui->dragDropContainer->addAcceptedMimeType(

              MIME_TYPE_VARIABLE_LIST, VisualizationDragDropContainer::DropBehavior::Inserted);

        trabillard
    
drop of variables in the visualization

              r852
            
          ui->dragDropContainer->setAcceptMimeDataFunction([this](auto mimeData) {

              return sqpApp->dragDropHelper().checkMimeDataForVisualization(mimeData,

                                                                            ui->dragDropContainer);

          });

        trabillard
    
Drag of the time widget on a graph

              r885
            
          connect(ui->dragDropContainer, &VisualizationDragDropContainer::dropOccuredInContainer, this,

                  &VisualizationTabWidget::dropMimeData);

        trabillard
    
Manage the scroll of the tab QScrollArea during a drag&drop operation

              r843
            
          sqpApp->dragDropHelper().addDragDropScrollArea(ui->scrollArea);

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
        Alexandre Leroux
    
Updates tab widget so it can be deleted when closed

              r267
            
          // Widget is deleted when closed

          setAttribute(Qt::WA_DeleteOnClose);

        perrinel
    
Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget

              r58
            
      }

      VisualizationTabWidget::~VisualizationTabWidget()

      {

        trabillard
    
Manage the scroll of the tab QScrollArea during a drag&drop operation

              r843
            
          sqpApp->dragDropHelper().removeDragDropScrollArea(ui->scrollArea);

        perrinel
    
Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget

              r58
            
          delete ui;

      }

        perrinel
    
Add the visualization gui classes

              r118
            
      void VisualizationTabWidget::addZone(VisualizationZoneWidget *zoneWidget)

      {

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
          ui->dragDropContainer->addDragWidget(zoneWidget);

      }

      void VisualizationTabWidget::insertZone(int index, VisualizationZoneWidget *zoneWidget)

      {

        trabillard
    
Format changes

              r847
            
          ui->dragDropContainer->insertDragWidget(index, zoneWidget);

        perrinel
    
Add the visualization gui classes

              r118
            
      }

        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
      VisualizationZoneWidget *VisualizationTabWidget::createZone(std::shared_ptr<Variable> variable)

        perrinel
    
Add the visualization gui classes

              r118
            
      {

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
          return createZone({variable}, -1);

      }

        trabillard
    
Format changes

              r847
            
      VisualizationZoneWidget *

      VisualizationTabWidget::createZone(const QList<std::shared_ptr<Variable> > &variables, int index)

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
      {

        trabillard
    
Manage drag&drop of empty graphs

              r844
            
          auto zoneWidget = createEmptyZone(index);

        perrinel
    
Add the visualization gui classes

              r118
            
        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
          // Creates a new graph into the zone

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
          zoneWidget->createGraph(variables, index);

        Alexandre Leroux
    
Completes the method of creating a zone from a variable

              r201
            
        perrinel
    
Add the visualization gui classes

              r118
            
          return zoneWidget;

      }

        trabillard
    
Manage drag&drop of empty graphs

              r844
            
      VisualizationZoneWidget *VisualizationTabWidget::createEmptyZone(int index)

      {

        trabillard
    
Format changes

              r847
            
          auto zoneWidget

              = new VisualizationZoneWidget{defaultZoneName(*ui->dragDropContainer->layout()), this};

        trabillard
    
Manage drag&drop of empty graphs

              r844
            
          this->insertZone(index, zoneWidget);

          return zoneWidget;

      }

        Alexandre Leroux
    
Updates visitor interface...

              r207
            
      void VisualizationTabWidget::accept(IVisualizationWidgetVisitor *visitor)

        perrinel
    
Add the visualization gui classes

              r118
            
      {

        Alexandre Leroux
    
Implements accept() method of visualization widgets

              r208
            
          if (visitor) {

              visitor->visitEnter(this);

        Alexandre Leroux
    
Handles desynchronisation when removing variable from a graph (2)...

              r738
            
              // Apply visitor to zone children: widgets different from zones are not visited (no action)

              processZones(tabLayout(), [visitor](VisualizationZoneWidget &zoneWidget) {

                  zoneWidget.accept(visitor);

              });

        Alexandre Leroux
    
Implements accept() method of visualization widgets

              r208
            
              visitor->visitLeave(this);

          }

        Alexandre Leroux
    
Adds logs for null visitors

              r219
            
          else {

              qCCritical(LOG_VisualizationTabWidget()) << tr("Can't visit widget : the visitor is null");

          }

        perrinel
    
Add the visualization gui classes

              r118
            
      }

        Alexandre Leroux
    
Creates a interface that defines a variable container...

              r209
            
      bool VisualizationTabWidget::canDrop(const Variable &variable) const

      {

          // A tab can always accomodate a variable

          Q_UNUSED(variable);

          return true;

      }

        Alexandre Leroux
    
Unplot menu (5): adds contains() method to an IVariableContainer...

              r327
            
      bool VisualizationTabWidget::contains(const Variable &variable) const

      {

          Q_UNUSED(variable);

          return false;

      }

        perrinel
    
Add const and override

              r119
            
      QString VisualizationTabWidget::name() const

        perrinel
    
Add the visualization gui classes

              r118
            
      {

        Alexandre Leroux
    
Adds a name for a tab...

              r198
            
          return impl->m_Name;

        perrinel
    
Add the visualization gui classes

              r118
            
      }

        Alexandre Leroux
    
Adds scrollbar to tabs

              r307
            
        Alexandre Leroux
    
Handles desynchronisation when removing variable from a graph (2)...

              r738
            
      void VisualizationTabWidget::closeEvent(QCloseEvent *event)

      {

          // Closes zones in the tab

          processZones(tabLayout(), [](VisualizationZoneWidget &zoneWidget) { zoneWidget.close(); });

          QWidget::closeEvent(event);

      }

        Alexandre Leroux
    
Adds scrollbar to tabs

              r307
            
      QLayout &VisualizationTabWidget::tabLayout() const noexcept

      {

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
          return *ui->dragDropContainer->layout();

      }

      void VisualizationTabWidget::dropMimeData(int index, const QMimeData *mimeData)

      {

        trabillard
    
Move Common MIME types constants in a Definition file in core module.

              r850
            
          if (mimeData->hasFormat(MIME_TYPE_GRAPH)) {

        trabillard
    
drop of variables in the visualization

              r852
            
              impl->dropGraph(index, this);

          }

          else if (mimeData->hasFormat(MIME_TYPE_ZONE)) {

              impl->dropZone(index, this);

          }

          else if (mimeData->hasFormat(MIME_TYPE_VARIABLE_LIST)) {

              auto variables = sqpApp->variableController().variablesForMimeData(

                  mimeData->data(MIME_TYPE_VARIABLE_LIST));

              impl->dropVariables(variables, index, this);

          }

          else {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropMimeData, unknown MIME data received.");

          }

      }

      void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropGraph(

          int index, VisualizationTabWidget *tabWidget)

      {

          auto &helper = sqpApp->dragDropHelper();

          auto graphWidget = qobject_cast<VisualizationGraphWidget *>(helper.getCurrentDragWidget());

          if (!graphWidget) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropGraph, drop aborted, the dropped graph is not "

                        "found or invalid.");

              Q_ASSERT(false);

              return;

          }

          auto parentDragDropContainer

              = qobject_cast<VisualizationDragDropContainer *>(graphWidget->parentWidget());

          if (!parentDragDropContainer) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropGraph, drop aborted, the parent container of "

                        "the dropped graph is not found.");

              Q_ASSERT(false);

              return;

          }

          auto nbGraph = parentDragDropContainer->countDragWidget();

        trabillard
    
Manage drag&drop of empty graphs

              r844
            
        trabillard
    
drop of variables in the visualization

              r852
            
          const auto &variables = graphWidget->variables();

          if (!variables.isEmpty()) {

              // Abort the requests for the variables (if any)

              // Commented, because it's not sure if it's needed or not

              // for (const auto& var : variables)

              //{

              //    sqpApp->variableController().onAbortProgressRequested(var);

              //}

              if (nbGraph == 1) {

                  // This is the only graph in the previous zone, close the zone

                  graphWidget->parentZoneWidget()->close();

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
              }

        trabillard
    
Format changes

              r847
            
              else {

        trabillard
    
drop of variables in the visualization

              r852
            
                  // Close the graph

                  graphWidget->close();

              }

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
        trabillard
    
drop of variables in the visualization

              r852
            
              tabWidget->createZone(variables, index);

          }

          else {

              // The graph is empty, create an empty zone and move the graph inside

        trabillard
    
Manage drag&drop of empty graphs

              r844
            
        trabillard
    
drop of variables in the visualization

              r852
            
              auto parentZoneWidget = graphWidget->parentZoneWidget();

        trabillard
    
Manage drag&drop of empty graphs

              r844
            
        trabillard
    
drop of variables in the visualization

              r852
            
              parentDragDropContainer->layout()->removeWidget(graphWidget);

        trabillard
    
Manage drag&drop of empty graphs

              r844
            
        trabillard
    
drop of variables in the visualization

              r852
            
              auto zoneWidget = tabWidget->createEmptyZone(index);

              zoneWidget->addGraph(graphWidget);

              // Close the old zone if it was the only graph inside

              if (nbGraph == 1) {

                  parentZoneWidget->close();

        trabillard
    
Manage drag&drop of empty graphs

              r844
            
              }

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
          }

        trabillard
    
drop of variables in the visualization

              r852
            
      }

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
        trabillard
    
drop of variables in the visualization

              r852
            
      void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropZone(

          int index, VisualizationTabWidget *tabWidget)

      {

          auto &helper = sqpApp->dragDropHelper();

          auto zoneWidget = qobject_cast<VisualizationZoneWidget *>(helper.getCurrentDragWidget());

          if (!zoneWidget) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropZone, drop aborted, the dropped zone is not "

                        "found or invalid.");

              Q_ASSERT(false);

              return;

          }

          auto parentDragDropContainer

              = qobject_cast<VisualizationDragDropContainer *>(zoneWidget->parentWidget());

          if (!parentDragDropContainer) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropZone, drop aborted, the parent container of "

                        "the dropped zone is not found.");

              Q_ASSERT(false);

              return;

        trabillard
    
Integrates the drag&drop classes into the existing visualization classes.

              r842
            
          }

        trabillard
    
drop of variables in the visualization

              r852
            
          // Simple move of the zone, no variable operation associated

          parentDragDropContainer->layout()->removeWidget(zoneWidget);

          tabWidget->ui->dragDropContainer->insertDragWidget(index, zoneWidget);

      }

      void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropVariables(

          const QList<std::shared_ptr<Variable> > &variables, int index,

          VisualizationTabWidget *tabWidget)

      {

        trabillard
    
Drag of product

              r876
            
          // Note: the AcceptMimeDataFunction (set on the drop container) ensure there is a single and

          // compatible variable here

          if (variables.count() > 1) {

              qCWarning(LOG_VisualizationZoneWidget())

                  << tr("VisualizationTabWidget::dropVariables, dropping multiple variables, operation "

                        "aborted.");

              return;

        trabillard
    
Drop of product in variables

              r877
            
          }

        trabillard
    
Drag of product

              r876
            
        trabillard
    
drop of variables in the visualization

              r852
            
          tabWidget->createZone(variables, index);

        Alexandre Leroux
    
Adds scrollbar to tabs

              r307
            
      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

perrinel mv visualization -> Visualization...	r95	#include "Visualization/VisualizationTabWidget.h"
Alexandre Leroux Updates visitor interface...	r207	#include "Visualization/IVisualizationWidgetVisitor.h"
perrinel Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget	r58	#include "ui_VisualizationTabWidget.h"

trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	#include "Visualization/VisualizationGraphWidget.h"
trabillard Format changes	r847	#include "Visualization/VisualizationZoneWidget.h"
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842
trabillard Manage drag&drop of empty graphs	r844	#include "Variable/VariableController.h"

trabillard Move Common MIME types constants in a Definition file in core module.	r850	#include "Common/MimeTypesDef.h"

trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	#include "DragDropHelper.h"
trabillard Format changes	r847	#include "SqpApplication.h"
perrinel Add the visualization gui classes	r118
Alexandre Leroux Adds logs for null visitors	r219	Q_LOGGING_CATEGORY(LOG_VisualizationTabWidget, "VisualizationTabWidget")

Alexandre Leroux Completes the method of creating a zone from a variable	r201	namespace {

		/// Generates a default name for a new zone, according to the number of zones already displayed in
		/// the tab
		QString defaultZoneName(const QLayout &layout)
		{
		auto count = 0;
		for (auto i = 0; i < layout.count(); ++i) {
		if (dynamic_cast<VisualizationZoneWidget *>(layout.itemAt(i)->widget())) {
		count++;
		}
		}

		return QObject::tr("Zone %1").arg(count + 1);
		}

Alexandre Leroux Handles desynchronisation when removing variable from a graph (2)...	r738	/**
		* Applies a function to all zones of the tab represented by its layout
		* @param layout the layout that contains zones
		* @param fun the function to apply to each zone
		*/
		template <typename Fun>
		void processZones(QLayout &layout, Fun fun)
		{
		for (auto i = 0; i < layout.count(); ++i) {
		if (auto item = layout.itemAt(i)) {
		if (auto visualizationZoneWidget
		= dynamic_cast<VisualizationZoneWidget *>(item->widget())) {
		fun(*visualizationZoneWidget);
		}
		}
		}
		}

Alexandre Leroux Completes the method of creating a zone from a variable	r201	} // namespace

Alexandre Leroux Adds a name for a tab...	r198	struct VisualizationTabWidget::VisualizationTabWidgetPrivate {
		explicit VisualizationTabWidgetPrivate(const QString &name) : m_Name{name} {}
perrinel Add the visualization gui classes	r118
Alexandre Leroux Adds a name for a tab...	r198	QString m_Name;
trabillard drop of variables in the visualization	r852
		void dropGraph(int index, VisualizationTabWidget *tabWidget);
		void dropZone(int index, VisualizationTabWidget *tabWidget);
		void dropVariables(const QList<std::shared_ptr<Variable> > &variables, int index,
		VisualizationTabWidget *tabWidget);
Alexandre Leroux Adds a name for a tab...	r198	};

		VisualizationTabWidget::VisualizationTabWidget(const QString &name, QWidget *parent)
		: QWidget{parent},
		ui{new Ui::VisualizationTabWidget},
		impl{spimpl::make_unique_impl<VisualizationTabWidgetPrivate>(name)}
perrinel Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget	r58	{
		ui->setupUi(this);
Alexandre Leroux Updates tab widget so it can be deleted when closed	r267
trabillard Drag of the time widget on a graph	r885	ui->dragDropContainer->addAcceptedMimeType(
		MIME_TYPE_GRAPH, VisualizationDragDropContainer::DropBehavior::Inserted);
		ui->dragDropContainer->addAcceptedMimeType(
		MIME_TYPE_ZONE, VisualizationDragDropContainer::DropBehavior::Inserted);
		ui->dragDropContainer->addAcceptedMimeType(
		MIME_TYPE_VARIABLE_LIST, VisualizationDragDropContainer::DropBehavior::Inserted);

trabillard drop of variables in the visualization	r852	ui->dragDropContainer->setAcceptMimeDataFunction([this](auto mimeData) {
		return sqpApp->dragDropHelper().checkMimeDataForVisualization(mimeData,
		ui->dragDropContainer);
		});
trabillard Drag of the time widget on a graph	r885
		connect(ui->dragDropContainer, &VisualizationDragDropContainer::dropOccuredInContainer, this,
		&VisualizationTabWidget::dropMimeData);

trabillard Manage the scroll of the tab QScrollArea during a drag&drop operation	r843	sqpApp->dragDropHelper().addDragDropScrollArea(ui->scrollArea);
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842
Alexandre Leroux Updates tab widget so it can be deleted when closed	r267	// Widget is deleted when closed
		setAttribute(Qt::WA_DeleteOnClose);
perrinel Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget	r58	}

		VisualizationTabWidget::~VisualizationTabWidget()
		{
trabillard Manage the scroll of the tab QScrollArea during a drag&drop operation	r843	sqpApp->dragDropHelper().removeDragDropScrollArea(ui->scrollArea);
perrinel Creation of VisualizationWidget, VizualizationTabWidget, VisualizationZoneWidget, VisualizationGraphWidget	r58	delete ui;
		}
perrinel Add the visualization gui classes	r118
		void VisualizationTabWidget::addZone(VisualizationZoneWidget *zoneWidget)
		{
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	ui->dragDropContainer->addDragWidget(zoneWidget);
		}

		void VisualizationTabWidget::insertZone(int index, VisualizationZoneWidget *zoneWidget)
		{
trabillard Format changes	r847	ui->dragDropContainer->insertDragWidget(index, zoneWidget);
perrinel Add the visualization gui classes	r118	}

Alexandre Leroux Completes the method of creating a zone from a variable	r201	VisualizationZoneWidget *VisualizationTabWidget::createZone(std::shared_ptr<Variable> variable)
perrinel Add the visualization gui classes	r118	{
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	return createZone({variable}, -1);
		}

trabillard Format changes	r847	VisualizationZoneWidget *
		VisualizationTabWidget::createZone(const QList<std::shared_ptr<Variable> > &variables, int index)
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	{
trabillard Manage drag&drop of empty graphs	r844	auto zoneWidget = createEmptyZone(index);
perrinel Add the visualization gui classes	r118
Alexandre Leroux Completes the method of creating a zone from a variable	r201	// Creates a new graph into the zone
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	zoneWidget->createGraph(variables, index);
Alexandre Leroux Completes the method of creating a zone from a variable	r201
perrinel Add the visualization gui classes	r118	return zoneWidget;
		}

trabillard Manage drag&drop of empty graphs	r844	VisualizationZoneWidget *VisualizationTabWidget::createEmptyZone(int index)
		{
trabillard Format changes	r847	auto zoneWidget
		= new VisualizationZoneWidget{defaultZoneName(*ui->dragDropContainer->layout()), this};
trabillard Manage drag&drop of empty graphs	r844	this->insertZone(index, zoneWidget);

		return zoneWidget;
		}

Alexandre Leroux Updates visitor interface...	r207	void VisualizationTabWidget::accept(IVisualizationWidgetVisitor *visitor)
perrinel Add the visualization gui classes	r118	{
Alexandre Leroux Implements accept() method of visualization widgets	r208	if (visitor) {
		visitor->visitEnter(this);

Alexandre Leroux Handles desynchronisation when removing variable from a graph (2)...	r738	// Apply visitor to zone children: widgets different from zones are not visited (no action)
		processZones(tabLayout(), [visitor](VisualizationZoneWidget &zoneWidget) {
		zoneWidget.accept(visitor);
		});
Alexandre Leroux Implements accept() method of visualization widgets	r208
		visitor->visitLeave(this);
		}
Alexandre Leroux Adds logs for null visitors	r219	else {
		qCCritical(LOG_VisualizationTabWidget()) << tr("Can't visit widget : the visitor is null");
		}
perrinel Add the visualization gui classes	r118	}

Alexandre Leroux Creates a interface that defines a variable container...	r209	bool VisualizationTabWidget::canDrop(const Variable &variable) const
		{
		// A tab can always accomodate a variable
		Q_UNUSED(variable);
		return true;
		}

Alexandre Leroux Unplot menu (5): adds contains() method to an IVariableContainer...	r327	bool VisualizationTabWidget::contains(const Variable &variable) const
		{
		Q_UNUSED(variable);
		return false;
		}

perrinel Add const and override	r119	QString VisualizationTabWidget::name() const
perrinel Add the visualization gui classes	r118	{
Alexandre Leroux Adds a name for a tab...	r198	return impl->m_Name;
perrinel Add the visualization gui classes	r118	}
Alexandre Leroux Adds scrollbar to tabs	r307
Alexandre Leroux Handles desynchronisation when removing variable from a graph (2)...	r738	void VisualizationTabWidget::closeEvent(QCloseEvent *event)
		{
		// Closes zones in the tab
		processZones(tabLayout(), [](VisualizationZoneWidget &zoneWidget) { zoneWidget.close(); });

		QWidget::closeEvent(event);
		}

Alexandre Leroux Adds scrollbar to tabs	r307	QLayout &VisualizationTabWidget::tabLayout() const noexcept
		{
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	return *ui->dragDropContainer->layout();
		}

		void VisualizationTabWidget::dropMimeData(int index, const QMimeData *mimeData)
		{
trabillard Move Common MIME types constants in a Definition file in core module.	r850	if (mimeData->hasFormat(MIME_TYPE_GRAPH)) {
trabillard drop of variables in the visualization	r852	impl->dropGraph(index, this);
		}
		else if (mimeData->hasFormat(MIME_TYPE_ZONE)) {
		impl->dropZone(index, this);
		}
		else if (mimeData->hasFormat(MIME_TYPE_VARIABLE_LIST)) {
		auto variables = sqpApp->variableController().variablesForMimeData(
		mimeData->data(MIME_TYPE_VARIABLE_LIST));
		impl->dropVariables(variables, index, this);
		}
		else {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropMimeData, unknown MIME data received.");
		}
		}

		void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropGraph(
		int index, VisualizationTabWidget *tabWidget)
		{
		auto &helper = sqpApp->dragDropHelper();

		auto graphWidget = qobject_cast<VisualizationGraphWidget *>(helper.getCurrentDragWidget());
		if (!graphWidget) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropGraph, drop aborted, the dropped graph is not "
		"found or invalid.");
		Q_ASSERT(false);
		return;
		}

		auto parentDragDropContainer
		= qobject_cast<VisualizationDragDropContainer *>(graphWidget->parentWidget());
		if (!parentDragDropContainer) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropGraph, drop aborted, the parent container of "
		"the dropped graph is not found.");
		Q_ASSERT(false);
		return;
		}

		auto nbGraph = parentDragDropContainer->countDragWidget();
trabillard Manage drag&drop of empty graphs	r844
trabillard drop of variables in the visualization	r852	const auto &variables = graphWidget->variables();

		if (!variables.isEmpty()) {
		// Abort the requests for the variables (if any)
		// Commented, because it's not sure if it's needed or not
		// for (const auto& var : variables)
		//{
		// sqpApp->variableController().onAbortProgressRequested(var);
		//}

		if (nbGraph == 1) {
		// This is the only graph in the previous zone, close the zone
		graphWidget->parentZoneWidget()->close();
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	}
trabillard Format changes	r847	else {
trabillard drop of variables in the visualization	r852	// Close the graph
		graphWidget->close();
		}
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842
trabillard drop of variables in the visualization	r852	tabWidget->createZone(variables, index);
		}
		else {
		// The graph is empty, create an empty zone and move the graph inside
trabillard Manage drag&drop of empty graphs	r844
trabillard drop of variables in the visualization	r852	auto parentZoneWidget = graphWidget->parentZoneWidget();
trabillard Manage drag&drop of empty graphs	r844
trabillard drop of variables in the visualization	r852	parentDragDropContainer->layout()->removeWidget(graphWidget);
trabillard Manage drag&drop of empty graphs	r844
trabillard drop of variables in the visualization	r852	auto zoneWidget = tabWidget->createEmptyZone(index);
		zoneWidget->addGraph(graphWidget);

		// Close the old zone if it was the only graph inside
		if (nbGraph == 1) {
		parentZoneWidget->close();
trabillard Manage drag&drop of empty graphs	r844	}
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	}
trabillard drop of variables in the visualization	r852	}
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842
trabillard drop of variables in the visualization	r852	void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropZone(
		int index, VisualizationTabWidget *tabWidget)
		{
		auto &helper = sqpApp->dragDropHelper();

		auto zoneWidget = qobject_cast<VisualizationZoneWidget *>(helper.getCurrentDragWidget());
		if (!zoneWidget) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropZone, drop aborted, the dropped zone is not "
		"found or invalid.");
		Q_ASSERT(false);
		return;
		}

		auto parentDragDropContainer
		= qobject_cast<VisualizationDragDropContainer *>(zoneWidget->parentWidget());
		if (!parentDragDropContainer) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropZone, drop aborted, the parent container of "
		"the dropped zone is not found.");
		Q_ASSERT(false);
		return;
trabillard Integrates the drag&drop classes into the existing visualization classes.	r842	}
trabillard drop of variables in the visualization	r852
		// Simple move of the zone, no variable operation associated
		parentDragDropContainer->layout()->removeWidget(zoneWidget);
		tabWidget->ui->dragDropContainer->insertDragWidget(index, zoneWidget);
		}

		void VisualizationTabWidget::VisualizationTabWidgetPrivate::dropVariables(
		const QList<std::shared_ptr<Variable> > &variables, int index,
		VisualizationTabWidget *tabWidget)
		{
trabillard Drag of product	r876	// Note: the AcceptMimeDataFunction (set on the drop container) ensure there is a single and
		// compatible variable here
		if (variables.count() > 1) {
		qCWarning(LOG_VisualizationZoneWidget())
		<< tr("VisualizationTabWidget::dropVariables, dropping multiple variables, operation "
		"aborted.");
		return;
trabillard Drop of product in variables	r877	}
trabillard Drag of product	r876
trabillard drop of variables in the visualization	r852	tabWidget->createZone(variables, index);
Alexandre Leroux Adds scrollbar to tabs	r307	}