##// END OF EJS Templates
Correction for pull request
perrinel -
r227:e94f13bbc48f
parent child
Show More
@@ -1,59 +1,70
1 1 #ifndef SCIQLOP_DATASERIES_H
2 2 #define SCIQLOP_DATASERIES_H
3 3
4 4 #include <Data/ArrayData.h>
5 5 #include <Data/IDataSeries.h>
6 6
7 #include <QLoggingCategory>
8
7 9 #include <memory>
8 10
11
12 Q_DECLARE_LOGGING_CATEGORY(LOG_DataSeries)
13 Q_LOGGING_CATEGORY(LOG_DataSeries, "DataSeries")
14
15
9 16 /**
10 17 * @brief The DataSeries class is the base (abstract) implementation of IDataSeries.
11 18 *
12 19 * It proposes to set a dimension for the values ​​data
13 20 *
14 21 * @tparam Dim The dimension of the values data
15 22 *
16 23 */
17 24 template <int Dim>
18 25 class DataSeries : public IDataSeries {
19 26 public:
20 27 /// @sa IDataSeries::xAxisData()
21 28 std::shared_ptr<ArrayData<1> > xAxisData() override { return m_XAxisData; }
22 29
23 30 /// @sa IDataSeries::xAxisUnit()
24 31 Unit xAxisUnit() const override { return m_XAxisUnit; }
25 32
26 33 /// @return the values dataset
27 34 std::shared_ptr<ArrayData<Dim> > valuesData() const { return m_ValuesData; }
28 35
29 36 /// @sa IDataSeries::valuesUnit()
30 37 Unit valuesUnit() const override { return m_ValuesUnit; }
31 38
32 39 /// @sa IDataSeries::merge()
33 40 void merge(IDataSeries *dataSeries) override
34 41 {
35 42 if (auto dimDataSeries = dynamic_cast<DataSeries<Dim> *>(dataSeries)) {
36 43 m_XAxisData->merge(dimDataSeries->xAxisData().get());
37 44 m_ValuesData->merge(dimDataSeries->valuesData().get());
38 45 }
46 else {
47 qCWarning(LOG_DataSeries())
48 << QObject::tr("Dection of a type of IDataSeries we cannot merge with !");
49 }
39 50 }
40 51
41 52 protected:
42 53 /// Protected ctor (DataSeries is abstract)
43 54 explicit DataSeries(std::shared_ptr<ArrayData<1> > xAxisData, const Unit &xAxisUnit,
44 55 std::shared_ptr<ArrayData<Dim> > valuesData, const Unit &valuesUnit)
45 56 : m_XAxisData{xAxisData},
46 57 m_XAxisUnit{xAxisUnit},
47 58 m_ValuesData{valuesData},
48 59 m_ValuesUnit{valuesUnit}
49 60 {
50 61 }
51 62
52 63 private:
53 64 std::shared_ptr<ArrayData<1> > m_XAxisData;
54 65 Unit m_XAxisUnit;
55 66 std::shared_ptr<ArrayData<Dim> > m_ValuesData;
56 67 Unit m_ValuesUnit;
57 68 };
58 69
59 70 #endif // SCIQLOP_DATASERIES_H
@@ -1,39 +1,39
1 1 #ifndef SCIQLOP_IDATAPROVIDER_H
2 2 #define SCIQLOP_IDATAPROVIDER_H
3 3
4 4 #include <memory>
5 5
6 6 #include <QObject>
7 7
8 8 #include <Data/SqpDateTime.h>
9 9
10 10 class DataProviderParameters;
11 11 class IDataSeries;
12 12
13 13 /**
14 14 * @brief The IDataProvider interface aims to declare a data provider.
15 15 *
16 16 * A data provider is an entity that generates data and returns it according to various parameters
17 17 * (time interval, product to retrieve the data, etc.)
18 18 *
19 19 * @sa IDataSeries
20 20 */
21 21 class IDataProvider : public QObject {
22 22
23 23 Q_OBJECT
24 24 public:
25 25 virtual ~IDataProvider() noexcept = default;
26 26
27 27 virtual std::unique_ptr<IDataSeries>
28 28 retrieveData(const DataProviderParameters &parameters) const = 0;
29 29
30 30
31 31 virtual void requestDataLoading(const QVector<SqpDateTime> &dateTimeList) = 0;
32 32
33 33 signals:
34 void dataProvided(std::shared_ptr<IDataSeries> dateSerie, SqpDateTime dateTime);
34 void dataProvided(std::shared_ptr<IDataSeries> dateSerie, const SqpDateTime &dateTime);
35 35 };
36 36 // Required for using shared_ptr in signals/slots
37 37 Q_DECLARE_METATYPE(std::shared_ptr<IDataProvider>)
38 38
39 39 #endif // SCIQLOP_IDATAPROVIDER_H
@@ -1,54 +1,54
1 1 #ifndef SCIQLOP_VARIABLE_H
2 2 #define SCIQLOP_VARIABLE_H
3 3
4 4 #include <Data/SqpDateTime.h>
5 5
6 6
7 7 #include <QLoggingCategory>
8 8 #include <QObject>
9 9
10 10 #include <Common/spimpl.h>
11 11
12 12 Q_DECLARE_LOGGING_CATEGORY(LOG_Variable)
13 13
14 14 class IDataSeries;
15 15 class QString;
16 16
17 17 /**
18 18 * @brief The Variable class represents a variable in SciQlop.
19 19 */
20 20 class Variable : public QObject {
21 21
22 22 Q_OBJECT
23 23
24 24 public:
25 25 explicit Variable(const QString &name, const QString &unit, const QString &mission,
26 26 const SqpDateTime &dateTime);
27 27
28 28 QString name() const noexcept;
29 29 QString mission() const noexcept;
30 30 QString unit() const noexcept;
31 31 SqpDateTime dateTime() const noexcept;
32 32
33 33 /// @return the data of the variable, nullptr if there is no data
34 34 IDataSeries *dataSeries() const noexcept;
35 35
36 bool contains(SqpDateTime dateTime);
36 bool contains(const SqpDateTime &dateTime);
37 37 void setDataSeries(std::unique_ptr<IDataSeries> dataSeries) noexcept;
38 38
39 39 public slots:
40 40 void onAddDataSeries(std::shared_ptr<IDataSeries> dataSeries) noexcept;
41 41
42 42 signals:
43 43 void dataCacheUpdated();
44 44
45 45
46 46 private:
47 47 class VariablePrivate;
48 48 spimpl::unique_impl_ptr<VariablePrivate> impl;
49 49 };
50 50
51 51 // Required for using shared_ptr in signals/slots
52 52 Q_DECLARE_METATYPE(std::shared_ptr<Variable>)
53 53
54 54 #endif // SCIQLOP_VARIABLE_H
@@ -1,33 +1,33
1 1 #ifndef SCIQLOP_VARIABLECACHECONTROLLER_H
2 2 #define SCIQLOP_VARIABLECACHECONTROLLER_H
3 3
4 4 #include <QObject>
5 5
6 6 #include <Data/SqpDateTime.h>
7 7
8 8 #include <Common/spimpl.h>
9 9
10 10 class Variable;
11 11
12 /// This class aims to store in the cash all of the dateTime already requested to the variable.
12 /// This class aims to store in the cache all of the dateTime already requested to the variable.
13 13 class VariableCacheController : public QObject {
14 14 Q_OBJECT
15 15 public:
16 16 explicit VariableCacheController(QObject *parent = 0);
17 17
18 18
19 19 void addDateTime(std::shared_ptr<Variable> variable, const SqpDateTime &dateTime);
20 20
21 21 /// Return all of the SqpDataTime part of the dateTime whose are not in the cache
22 22 QVector<SqpDateTime> provideNotInCacheDateTimeList(std::shared_ptr<Variable> variable,
23 23 const SqpDateTime &dateTime);
24 24
25 25
26 26 QVector<SqpDateTime> dateCacheList(std::shared_ptr<Variable> variable) const noexcept;
27 27
28 28 private:
29 29 class VariableCacheControllerPrivate;
30 30 spimpl::unique_impl_ptr<VariableCacheControllerPrivate> impl;
31 31 };
32 32
33 33 #endif // SCIQLOP_VARIABLECACHECONTROLLER_H
@@ -1,89 +1,89
1 1 #include "Variable/Variable.h"
2 2
3 3 #include <Data/IDataSeries.h>
4 4 #include <Data/SqpDateTime.h>
5 5
6 6 Q_LOGGING_CATEGORY(LOG_Variable, "Variable")
7 7
8 8 struct Variable::VariablePrivate {
9 9 explicit VariablePrivate(const QString &name, const QString &unit, const QString &mission,
10 10 const SqpDateTime &dateTime)
11 11 : m_Name{name},
12 12 m_Unit{unit},
13 13 m_Mission{mission},
14 14 m_DateTime{dateTime},
15 15 m_DataSeries{nullptr}
16 16 {
17 17 }
18 18
19 19 QString m_Name;
20 20 QString m_Unit;
21 21 QString m_Mission;
22 22
23 23 SqpDateTime m_DateTime; // The dateTime available in the view and loaded. not the cache.
24 24 std::unique_ptr<IDataSeries> m_DataSeries;
25 25 };
26 26
27 27 Variable::Variable(const QString &name, const QString &unit, const QString &mission,
28 28 const SqpDateTime &dateTime)
29 29 : impl{spimpl::make_unique_impl<VariablePrivate>(name, unit, mission, dateTime)}
30 30 {
31 31 }
32 32
33 33 QString Variable::name() const noexcept
34 34 {
35 35 return impl->m_Name;
36 36 }
37 37
38 38 QString Variable::mission() const noexcept
39 39 {
40 40 return impl->m_Mission;
41 41 }
42 42
43 43 QString Variable::unit() const noexcept
44 44 {
45 45 return impl->m_Unit;
46 46 }
47 47
48 48 SqpDateTime Variable::dateTime() const noexcept
49 49 {
50 50 return impl->m_DateTime;
51 51 }
52 52
53 53 void Variable::setDataSeries(std::unique_ptr<IDataSeries> dataSeries) noexcept
54 54 {
55 55 if (!impl->m_DataSeries) {
56 56 impl->m_DataSeries = std::move(dataSeries);
57 57 }
58 58 }
59 59
60 60 void Variable::onAddDataSeries(std::shared_ptr<IDataSeries> dataSeries) noexcept
61 61 {
62 62 if (impl->m_DataSeries) {
63 63 impl->m_DataSeries->merge(dataSeries.get());
64 64
65 65 emit dataCacheUpdated();
66 66 }
67 67 }
68 68
69 69 IDataSeries *Variable::dataSeries() const noexcept
70 70 {
71 71 return impl->m_DataSeries.get();
72 72 }
73 73
74 bool Variable::contains(SqpDateTime dateTime)
74 bool Variable::contains(const SqpDateTime &dateTime)
75 75 {
76 76 if (!impl->m_DateTime.contains(dateTime)) {
77 77 // The current variable dateTime isn't enough to display the dateTime requested.
78 78 // We have to update it to the new dateTime requested.
79 79 // the correspondant new data to display will be given by the cache if possible and the
80 80 // provider if necessary.
81 81 qCInfo(LOG_Variable()) << "NEW DATE NEEDED";
82 82
83 83 impl->m_DateTime = dateTime;
84 84
85 85 return false;
86 86 }
87 87
88 88 return true;
89 89 }
@@ -1,173 +1,170
1 1 #include "Variable/VariableCacheController.h"
2 2
3 3 #include "Variable/Variable.h"
4 4 #include <unordered_map>
5 5
6 6 struct VariableCacheController::VariableCacheControllerPrivate {
7 7
8 8 std::unordered_map<std::shared_ptr<Variable>, QVector<SqpDateTime> >
9 9 m_VariableToSqpDateTimeListMap;
10 10
11 11 void addInCacheDataByEnd(const SqpDateTime &dateTime, QVector<SqpDateTime> &dateTimeList,
12 12 QVector<SqpDateTime> &notInCache, int cacheIndex,
13 13 double currentTStart);
14 14
15 15 void addInCacheDataByStart(const SqpDateTime &dateTime, QVector<SqpDateTime> &dateTimeList,
16 16 QVector<SqpDateTime> &notInCache, int cacheIndex,
17 17 double currentTStart);
18 18
19 19
20 20 void addDateTimeRecurse(const SqpDateTime &dateTime, QVector<SqpDateTime> &dateTimeList,
21 21 int cacheIndex);
22 22 };
23 23
24 24
25 25 VariableCacheController::VariableCacheController(QObject *parent)
26 : QObject(parent), impl{spimpl::make_unique_impl<VariableCacheControllerPrivate>()}
26 : QObject{parent}, impl{spimpl::make_unique_impl<VariableCacheControllerPrivate>()}
27 27 {
28 28 }
29 29
30 30 void VariableCacheController::addDateTime(std::shared_ptr<Variable> variable,
31 31 const SqpDateTime &dateTime)
32 32 {
33 33 if (variable) {
34 34 auto findVariableIte = impl->m_VariableToSqpDateTimeListMap.find(variable);
35 35 if (findVariableIte == impl->m_VariableToSqpDateTimeListMap.end()) {
36 36 impl->m_VariableToSqpDateTimeListMap[variable].push_back(dateTime);
37 37 }
38 38 else {
39 39
40 40 // addDateTime modify the list<SqpDateTime> of the variable in a way to ensure
41 41 // that the list is ordered : l(0) < l(1). We assume also a < b
42 42 // (with a & b of type SqpDateTime) means ts(b) > te(a)
43 43
44 44 // The algorithm will try the merge of two interval:
45 45 // - dateTime will be compare with the first interval of the list:
46 46 // A: if it is inferior, it will be inserted and it's finished.
47 47 // B: if it is in intersection, it will be merge then the merged one
48 48 // will be compared to the next interval. The old one is remove from the list
49 49 // C: if it is superior, we do the same with the next interval of the list
50 50
51 int cacheIndex = 0;
52 51 impl->addDateTimeRecurse(dateTime, impl->m_VariableToSqpDateTimeListMap.at(variable),
53 cacheIndex);
52 0);
54 53 }
55 54 }
56 55 }
57 56
58 57 QVector<SqpDateTime>
59 58 VariableCacheController::provideNotInCacheDateTimeList(std::shared_ptr<Variable> variable,
60 59 const SqpDateTime &dateTime)
61 60 {
62 61 auto notInCache = QVector<SqpDateTime>{};
63 62
64 63 // This algorithm is recursif. The idea is to localise the start time then the end time in the
65 64 // list of date time request associated to the variable
66 65 // We assume that the list is ordered in a way that l(0) < l(1). We assume also a < b
67 66 // (with a & b of type SqpDateTime) means ts(b) > te(a)
68 67
69 68 impl->addInCacheDataByStart(dateTime, impl->m_VariableToSqpDateTimeListMap.at(variable),
70 69 notInCache, 0, dateTime.m_TStart);
71 70
72 71 return notInCache;
73 72 }
74 73
75 74 QVector<SqpDateTime>
76 75 VariableCacheController::dateCacheList(std::shared_ptr<Variable> variable) const noexcept
77 76 {
78 77 return impl->m_VariableToSqpDateTimeListMap.at(variable);
79 78 }
80 79
81 80 void VariableCacheController::VariableCacheControllerPrivate::addDateTimeRecurse(
82 81 const SqpDateTime &dateTime, QVector<SqpDateTime> &dateTimeList, int cacheIndex)
83 82 {
84 83 const auto dateTimeListSize = dateTimeList.count();
85 84 if (cacheIndex >= dateTimeListSize) {
86 85 dateTimeList.push_back(dateTime);
87 86 // there is no anymore interval to compore, we can just push_back it
88 87 return;
89 88 }
90 89
91 90 auto currentDateTime = dateTimeList[cacheIndex];
92 91
93 92 if (dateTime.m_TEnd < currentDateTime.m_TStart) {
94 93 // The compared one is < to current one compared, we can insert it
95 94 dateTimeList.insert(cacheIndex, dateTime);
96 95 }
97
98 96 else if (dateTime.m_TStart > currentDateTime.m_TEnd) {
99 97 // The compared one is > to current one compared we can comparet if to the next one
100 98 addDateTimeRecurse(dateTime, dateTimeList, ++cacheIndex);
101 99 }
102 100 else {
103 101 // Merge cases: we need to merge the two interval, remove the old one from the list then
104 102 // rerun the algo from this index with the merged interval
105 103 auto mTStart = std::min(dateTime.m_TStart, currentDateTime.m_TStart);
106 104 auto mTEnd = std::max(dateTime.m_TEnd, currentDateTime.m_TEnd);
107 105 auto mergeDateTime = SqpDateTime{mTStart, mTEnd};
108 106
109 107 dateTimeList.remove(cacheIndex);
110 108 addDateTimeRecurse(mergeDateTime, dateTimeList, cacheIndex);
111 109 }
112 110 }
113 111
114 112
115 113 void VariableCacheController::VariableCacheControllerPrivate::addInCacheDataByEnd(
116 114 const SqpDateTime &dateTime, QVector<SqpDateTime> &dateTimeList,
117 115 QVector<SqpDateTime> &notInCache, int cacheIndex, double currentTStart)
118 116 {
119 117 const auto dateTimeListSize = dateTimeList.count();
120 118 if (cacheIndex >= dateTimeListSize) {
121 119 if (currentTStart < dateTime.m_TEnd) {
122 120
123 121 // te localised after all other interval: The last interval is [currentTsart, te]
124 122 notInCache.push_back(SqpDateTime{currentTStart, dateTime.m_TEnd});
125 123 }
126 124 return;
127 125 }
128 126
129 127 auto currentDateTimeJ = dateTimeList[cacheIndex];
130 128 if (dateTime.m_TEnd <= currentDateTimeJ.m_TStart) {
131 129 // te localised between to interval: The last interval is [currentTsart, te]
132 130 notInCache.push_back(SqpDateTime{currentTStart, dateTime.m_TEnd});
133 131 }
134 132 else {
135 133 notInCache.push_back(SqpDateTime{currentTStart, currentDateTimeJ.m_TStart});
136 134 if (dateTime.m_TEnd > currentDateTimeJ.m_TEnd) {
137 135 // te not localised before the current interval: we need to look at the next interval
138 136 addInCacheDataByEnd(dateTime, dateTimeList, notInCache, ++cacheIndex,
139 137 currentDateTimeJ.m_TEnd);
140 138 }
141 139 }
142 140 }
143 141
144 142 void VariableCacheController::VariableCacheControllerPrivate::addInCacheDataByStart(
145 143 const SqpDateTime &dateTime, QVector<SqpDateTime> &dateTimeList,
146 144 QVector<SqpDateTime> &notInCache, int cacheIndex, double currentTStart)
147 145 {
148 146 const auto dateTimeListSize = dateTimeList.count();
149 147 if (cacheIndex >= dateTimeListSize) {
150 148 // ts localised after all other interval: The last interval is [ts, te]
151 149 notInCache.push_back(SqpDateTime{currentTStart, dateTime.m_TEnd});
152 150 return;
153 151 }
154 152
155 153 auto currentDateTimeI = dateTimeList[cacheIndex];
156 auto cacheIndexJ = cacheIndex;
157 154 if (currentTStart < currentDateTimeI.m_TStart) {
158 155
159 156 // ts localised between to interval: let's localized te
160 addInCacheDataByEnd(dateTime, dateTimeList, notInCache, cacheIndexJ, currentTStart);
157 addInCacheDataByEnd(dateTime, dateTimeList, notInCache, cacheIndex, currentTStart);
161 158 }
162 159 else if (dateTime.m_TStart < currentDateTimeI.m_TEnd) {
163 160 // ts not localised before the current interval: we need to look at the next interval
164 161 // We can assume now current tstart is the last interval tend, because data between them are
165 162 // in the cache
166 163 addInCacheDataByStart(dateTime, dateTimeList, notInCache, ++cacheIndex,
167 164 currentDateTimeI.m_TEnd);
168 165 }
169 166 else {
170 167 // ts not localised before the current interval: we need to look at the next interval
171 168 addInCacheDataByStart(dateTime, dateTimeList, notInCache, ++cacheIndex, currentTStart);
172 169 }
173 170 }
@@ -1,164 +1,164
1 1 #include <Variable/Variable.h>
2 2 #include <Variable/VariableCacheController.h>
3 3 #include <Variable/VariableController.h>
4 4 #include <Variable/VariableModel.h>
5 5
6 6 #include <Data/DataProviderParameters.h>
7 7 #include <Data/IDataProvider.h>
8 8 #include <Data/IDataSeries.h>
9 9 #include <Time/TimeController.h>
10 10
11 11 #include <QDateTime>
12 12 #include <QElapsedTimer>
13 13 #include <QMutex>
14 14 #include <QThread>
15 15
16 16 #include <unordered_map>
17 17
18 18 Q_LOGGING_CATEGORY(LOG_VariableController, "VariableController")
19 19
20 20 namespace {
21 21
22 22 /// @todo Generates default dataseries, according to the provider passed in parameter. This method
23 23 /// will be deleted when the timerange is recovered from SciQlop
24 24 std::unique_ptr<IDataSeries> generateDefaultDataSeries(const IDataProvider &provider,
25 25 const SqpDateTime &dateTime) noexcept
26 26 {
27 27 auto parameters = DataProviderParameters{dateTime};
28 28
29 29 return provider.retrieveData(parameters);
30 30 }
31 31
32 32 } // namespace
33 33
34 34 struct VariableController::VariableControllerPrivate {
35 35 explicit VariableControllerPrivate(VariableController *parent)
36 36 : m_WorkingMutex{},
37 37 m_VariableModel{new VariableModel{parent}},
38 38 m_VariableCacheController{std::make_unique<VariableCacheController>()}
39 39 {
40 40 }
41 41
42 42 QMutex m_WorkingMutex;
43 43 /// Variable model. The VariableController has the ownership
44 44 VariableModel *m_VariableModel;
45 45
46 46
47 47 TimeController *m_TimeController{nullptr};
48 48 std::unique_ptr<VariableCacheController> m_VariableCacheController;
49 49
50 50 std::unordered_map<std::shared_ptr<Variable>, std::shared_ptr<IDataProvider> >
51 51 m_VariableToProviderMap;
52 52 };
53 53
54 54 VariableController::VariableController(QObject *parent)
55 55 : QObject{parent}, impl{spimpl::make_unique_impl<VariableControllerPrivate>(this)}
56 56 {
57 57 qCDebug(LOG_VariableController()) << tr("VariableController construction")
58 58 << QThread::currentThread();
59 59 }
60 60
61 61 VariableController::~VariableController()
62 62 {
63 63 qCDebug(LOG_VariableController()) << tr("VariableController destruction")
64 64 << QThread::currentThread();
65 65 this->waitForFinish();
66 66 }
67 67
68 68 VariableModel *VariableController::variableModel() noexcept
69 69 {
70 70 return impl->m_VariableModel;
71 71 }
72 72
73 73 void VariableController::setTimeController(TimeController *timeController) noexcept
74 74 {
75 75 impl->m_TimeController = timeController;
76 76 }
77 77
78 78 void VariableController::createVariable(const QString &name,
79 79 std::shared_ptr<IDataProvider> provider) noexcept
80 80 {
81 81
82 82 if (!impl->m_TimeController) {
83 83 qCCritical(LOG_VariableController())
84 84 << tr("Impossible to create variable: The time controller is null");
85 85 return;
86 86 }
87 87
88 88
89 89 /// @todo : for the moment :
90 90 /// - the provider is only used to retrieve data from the variable for its initialization, but
91 91 /// it will be retained later
92 92 /// - default data are generated for the variable, without taking into account the timerange set
93 93 /// in sciqlop
94 94 auto dateTime = impl->m_TimeController->dateTime();
95 95 if (auto newVariable = impl->m_VariableModel->createVariable(
96 96 name, dateTime, generateDefaultDataSeries(*provider, dateTime))) {
97 97
98 98 // store the provider
99 99 impl->m_VariableToProviderMap[newVariable] = provider;
100 100 qRegisterMetaType<std::shared_ptr<IDataSeries> >();
101 101 qRegisterMetaType<SqpDateTime>();
102 102 connect(provider.get(), &IDataProvider::dataProvided, newVariable.get(),
103 103 &Variable::onAddDataSeries);
104 104
105 105
106 106 // store in cache
107 107 impl->m_VariableCacheController->addDateTime(newVariable, dateTime);
108 108
109 109 // notify the creation
110 110 emit variableCreated(newVariable);
111 111 }
112 112 }
113 113
114 114
115 115 void VariableController::requestDataLoading(std::shared_ptr<Variable> variable,
116 116 const SqpDateTime &dateTime)
117 117 {
118 118 // we want to load data of the variable for the dateTime.
119 119 // First we check if the cache contains some of them.
120 120 // For the other, we ask the provider to give them.
121 121 if (variable) {
122 122
123 123 QElapsedTimer timer;
124 124 timer.start();
125 qCInfo(LOG_VariableController()) << "The slow s0 operation took" << timer.elapsed()
125 qCInfo(LOG_VariableController()) << "TORM: The slow s0 operation took" << timer.elapsed()
126 126 << "milliseconds";
127 127 auto dateTimeListNotInCache
128 128 = impl->m_VariableCacheController->provideNotInCacheDateTimeList(variable, dateTime);
129 qCInfo(LOG_VariableController()) << "The slow s1 operation took" << timer.elapsed()
129 qCInfo(LOG_VariableController()) << "TORM: The slow s1 operation took" << timer.elapsed()
130 130 << "milliseconds";
131 131
132 132 // Ask the provider for each data on the dateTimeListNotInCache
133 133 impl->m_VariableToProviderMap.at(variable)->requestDataLoading(dateTimeListNotInCache);
134 134
135 qCInfo(LOG_VariableController()) << "The slow s2 operation took" << timer.elapsed()
135 qCInfo(LOG_VariableController()) << "TORM: The slow s2 operation took" << timer.elapsed()
136 136 << "milliseconds";
137 137
138 138 // store in cache
139 139 impl->m_VariableCacheController->addDateTime(variable, dateTime);
140 qCInfo(LOG_VariableController()) << "The slow s3 operation took" << timer.elapsed()
140 qCInfo(LOG_VariableController()) << "TORM: The slow s3 operation took" << timer.elapsed()
141 141 << "milliseconds";
142 142 }
143 143 else {
144 144 qCCritical(LOG_VariableController()) << tr("Impossible to load data of a variable null");
145 145 }
146 146 }
147 147
148 148
149 149 void VariableController::initialize()
150 150 {
151 151 qCDebug(LOG_VariableController()) << tr("VariableController init") << QThread::currentThread();
152 152 impl->m_WorkingMutex.lock();
153 153 qCDebug(LOG_VariableController()) << tr("VariableController init END");
154 154 }
155 155
156 156 void VariableController::finalize()
157 157 {
158 158 impl->m_WorkingMutex.unlock();
159 159 }
160 160
161 161 void VariableController::waitForFinish()
162 162 {
163 163 QMutexLocker locker{&impl->m_WorkingMutex};
164 164 }
@@ -1,343 +1,343
1 1 #include <Variable/Variable.h>
2 2 #include <Variable/VariableCacheController.h>
3 3
4 4 #include <QObject>
5 5 #include <QtTest>
6 6
7 7 #include <memory>
8 8
9 9 class TestVariableCacheController : public QObject {
10 10 Q_OBJECT
11 11
12 12 private slots:
13 13 void testProvideNotInCacheDateTimeList();
14 14
15 15 void testAddDateTime();
16 16 };
17 17
18 18
19 19 void TestVariableCacheController::testProvideNotInCacheDateTimeList()
20 20 {
21 21 VariableCacheController variableCacheController{};
22 22
23 23 auto ts0 = QDateTime{QDate{2017, 01, 01}, QTime{2, 3, 0, 0}};
24 24 auto te0 = QDateTime{QDate{2017, 01, 01}, QTime{2, 4, 0, 0}};
25 25 auto sqp0 = SqpDateTime{static_cast<double>(ts0.toMSecsSinceEpoch()),
26 26 static_cast<double>(te0.toMSecsSinceEpoch())};
27 27
28 28 auto ts1 = QDateTime{QDate{2017, 01, 01}, QTime{2, 6, 0, 0}};
29 29 auto te1 = QDateTime{QDate{2017, 01, 01}, QTime{2, 8, 0, 0}};
30 30 auto sqp1 = SqpDateTime{static_cast<double>(ts1.toMSecsSinceEpoch()),
31 31 static_cast<double>(te1.toMSecsSinceEpoch())};
32 32
33 33 auto ts2 = QDateTime{QDate{2017, 01, 01}, QTime{2, 18, 0, 0}};
34 34 auto te2 = QDateTime{QDate{2017, 01, 01}, QTime{2, 20, 0, 0}};
35 35 auto sqp2 = SqpDateTime{static_cast<double>(ts2.toMSecsSinceEpoch()),
36 36 static_cast<double>(te2.toMSecsSinceEpoch())};
37 37
38 38 auto var0 = std::make_shared<Variable>("", "", "", sqp0);
39 39
40 40 variableCacheController.addDateTime(var0, sqp0);
41 41 variableCacheController.addDateTime(var0, sqp1);
42 42 variableCacheController.addDateTime(var0, sqp2);
43 43
44 44 // first case [ts,te] < ts0
45 45 auto ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 0, 0, 0}};
46 46 auto te = QDateTime{QDate{2017, 01, 01}, QTime{2, 1, 0, 0}};
47 47 auto sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
48 48 static_cast<double>(te.toMSecsSinceEpoch())};
49 49
50 50
51 51 auto notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
52 52
53 53 QCOMPARE(notInCach.size(), 1);
54 auto notInCashSqp = notInCach.first();
55 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
56 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
54 auto notInCacheSqp = notInCach.first();
55 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
56 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
57 57
58 58
59 59 // second case ts < ts0 && ts0 < te <= te0
60 60 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 0, 0, 0}};
61 61 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 3, 30, 0}};
62 62 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
63 63 static_cast<double>(te.toMSecsSinceEpoch())};
64 64
65 65
66 66 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
67 67
68 68 QCOMPARE(notInCach.size(), 1);
69 notInCashSqp = notInCach.first();
70 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
71 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts0.toMSecsSinceEpoch()));
69 notInCacheSqp = notInCach.first();
70 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
71 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts0.toMSecsSinceEpoch()));
72 72
73 73 // 3th case ts < ts0 && te0 < te <= ts1
74 74 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 0, 0, 0}};
75 75 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 5, 0, 0}};
76 76 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
77 77 static_cast<double>(te.toMSecsSinceEpoch())};
78 78
79 79
80 80 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
81 81
82 82 QCOMPARE(notInCach.size(), 2);
83 notInCashSqp = notInCach.first();
84 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
85 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts0.toMSecsSinceEpoch()));
83 notInCacheSqp = notInCach.first();
84 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
85 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts0.toMSecsSinceEpoch()));
86 86
87 notInCashSqp = notInCach.at(1);
88 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
89 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
87 notInCacheSqp = notInCach.at(1);
88 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
89 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
90 90
91 91 // 4th case ts < ts0 && ts1 < te <= te1
92 92 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 0, 0, 0}};
93 93 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 7, 0, 0}};
94 94 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
95 95 static_cast<double>(te.toMSecsSinceEpoch())};
96 96
97 97
98 98 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
99 99
100 100 QCOMPARE(notInCach.size(), 2);
101 notInCashSqp = notInCach.first();
102 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
103 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts0.toMSecsSinceEpoch()));
101 notInCacheSqp = notInCach.first();
102 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
103 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts0.toMSecsSinceEpoch()));
104 104
105 notInCashSqp = notInCach.at(1);
106 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
107 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
105 notInCacheSqp = notInCach.at(1);
106 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
107 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
108 108
109 109 // 5th case ts < ts0 && te3 < te
110 110 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 0, 0, 0}};
111 111 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 22, 0, 0}};
112 112 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
113 113 static_cast<double>(te.toMSecsSinceEpoch())};
114 114
115 115
116 116 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
117 117
118 118 QCOMPARE(notInCach.size(), 4);
119 notInCashSqp = notInCach.first();
120 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
121 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts0.toMSecsSinceEpoch()));
119 notInCacheSqp = notInCach.first();
120 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
121 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts0.toMSecsSinceEpoch()));
122 122
123 notInCashSqp = notInCach.at(1);
124 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
125 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
123 notInCacheSqp = notInCach.at(1);
124 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
125 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
126 126
127 notInCashSqp = notInCach.at(2);
128 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te1.toMSecsSinceEpoch()));
129 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts2.toMSecsSinceEpoch()));
127 notInCacheSqp = notInCach.at(2);
128 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te1.toMSecsSinceEpoch()));
129 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts2.toMSecsSinceEpoch()));
130 130
131 notInCashSqp = notInCach.at(3);
132 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te2.toMSecsSinceEpoch()));
133 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
131 notInCacheSqp = notInCach.at(3);
132 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te2.toMSecsSinceEpoch()));
133 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
134 134
135 135
136 136 // 6th case ts2 < ts
137 137 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 45, 0, 0}};
138 138 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 47, 0, 0}};
139 139 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
140 140 static_cast<double>(te.toMSecsSinceEpoch())};
141 141
142 142
143 143 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
144 144
145 145 QCOMPARE(notInCach.size(), 1);
146 notInCashSqp = notInCach.first();
147 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
148 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
146 notInCacheSqp = notInCach.first();
147 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
148 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
149 149
150 150 // 7th case ts = te0 && te < ts1
151 151 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 4, 0, 0}};
152 152 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 5, 0, 0}};
153 153 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
154 154 static_cast<double>(te.toMSecsSinceEpoch())};
155 155
156 156
157 157 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
158 158
159 159 QCOMPARE(notInCach.size(), 1);
160 notInCashSqp = notInCach.first();
161 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
162 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
160 notInCacheSqp = notInCach.first();
161 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
162 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
163 163
164 164 // 8th case ts0 < ts < te0 && te < ts1
165 165 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 3, 30, 0}};
166 166 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 5, 0, 0}};
167 167 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
168 168 static_cast<double>(te.toMSecsSinceEpoch())};
169 169
170 170
171 171 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
172 172
173 173 QCOMPARE(notInCach.size(), 1);
174 notInCashSqp = notInCach.first();
175 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
176 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
174 notInCacheSqp = notInCach.first();
175 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
176 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
177 177
178 178 // 9th case ts0 < ts < te0 && ts1 < te < te1
179 179 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 3, 30, 0}};
180 180 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 7, 0, 0}};
181 181 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
182 182 static_cast<double>(te.toMSecsSinceEpoch())};
183 183
184 184
185 185 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
186 186
187 187 QCOMPARE(notInCach.size(), 1);
188 notInCashSqp = notInCach.first();
189 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
190 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
188 notInCacheSqp = notInCach.first();
189 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te0.toMSecsSinceEpoch()));
190 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
191 191
192 192 // 10th case te1 < ts < te < ts2
193 193 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 9, 0, 0}};
194 194 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 10, 0, 0}};
195 195 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
196 196 static_cast<double>(te.toMSecsSinceEpoch())};
197 197
198 198
199 199 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
200 200
201 201 QCOMPARE(notInCach.size(), 1);
202 notInCashSqp = notInCach.first();
203 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
204 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
202 notInCacheSqp = notInCach.first();
203 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
204 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
205 205
206 206 // 11th case te0 < ts < ts1 && te3 < te
207 207 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 5, 0, 0}};
208 208 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 47, 0, 0}};
209 209 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
210 210 static_cast<double>(te.toMSecsSinceEpoch())};
211 211
212 212
213 213 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
214 214
215 215 QCOMPARE(notInCach.size(), 3);
216 notInCashSqp = notInCach.first();
217 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
218 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
216 notInCacheSqp = notInCach.first();
217 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
218 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
219 219
220 notInCashSqp = notInCach.at(1);
221 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te1.toMSecsSinceEpoch()));
222 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts2.toMSecsSinceEpoch()));
220 notInCacheSqp = notInCach.at(1);
221 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te1.toMSecsSinceEpoch()));
222 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts2.toMSecsSinceEpoch()));
223 223
224 notInCashSqp = notInCach.at(2);
225 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te2.toMSecsSinceEpoch()));
226 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
224 notInCacheSqp = notInCach.at(2);
225 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te2.toMSecsSinceEpoch()));
226 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
227 227
228 228 // 12th case te0 < ts < ts1 && te3 < te
229 229 ts = QDateTime{QDate{2017, 01, 01}, QTime{2, 5, 0, 0}};
230 230 te = QDateTime{QDate{2017, 01, 01}, QTime{2, 10, 0, 0}};
231 231 sqp = SqpDateTime{static_cast<double>(ts.toMSecsSinceEpoch()),
232 232 static_cast<double>(te.toMSecsSinceEpoch())};
233 233
234 234 notInCach = variableCacheController.provideNotInCacheDateTimeList(var0, sqp);
235 235
236 236 QCOMPARE(notInCach.size(), 2);
237 notInCashSqp = notInCach.first();
238 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
239 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
237 notInCacheSqp = notInCach.first();
238 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(ts.toMSecsSinceEpoch()));
239 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(ts1.toMSecsSinceEpoch()));
240 240
241 notInCashSqp = notInCach.at(1);
242 QCOMPARE(notInCashSqp.m_TStart, static_cast<double>(te1.toMSecsSinceEpoch()));
243 QCOMPARE(notInCashSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
241 notInCacheSqp = notInCach.at(1);
242 QCOMPARE(notInCacheSqp.m_TStart, static_cast<double>(te1.toMSecsSinceEpoch()));
243 QCOMPARE(notInCacheSqp.m_TEnd, static_cast<double>(te.toMSecsSinceEpoch()));
244 244 }
245 245
246 246
247 247 void TestVariableCacheController::testAddDateTime()
248 248 {
249 249 VariableCacheController variableCacheController{};
250 250
251 251 auto ts0 = QDateTime{QDate{2017, 01, 01}, QTime{2, 3, 0, 0}};
252 252 auto te0 = QDateTime{QDate{2017, 01, 01}, QTime{2, 4, 0, 0}};
253 253 auto sqp0 = SqpDateTime{static_cast<double>(ts0.toMSecsSinceEpoch()),
254 254 static_cast<double>(te0.toMSecsSinceEpoch())};
255 255
256 256 auto ts1 = QDateTime{QDate{2017, 01, 01}, QTime{2, 6, 0, 0}};
257 257 auto te1 = QDateTime{QDate{2017, 01, 01}, QTime{2, 8, 0, 0}};
258 258 auto sqp1 = SqpDateTime{static_cast<double>(ts1.toMSecsSinceEpoch()),
259 259 static_cast<double>(te1.toMSecsSinceEpoch())};
260 260
261 261 auto ts2 = QDateTime{QDate{2017, 01, 01}, QTime{2, 18, 0, 0}};
262 262 auto te2 = QDateTime{QDate{2017, 01, 01}, QTime{2, 20, 0, 0}};
263 263 auto sqp2 = SqpDateTime{static_cast<double>(ts2.toMSecsSinceEpoch()),
264 264 static_cast<double>(te2.toMSecsSinceEpoch())};
265 265
266 266 auto ts01 = QDateTime{QDate{2017, 01, 01}, QTime{2, 4, 0, 0}};
267 267 auto te01 = QDateTime{QDate{2017, 01, 01}, QTime{2, 6, 0, 0}};
268 268 auto sqp01 = SqpDateTime{static_cast<double>(ts01.toMSecsSinceEpoch()),
269 269 static_cast<double>(te01.toMSecsSinceEpoch())};
270 270
271 271 auto ts3 = QDateTime{QDate{2017, 01, 01}, QTime{2, 14, 0, 0}};
272 272 auto te3 = QDateTime{QDate{2017, 01, 01}, QTime{2, 16, 0, 0}};
273 273 auto sqp3 = SqpDateTime{static_cast<double>(ts3.toMSecsSinceEpoch()),
274 274 static_cast<double>(te3.toMSecsSinceEpoch())};
275 275
276 276 auto ts03 = QDateTime{QDate{2017, 01, 01}, QTime{2, 4, 0, 0}};
277 277 auto te03 = QDateTime{QDate{2017, 01, 01}, QTime{2, 22, 0, 0}};
278 278 auto sqp03 = SqpDateTime{static_cast<double>(ts03.toMSecsSinceEpoch()),
279 279 static_cast<double>(te03.toMSecsSinceEpoch())};
280 280
281 281
282 282 auto var0 = std::make_shared<Variable>("", "", "", sqp0);
283 283
284 284
285 285 // First case: add the first interval to the variable :sqp0
286 286 variableCacheController.addDateTime(var0, sqp0);
287 287 auto dateCacheList = variableCacheController.dateCacheList(var0);
288 288 QCOMPARE(dateCacheList.count(), 1);
289 289 auto dateCache = dateCacheList.at(0);
290 290 QCOMPARE(dateCache.m_TStart, static_cast<double>(ts0.toMSecsSinceEpoch()));
291 291 QCOMPARE(dateCache.m_TEnd, static_cast<double>(te0.toMSecsSinceEpoch()));
292 292
293 293 // 2nd case: add a second interval : sqp1 > sqp0
294 294 variableCacheController.addDateTime(var0, sqp1);
295 295 dateCacheList = variableCacheController.dateCacheList(var0);
296 296 QCOMPARE(dateCacheList.count(), 2);
297 297 dateCache = dateCacheList.at(0);
298 298 QCOMPARE(dateCache.m_TStart, static_cast<double>(ts0.toMSecsSinceEpoch()));
299 299 QCOMPARE(dateCache.m_TEnd, static_cast<double>(te0.toMSecsSinceEpoch()));
300 300
301 301 dateCache = dateCacheList.at(1);
302 302 QCOMPARE(dateCache.m_TStart, static_cast<double>(ts1.toMSecsSinceEpoch()));
303 303 QCOMPARE(dateCache.m_TEnd, static_cast<double>(te1.toMSecsSinceEpoch()));
304 304
305 305 // 3th case: merge sqp0 & sqp1 with sqp01
306 306 variableCacheController.addDateTime(var0, sqp01);
307 307 dateCacheList = variableCacheController.dateCacheList(var0);
308 308 QCOMPARE(dateCacheList.count(), 1);
309 309 dateCache = dateCacheList.at(0);
310 310 QCOMPARE(dateCache.m_TStart, static_cast<double>(ts0.toMSecsSinceEpoch()));
311 311 QCOMPARE(dateCache.m_TEnd, static_cast<double>(te1.toMSecsSinceEpoch()));
312 312
313 313
314 314 // 4th case: add a second interval : sqp1 > sqp0
315 315 variableCacheController.addDateTime(var0, sqp2);
316 316 variableCacheController.addDateTime(var0, sqp3);
317 317 dateCacheList = variableCacheController.dateCacheList(var0);
318 318 QCOMPARE(dateCacheList.count(), 3);
319 319 dateCache = dateCacheList.at(0);
320 320 QCOMPARE(dateCache.m_TStart, static_cast<double>(ts0.toMSecsSinceEpoch()));
321 321 QCOMPARE(dateCache.m_TEnd, static_cast<double>(te1.toMSecsSinceEpoch()));
322 322
323 323 dateCache = dateCacheList.at(1);
324 324 QCOMPARE(dateCache.m_TStart, static_cast<double>(ts3.toMSecsSinceEpoch()));
325 325 QCOMPARE(dateCache.m_TEnd, static_cast<double>(te3.toMSecsSinceEpoch()));
326 326
327 327 dateCache = dateCacheList.at(2);
328 328 QCOMPARE(dateCache.m_TStart, static_cast<double>(ts2.toMSecsSinceEpoch()));
329 329 QCOMPARE(dateCache.m_TEnd, static_cast<double>(te2.toMSecsSinceEpoch()));
330 330
331 331
332 332 // 5th case: merge all interval
333 333 variableCacheController.addDateTime(var0, sqp03);
334 334 dateCacheList = variableCacheController.dateCacheList(var0);
335 335 QCOMPARE(dateCacheList.count(), 1);
336 336 dateCache = dateCacheList.at(0);
337 337 QCOMPARE(dateCache.m_TStart, static_cast<double>(ts0.toMSecsSinceEpoch()));
338 338 QCOMPARE(dateCache.m_TEnd, static_cast<double>(te03.toMSecsSinceEpoch()));
339 339 }
340 340
341 341
342 342 QTEST_MAIN(TestVariableCacheController)
343 343 #include "TestVariableCacheController.moc"
@@ -1,38 +1,38
1 #ifndef SCIQLOP_GRAPHPLOTTABLESFACTORY_H
2 #define SCIQLOP_GRAPHPLOTTABLESFACTORY_H
1 #ifndef SCIQLOP_VISUALIZATIONGRAPHHELPER_H
2 #define SCIQLOP_VISUALIZATIONGRAPHHELPER_H
3 3
4 4 #include <Data/SqpDateTime.h>
5 5
6 6 #include <QLoggingCategory>
7 7 #include <QVector>
8 8
9 9 #include <memory>
10 10
11 Q_DECLARE_LOGGING_CATEGORY(LOG_GraphPlottablesFactory)
11 Q_DECLARE_LOGGING_CATEGORY(LOG_VisualizationGraphHelper)
12 12
13 13 class IDataSeries;
14 14 class QCPAbstractPlottable;
15 15 class QCustomPlot;
16 16 class Variable;
17 17
18 18 /**
19 * @brief The GraphPlottablesFactory class aims to create the QCustomPlot components relative to a
19 * @brief The VisualizationGraphHelper class aims to create the QCustomPlot components relative to a
20 20 * variable, depending on the data series of this variable
21 21 */
22 struct GraphPlottablesFactory {
22 struct VisualizationGraphHelper {
23 23 /**
24 24 * Creates (if possible) the QCustomPlot components relative to the variable passed in
25 25 * parameter, and adds these to the plot passed in parameter.
26 26 * @param variable the variable for which to create the components
27 27 * @param plot the plot in which to add the created components. It takes ownership of these
28 28 * components.
29 29 * @return the list of the components created
30 30 */
31 31 static QVector<QCPAbstractPlottable *> create(std::shared_ptr<Variable> variable,
32 32 QCustomPlot &plot) noexcept;
33 33
34 34 static void updateData(QVector<QCPAbstractPlottable *> plotableVect, IDataSeries *dataSeries,
35 35 const SqpDateTime &dateTime);
36 36 };
37 37
38 #endif // SCIQLOP_GRAPHPLOTTABLESFACTORY_H
38 #endif // SCIQLOP_VISUALIZATIONGRAPHHELPER_H
@@ -1,151 +1,151
1 #include "Visualization/GraphPlottablesFactory.h"
1 #include "Visualization/VisualizationGraphHelper.h"
2 2 #include "Visualization/qcustomplot.h"
3 3
4 4 #include <Data/ScalarSeries.h>
5 5
6 6 #include <Variable/Variable.h>
7 7
8 8 #include <QElapsedTimer>
9 9
10 Q_LOGGING_CATEGORY(LOG_GraphPlottablesFactory, "GraphPlottablesFactory")
10 Q_LOGGING_CATEGORY(LOG_VisualizationGraphHelper, "VisualizationGraphHelper")
11 11
12 12 namespace {
13 13
14 14 /// Format for datetimes on a axis
15 15 const auto DATETIME_TICKER_FORMAT = QStringLiteral("yyyy/MM/dd \nhh:mm:ss");
16 16
17 17 /// Generates the appropriate ticker for an axis, depending on whether the axis displays time or
18 18 /// non-time data
19 19 QSharedPointer<QCPAxisTicker> axisTicker(bool isTimeAxis)
20 20 {
21 21 if (isTimeAxis) {
22 22 auto dateTicker = QSharedPointer<QCPAxisTickerDateTime>::create();
23 23 dateTicker->setDateTimeFormat(DATETIME_TICKER_FORMAT);
24 24
25 25 return dateTicker;
26 26 }
27 27 else {
28 28 // default ticker
29 29 return QSharedPointer<QCPAxisTicker>::create();
30 30 }
31 31 }
32 32
33 33 void updateScalarData(QCPAbstractPlottable *component, ScalarSeries &scalarSeries,
34 34 const SqpDateTime &dateTime)
35 35 {
36 36 QElapsedTimer timer;
37 37 timer.start();
38 38 if (auto qcpGraph = dynamic_cast<QCPGraph *>(component)) {
39 39 // Clean the graph
40 qCDebug(LOG_GraphPlottablesFactory()) << "The slow s1 operation took" << timer.elapsed()
41 << "milliseconds";
40 qCDebug(LOG_VisualizationGraphHelper()) << "The slow s1 operation took" << timer.elapsed()
41 << "milliseconds";
42 42 // NAIVE approch
43 43 const auto &xData = scalarSeries.xAxisData()->data();
44 44 const auto &valuesData = scalarSeries.valuesData()->data();
45 45
46 46 auto xValue = QVector<double>();
47 47 auto vValue = QVector<double>();
48 48
49 49 const auto count = xData.count();
50 50 auto ite = 0;
51 51 for (auto i = 0; i < count; ++i) {
52 52 const auto x = xData.at(i);
53 53 if (x >= dateTime.m_TStart && x <= dateTime.m_TEnd) {
54 54 xValue.push_back(x);
55 55 vValue.push_back(valuesData.at(i));
56 56 ++ite;
57 57 }
58 58 }
59 59
60 60 qcpGraph->setData(xValue, vValue);
61 61
62 qCDebug(LOG_GraphPlottablesFactory()) << "The slow s2 operation took" << timer.elapsed()
63 << "milliseconds";
62 qCDebug(LOG_VisualizationGraphHelper()) << "The slow s2 operation took" << timer.elapsed()
63 << "milliseconds";
64 64 }
65 65 else {
66 66 /// @todo DEBUG
67 67 }
68 68 }
69 69
70 70 QCPAbstractPlottable *createScalarSeriesComponent(ScalarSeries &scalarSeries, QCustomPlot &plot,
71 71 const SqpDateTime &dateTime)
72 72 {
73 73 auto component = plot.addGraph();
74 74
75 75 if (component) {
76 76 // // Graph data
77 77 component->setData(scalarSeries.xAxisData()->data(), scalarSeries.valuesData()->data(),
78 78 true);
79 79
80 80 updateScalarData(component, scalarSeries, dateTime);
81 81
82 82 // Axes properties
83 83 /// @todo : for the moment, no control is performed on the axes: the units and the tickers
84 84 /// are fixed for the default x-axis and y-axis of the plot, and according to the new graph
85 85
86 86 auto setAxisProperties = [](auto axis, const auto &unit) {
87 87 // label (unit name)
88 88 axis->setLabel(unit.m_Name);
89 89
90 90 // ticker (depending on the type of unit)
91 91 axis->setTicker(axisTicker(unit.m_TimeUnit));
92 92 };
93 93 setAxisProperties(plot.xAxis, scalarSeries.xAxisUnit());
94 94 setAxisProperties(plot.yAxis, scalarSeries.valuesUnit());
95 95
96 96 // Display all data
97 97 component->rescaleAxes();
98 98
99 99 plot.replot();
100 100 }
101 101 else {
102 qCDebug(LOG_GraphPlottablesFactory())
102 qCDebug(LOG_VisualizationGraphHelper())
103 103 << QObject::tr("Can't create graph for the scalar series");
104 104 }
105 105
106 106 return component;
107 107 }
108 108
109 109 } // namespace
110 110
111 QVector<QCPAbstractPlottable *> GraphPlottablesFactory::create(std::shared_ptr<Variable> variable,
112 QCustomPlot &plot) noexcept
111 QVector<QCPAbstractPlottable *> VisualizationGraphHelper::create(std::shared_ptr<Variable> variable,
112 QCustomPlot &plot) noexcept
113 113 {
114 114 auto result = QVector<QCPAbstractPlottable *>{};
115 115
116 116 if (variable) {
117 117 // Gets the data series of the variable to call the creation of the right components
118 118 // according to its type
119 119 if (auto scalarSeries = dynamic_cast<ScalarSeries *>(variable->dataSeries())) {
120 120 result.append(createScalarSeriesComponent(*scalarSeries, plot, variable->dateTime()));
121 121 }
122 122 else {
123 qCDebug(LOG_GraphPlottablesFactory())
123 qCDebug(LOG_VisualizationGraphHelper())
124 124 << QObject::tr("Can't create graph plottables : unmanaged data series type");
125 125 }
126 126 }
127 127 else {
128 qCDebug(LOG_GraphPlottablesFactory())
128 qCDebug(LOG_VisualizationGraphHelper())
129 129 << QObject::tr("Can't create graph plottables : the variable is null");
130 130 }
131 131
132 132 return result;
133 133 }
134 134
135 void GraphPlottablesFactory::updateData(QVector<QCPAbstractPlottable *> plotableVect,
136 IDataSeries *dataSeries, const SqpDateTime &dateTime)
135 void VisualizationGraphHelper::updateData(QVector<QCPAbstractPlottable *> plotableVect,
136 IDataSeries *dataSeries, const SqpDateTime &dateTime)
137 137 {
138 138 if (auto scalarSeries = dynamic_cast<ScalarSeries *>(dataSeries)) {
139 139 if (plotableVect.size() == 1) {
140 140 updateScalarData(plotableVect.at(0), *scalarSeries, dateTime);
141 141 }
142 142 else {
143 qCCritical(LOG_GraphPlottablesFactory()) << QObject::tr(
143 qCCritical(LOG_VisualizationGraphHelper()) << QObject::tr(
144 144 "Can't update Data of a scalarSeries because there is not only one component "
145 145 "associated");
146 146 }
147 147 }
148 148 else {
149 149 /// @todo DEBUG
150 150 }
151 151 }
@@ -1,165 +1,173
1 1 #include "Visualization/VisualizationGraphWidget.h"
2 #include "Visualization/GraphPlottablesFactory.h"
3 2 #include "Visualization/IVisualizationWidgetVisitor.h"
3 #include "Visualization/VisualizationGraphHelper.h"
4 4 #include "ui_VisualizationGraphWidget.h"
5 5
6 6 #include <Data/ArrayData.h>
7 7 #include <Data/IDataSeries.h>
8 8 #include <SqpApplication.h>
9 9 #include <Variable/Variable.h>
10 10 #include <Variable/VariableController.h>
11 11
12 12 #include <unordered_map>
13 13
14 14 Q_LOGGING_CATEGORY(LOG_VisualizationGraphWidget, "VisualizationGraphWidget")
15 15
16 16 namespace {
17 17
18 18 /// Key pressed to enable zoom on horizontal axis
19 19 const auto HORIZONTAL_ZOOM_MODIFIER = Qt::NoModifier;
20 20
21 21 /// Key pressed to enable zoom on vertical axis
22 22 const auto VERTICAL_ZOOM_MODIFIER = Qt::ControlModifier;
23 23
24 24 } // namespace
25 25
26 26 struct VisualizationGraphWidget::VisualizationGraphWidgetPrivate {
27 27
28 28 // 1 variable -> n qcpplot
29 29 std::unordered_multimap<std::shared_ptr<Variable>, QCPAbstractPlottable *>
30 30 m_VariableToPlotMultiMap;
31 31 };
32 32
33 33 VisualizationGraphWidget::VisualizationGraphWidget(const QString &name, QWidget *parent)
34 34 : QWidget{parent},
35 35 ui{new Ui::VisualizationGraphWidget},
36 36 impl{spimpl::make_unique_impl<VisualizationGraphWidgetPrivate>()}
37 37 {
38 38 ui->setupUi(this);
39 39
40 40 // qcpplot title
41 41 ui->widget->plotLayout()->insertRow(0);
42 42 ui->widget->plotLayout()->addElement(0, 0, new QCPTextElement{ui->widget, name});
43 43
44 44 // Set qcpplot properties :
45 45 // - Drag (on x-axis) and zoom are enabled
46 46 // - Mouse wheel on qcpplot is intercepted to determine the zoom orientation
47 47 ui->widget->setInteractions(QCP::iRangeDrag | QCP::iRangeZoom);
48 48 ui->widget->axisRect()->setRangeDrag(Qt::Horizontal);
49 49 connect(ui->widget, &QCustomPlot::mouseWheel, this, &VisualizationGraphWidget::onMouseWheel);
50 50 connect(ui->widget->xAxis, static_cast<void (QCPAxis::*)(const QCPRange &, const QCPRange &)>(
51 51 &QCPAxis::rangeChanged),
52 52 this, &VisualizationGraphWidget::onRangeChanged);
53 53 }
54 54
55 55
56 56 VisualizationGraphWidget::~VisualizationGraphWidget()
57 57 {
58 58 delete ui;
59 59 }
60 60
61 61 void VisualizationGraphWidget::addVariable(std::shared_ptr<Variable> variable)
62 62 {
63 63 // Uses delegate to create the qcpplot components according to the variable
64 auto createdPlottables = GraphPlottablesFactory::create(variable, *ui->widget);
64 auto createdPlottables = VisualizationGraphHelper::create(variable, *ui->widget);
65 65
66 66 for (auto createdPlottable : qAsConst(createdPlottables)) {
67 67 impl->m_VariableToPlotMultiMap.insert({variable, createdPlottable});
68 68 }
69 69
70 70 connect(variable.get(), SIGNAL(dataCacheUpdated()), this, SLOT(onDataCacheVariableUpdated()));
71 71 }
72 72
73 73 void VisualizationGraphWidget::accept(IVisualizationWidgetVisitor *visitor)
74 74 {
75 75 if (visitor) {
76 76 visitor->visit(this);
77 77 }
78 78 else {
79 79 qCCritical(LOG_VisualizationGraphWidget())
80 80 << tr("Can't visit widget : the visitor is null");
81 81 }
82 82 }
83 83
84 84 bool VisualizationGraphWidget::canDrop(const Variable &variable) const
85 85 {
86 86 /// @todo : for the moment, a graph can always accomodate a variable
87 87 Q_UNUSED(variable);
88 88 return true;
89 89 }
90 90
91 91 void VisualizationGraphWidget::close()
92 92 {
93 93 // The main view cannot be directly closed.
94 94 return;
95 95 }
96 96
97 97 QString VisualizationGraphWidget::name() const
98 98 {
99 99 if (auto title = dynamic_cast<QCPTextElement *>(ui->widget->plotLayout()->elementAt(0))) {
100 100 return title->text();
101 101 }
102 102 else {
103 103 return QString{};
104 104 }
105 105 }
106 106
107 107 void VisualizationGraphWidget::onRangeChanged(const QCPRange &t1, const QCPRange &t2)
108 108 {
109 109
110 110 qCDebug(LOG_VisualizationGraphWidget()) << tr("VisualizationGraphWidget::onRangeChanged");
111 111
112 112 for (auto it = impl->m_VariableToPlotMultiMap.cbegin();
113 113 it != impl->m_VariableToPlotMultiMap.cend(); ++it) {
114 114 auto variable = it->first;
115 115 auto tolerance = 0.1 * (t2.upper - t2.lower);
116 116 auto dateTime = SqpDateTime{t2.lower - tolerance, t2.upper + tolerance};
117 117
118 118 qCInfo(LOG_VisualizationGraphWidget()) << tr("VisualizationGraphWidget::onRangeChanged")
119 119 << variable->dataSeries()->xAxisData()->size();
120 120 if (!variable->contains(dateTime)) {
121 121 sqpApp->variableController().requestDataLoading(variable, dateTime);
122 122 }
123 123 }
124 124 }
125 125
126 126 void VisualizationGraphWidget::onMouseWheel(QWheelEvent *event) noexcept
127 127 {
128 128 auto zoomOrientations = QFlags<Qt::Orientation>{};
129 129
130 130 // Lambda that enables a zoom orientation if the key modifier related to this orientation has
131 131 // been pressed
132 132 auto enableOrientation
133 133 = [&zoomOrientations, event](const auto &orientation, const auto &modifier) {
134 134 auto orientationEnabled = event->modifiers().testFlag(modifier);
135 135 zoomOrientations.setFlag(orientation, orientationEnabled);
136 136 };
137 137 enableOrientation(Qt::Vertical, VERTICAL_ZOOM_MODIFIER);
138 138 enableOrientation(Qt::Horizontal, HORIZONTAL_ZOOM_MODIFIER);
139 139
140 140 ui->widget->axisRect()->setRangeZoom(zoomOrientations);
141 141 }
142 142
143 143 void VisualizationGraphWidget::onDataCacheVariableUpdated()
144 144 {
145 // NOTE:
146 // We don't want to call the method for each component of a variable unitarily, but for all
147 // its components at once (eg its three components in the case of a vector).
148
149 // The unordered_multimap does not do this easily, so the question is whether to:
150 // - use an ordered_multimap and the algos of std to group the values by key
151 // - use a map (unique keys) and store as values directly the list of components
152
145 153 for (auto it = impl->m_VariableToPlotMultiMap.cbegin();
146 154 it != impl->m_VariableToPlotMultiMap.cend(); ++it) {
147 155 auto variable = it->first;
148 GraphPlottablesFactory::updateData(QVector<QCPAbstractPlottable *>{} << it->second,
149 variable->dataSeries(), variable->dateTime());
156 VisualizationGraphHelper::updateData(QVector<QCPAbstractPlottable *>{} << it->second,
157 variable->dataSeries(), variable->dateTime());
150 158 }
151 159 }
152 160
153 161 void VisualizationGraphWidget::updateDisplay(std::shared_ptr<Variable> variable)
154 162 {
155 163 auto abstractPlotableItPair = impl->m_VariableToPlotMultiMap.equal_range(variable);
156 164
157 165 auto abstractPlotableVect = QVector<QCPAbstractPlottable *>{};
158 166
159 167 for (auto it = abstractPlotableItPair.first; it != abstractPlotableItPair.second; ++it) {
160 168 abstractPlotableVect.push_back(it->second);
161 169 }
162 170
163 GraphPlottablesFactory::updateData(abstractPlotableVect, variable->dataSeries(),
164 variable->dateTime());
171 VisualizationGraphHelper::updateData(abstractPlotableVect, variable->dataSeries(),
172 variable->dateTime());
165 173 }
@@ -1,71 +1,71
1 1 #include "CosinusProvider.h"
2 2
3 3 #include <Data/DataProviderParameters.h>
4 4 #include <Data/ScalarSeries.h>
5 5
6 6 #include <cmath>
7 7
8 8 Q_LOGGING_CATEGORY(LOG_CosinusProvider, "CosinusProvider")
9 9
10 10 std::unique_ptr<IDataSeries>
11 11 CosinusProvider::retrieveData(const DataProviderParameters &parameters) const
12 12 {
13 13 auto dateTime = parameters.m_Time;
14 14
15 15 // Gets the timerange from the parameters
16 16 auto start = dateTime.m_TStart;
17 17 auto end = dateTime.m_TEnd;
18 18
19 19 // We assure that timerange is valid
20 20 if (end < start) {
21 21 std::swap(start, end);
22 22 }
23 23
24 24 // Generates scalar series containing cosinus values (one value per second)
25 25 auto scalarSeries
26 26 = std::make_unique<ScalarSeries>(end - start, Unit{QStringLiteral("t"), true}, Unit{});
27 27
28 28 auto dataIndex = 0;
29 29 for (auto time = start; time < end; ++time, ++dataIndex) {
30 30 scalarSeries->setData(dataIndex, time, std::cos(time));
31 31 }
32 32
33 33 return scalarSeries;
34 34 }
35 35
36 36 void CosinusProvider::requestDataLoading(const QVector<SqpDateTime> &dateTimeList)
37 37 {
38 38 // NOTE: Try to use multithread if possible
39 foreach (const auto &dateTime, dateTimeList) {
39 for (const auto &dateTime : dateTimeList) {
40 40
41 41 auto scalarSeries = this->retrieveDataSeries(dateTime);
42 42
43 43 emit dataProvided(scalarSeries, dateTime);
44 44 }
45 45 }
46 46
47 47
48 48 std::shared_ptr<IDataSeries> CosinusProvider::retrieveDataSeries(const SqpDateTime &dateTime)
49 49 {
50 50
51 51 // Gets the timerange from the parameters
52 52 auto start = dateTime.m_TStart;
53 53 auto end = dateTime.m_TEnd;
54 54
55 55 // We assure that timerange is valid
56 56 if (end < start) {
57 57 std::swap(start, end);
58 58 }
59 59
60 60 // Generates scalar series containing cosinus values (one value per second)
61 61 auto scalarSeries
62 62 = std::make_shared<ScalarSeries>(end - start, Unit{QStringLiteral("t"), true}, Unit{});
63 63
64 64 auto dataIndex = 0;
65 65 for (auto time = start; time < end; ++time, ++dataIndex) {
66 66 scalarSeries->setData(dataIndex, time, std::cos(time));
67 67 }
68 68
69 69
70 70 return scalarSeries;
71 71 }
General Comments 0
You need to be logged in to leave comments. Login now