Auto status change to "Under Review"
@@ -19,7 +19,7 | |||
|
19 | 19 | /*-- Author : Alexis Jeandet |
|
20 | 20 | -- Mail : alexis.jeandet@member.fsf.org |
|
21 | 21 | ----------------------------------------------------------------------------*/ |
|
22 |
#include " |
|
|
22 | #include "MainWindow.h" | |
|
23 | 23 | #include <QProcessEnvironment> |
|
24 | 24 | #include <QThread> |
|
25 | 25 | #include <SqpApplication.h> |
@@ -97,8 +97,10 IF(BUILD_TESTS) | |||
|
97 | 97 | |
|
98 | 98 | SCIQLOP_COPY_TO_TARGET(RUNTIME ${testName} ${EXTERN_SHARED_LIBRARIES}) |
|
99 | 99 | set(Coverage_NAME ${testName}) |
|
100 | SETUP_TARGET_FOR_COVERAGE(TARGET ${testName}_coverage OUTPUT ${testFile}-path NAME ${testFile} EXECUTABLE ${testName}) | |
|
101 | LIST( APPEND TARGETS_COV ${testName}_coverage) | |
|
100 | if(UNIX) | |
|
101 | SETUP_TARGET_FOR_COVERAGE(TARGET ${testName}_coverage OUTPUT ${testFile}-path NAME ${testFile} EXECUTABLE ${testName}) | |
|
102 | LIST( APPEND TARGETS_COV ${testName}_coverage) | |
|
103 | endif(UNIX) | |
|
102 | 104 | |
|
103 | 105 | ENDFOREACH( testFile ) |
|
104 | 106 |
@@ -89,9 +89,8 using default_copier_t = typename default_copier<T>::type; | |||
|
89 | 89 | |
|
90 | 90 | template <class T, class D, class C> |
|
91 | 91 | struct is_default_manageable |
|
92 | : public std::integral_constant<bool, | |
|
93 |
std::is_same< |
|
|
94 | && std::is_same<C, default_copier_t<T> >::value> { | |
|
92 | : public std::integral_constant<bool, std::is_same<D, default_deleter_t<T> >::value | |
|
93 | && std::is_same<C, default_copier_t<T> >::value> { | |
|
95 | 94 | }; |
|
96 | 95 | } |
|
97 | 96 | |
@@ -132,11 +131,10 public: | |||
|
132 | 131 | } |
|
133 | 132 | |
|
134 | 133 | template <class U> |
|
135 | impl_ptr(U *u, | |
|
136 | typename std::enable_if<std::is_convertible<U *, pointer>::value | |
|
137 |
|
|
|
138 | dummy_t_>::type | |
|
139 | = dummy_t_()) SPIMPL_NOEXCEPT | |
|
134 | impl_ptr(U *u, typename std::enable_if<std::is_convertible<U *, pointer>::value | |
|
135 | && is_default_manageable::value, | |
|
136 | dummy_t_>::type | |
|
137 | = dummy_t_()) SPIMPL_NOEXCEPT | |
|
140 | 138 | : impl_ptr(u, &details::default_delete<T>, &details::default_copy<T>) |
|
141 | 139 | { |
|
142 | 140 | } |
@@ -153,12 +151,12 public: | |||
|
153 | 151 | |
|
154 | 152 | #ifdef SPIMPL_HAS_AUTO_PTR |
|
155 | 153 | template <class U> |
|
156 | impl_ptr(std::auto_ptr<U> &&u, | |
|
157 | typename std::enable_if<std::is_convertible<U *, pointer>::value | |
|
158 |
|
|
|
159 |
|
|
|
160 |
|
|
|
161 |
|
|
|
154 | impl_ptr(std::auto_ptr<U> &&u, typename std::enable_if<std::is_convertible<U *, pointer>::value | |
|
155 | && is_default_manageable::value, | |
|
156 | dummy_t_>::type | |
|
157 | = dummy_t_()) SPIMPL_NOEXCEPT | |
|
158 | : ptr_(u.release(), &details::default_delete<T>), | |
|
159 | copier_(&details::default_copy<T>) | |
|
162 | 160 | { |
|
163 | 161 | } |
|
164 | 162 | #endif |
@@ -21,14 +21,14 public: | |||
|
21 | 21 | DataSourceController::DataSourceController(QObject *parent) |
|
22 | 22 | : impl{spimpl::make_unique_impl<DataSourceControllerPrivate>()} |
|
23 | 23 | { |
|
24 | qCDebug(LOG_DataSourceController()) | |
|
25 | << tr("DataSourceController construction") << QThread::currentThread(); | |
|
24 | qCDebug(LOG_DataSourceController()) << tr("DataSourceController construction") | |
|
25 | << QThread::currentThread(); | |
|
26 | 26 | } |
|
27 | 27 | |
|
28 | 28 | DataSourceController::~DataSourceController() |
|
29 | 29 | { |
|
30 | qCDebug(LOG_DataSourceController()) | |
|
31 | << tr("DataSourceController destruction") << QThread::currentThread(); | |
|
30 | qCDebug(LOG_DataSourceController()) << tr("DataSourceController destruction") | |
|
31 | << QThread::currentThread(); | |
|
32 | 32 | this->waitForFinish(); |
|
33 | 33 | } |
|
34 | 34 | |
@@ -61,8 +61,8 void DataSourceController::setDataSourceItem( | |||
|
61 | 61 | |
|
62 | 62 | void DataSourceController::initialize() |
|
63 | 63 | { |
|
64 | qCDebug(LOG_DataSourceController()) | |
|
65 | << tr("DataSourceController init") << QThread::currentThread(); | |
|
64 | qCDebug(LOG_DataSourceController()) << tr("DataSourceController init") | |
|
65 | << QThread::currentThread(); | |
|
66 | 66 | impl->m_WorkingMutex.lock(); |
|
67 | 67 | qCDebug(LOG_DataSourceController()) << tr("DataSourceController init END"); |
|
68 | 68 | } |
@@ -16,21 +16,21 public: | |||
|
16 | 16 | VisualizationController::VisualizationController(QObject *parent) |
|
17 | 17 | : impl{spimpl::make_unique_impl<VisualizationControllerPrivate>()} |
|
18 | 18 | { |
|
19 | qCDebug(LOG_VisualizationController()) | |
|
20 | << tr("VisualizationController construction") << QThread::currentThread(); | |
|
19 | qCDebug(LOG_VisualizationController()) << tr("VisualizationController construction") | |
|
20 | << QThread::currentThread(); | |
|
21 | 21 | } |
|
22 | 22 | |
|
23 | 23 | VisualizationController::~VisualizationController() |
|
24 | 24 | { |
|
25 | qCDebug(LOG_VisualizationController()) | |
|
26 | << tr("VisualizationController destruction") << QThread::currentThread(); | |
|
25 | qCDebug(LOG_VisualizationController()) << tr("VisualizationController destruction") | |
|
26 | << QThread::currentThread(); | |
|
27 | 27 | this->waitForFinish(); |
|
28 | 28 | } |
|
29 | 29 | |
|
30 | 30 | void VisualizationController::initialize() |
|
31 | 31 | { |
|
32 | qCDebug(LOG_VisualizationController()) | |
|
33 | << tr("VisualizationController init") << QThread::currentThread(); | |
|
32 | qCDebug(LOG_VisualizationController()) << tr("VisualizationController init") | |
|
33 | << QThread::currentThread(); | |
|
34 | 34 | impl->m_WorkingMutex.lock(); |
|
35 | 35 | qCDebug(LOG_VisualizationController()) << tr("VisualizationController init END"); |
|
36 | 36 | } |
General Comments 5
Pull request updated. Auto status change to "Under Review"
Changed commits: * 6 added * 3 removed Changed files: * A gui/src/Visualization/VisualizationWidget.cpp * A gui/include/SidePane/SqpSidePane.h * A gui/include/Visualization/VisualizationGraphWidget.h * A gui/include/Visualization/VisualizationTabWidget.h * A gui/include/Visualization/VisualizationWidget.h * A gui/include/Visualization/VisualizationZoneWidget.h * A gui/include/Visualization/qcustomplot.h * A gui/src/SidePane/SqpSidePane.cpp * A gui/src/Visualization/VisualizationGraphWidget.cpp * A gui/src/Visualization/VisualizationTabWidget.cpp * A gui/src/Visualization/VisualizationZoneWidget.cpp * A gui/src/Visualization/qcustomplot.cpp * M gui/include/DataSource/DataSourceWidget.h * M gui/src/DataSource/DataSourceTreeWidgetItem.cpp * M gui/src/DataSource/DataSourceWidget.cpp * M app/src/Main.cpp * M app/src/MainWindow.cpp * M app/ui/MainWindow.ui * M core/include/DataSource/DataSourceController.h * M core/src/DataSource/DataSourceController.cpp * M core/tests/DataSource/TestDataSourceController.cpp * M gui/ui/visualization/VisualizationWidget.ui * M gui/vera-exclusions/exclusions.txt * M gui/src/visualization/VisualizationWidget.cpp * R cmake/sciqlop_package_qt.cmake * R core/include/Plugin/PluginManager.h * R core/include/Visualization/VisualizationController.h * R core/src/Plugin/PluginManager.cpp * R core/src/Visualization/VisualizationController.cpp * R gui/include/sidepane/SqpSidePane.h * R gui/include/visualization/VisualizationGraphWidget.h * R gui/include/visualization/VisualizationTabWidget.h * R gui/include/visualization/VisualizationWidget.h * R gui/include/visualization/VisualizationZoneWidget.h * R gui/include/visualization/qcustomplot.h * R gui/src/sidepane/SqpSidePane.cpp * R gui/src/visualization/VisualizationGraphWidget.cpp * R gui/src/visualization/VisualizationTabWidget.cpp * R gui/src/visualization/VisualizationZoneWidget.cpp * R gui/src/visualization/qcustomplot.cpp * R gui/ui/sidepane/SqpSidePane.ui * R gui/ui/visualization/VisualizationGraphWidget.ui * R gui/ui/visualization/VisualizationTabWidget.ui * R gui/ui/visualization/VisualizationZoneWidget.ui * R plugin/CMakeLists.txt * R plugin/cmake/Findsciqlop-plugin.cmake * R plugin/include/Plugin/IPlugin.h * R app/CMakeLists.txt * R app/include/MainWindow.h * R app/vera-exclusions/exclusions.txt * R cmake/sciqlop_applications.cmake * R core/CMakeLists.txt * R core/include/Common/spimpl.h * R gui/CMakeLists.txt * R gui/include/SqpApplication.h * R gui/src/SqpApplication.cpp * R app/src/mainwindow.ui
Status change > Approved
You need to be logged in to leave comments.
Login now