From 992eeb099247af3430ae22348ea0e28820cffd3f 2017-06-19 10:17:22
From: Alexandre Leroux <aleroux@itlink.fr>
Date: 2017-06-19 10:17:22
Subject: [PATCH] Removes VisualizationController::onVariableCreated() slot

The slot is replaced by a signal that only propagates the VariableController signal. This new signal will be intercepted by the VisualizationWidget to create a new graph from the created variable

---

diff --git a/core/include/Visualization/VisualizationController.h b/core/include/Visualization/VisualizationController.h
index 5a34df3..9664fe6 100644
--- a/core/include/Visualization/VisualizationController.h
+++ b/core/include/Visualization/VisualizationController.h
@@ -25,10 +25,11 @@ public:
     explicit VisualizationController(QObject *parent = 0);
     virtual ~VisualizationController();
 
-public slots:
-    /// Slot called when a variable has been created in SciQlop
-    void onVariableCreated(std::shared_ptr<Variable> variable) noexcept;
+signals:
+    /// Signal emitted when a variable has been created in SciQlop
+    void variableCreated(std::shared_ptr<Variable> variable);
 
+public slots:
     /// Manage init/end of the controller
     void initialize();
     void finalize();
diff --git a/core/src/Visualization/VisualizationController.cpp b/core/src/Visualization/VisualizationController.cpp
index 6e3bcc6..0f4d9fd 100644
--- a/core/src/Visualization/VisualizationController.cpp
+++ b/core/src/Visualization/VisualizationController.cpp
@@ -29,12 +29,6 @@ VisualizationController::~VisualizationController()
     this->waitForFinish();
 }
 
-void VisualizationController::onVariableCreated(std::shared_ptr<Variable> variable) noexcept
-{
-    /// @todo ALX : make new graph for the variable
-    qCDebug(LOG_VisualizationController()) << "new variable to display";
-}
-
 void VisualizationController::initialize()
 {
     qCDebug(LOG_VisualizationController()) << tr("VisualizationController init")
diff --git a/gui/src/SqpApplication.cpp b/gui/src/SqpApplication.cpp
index 8f2d0fa..5e46e93 100644
--- a/gui/src/SqpApplication.cpp
+++ b/gui/src/SqpApplication.cpp
@@ -31,7 +31,7 @@ public:
         qRegisterMetaType<std::shared_ptr<Variable> >();
         connect(m_VariableController.get(), SIGNAL(variableCreated(std::shared_ptr<Variable>)),
                 m_VisualizationController.get(),
-                SLOT(onVariableCreated(std::shared_ptr<Variable>)));
+                SIGNAL(variableCreated(std::shared_ptr<Variable>)));
 
         m_DataSourceController->moveToThread(&m_DataSourceControllerThread);
         m_VariableController->moveToThread(&m_VariableControllerThread);