From 96f042b3f3b15e9df15a090469b30ff8555b7701 2012-09-05 07:04:29
From: florianlink <florianlink@ea8d5007-eb21-0410-b261-ccb3ea6e24a9>
Date: 2012-09-05 07:04:29
Subject: [PATCH] made bool conversion more stable

git-svn-id: svn://svn.code.sf.net/p/pythonqt/code/trunk@231 ea8d5007-eb21-0410-b261-ccb3ea6e24a9

---

diff --git a/src/PythonQtConversion.cpp b/src/PythonQtConversion.cpp
index 237af03..c1d6888 100644
--- a/src/PythonQtConversion.cpp
+++ b/src/PythonQtConversion.cpp
@@ -742,8 +742,10 @@ bool PythonQtConv::PyObjGetBool(PyObject* val, bool strict, bool &ok) {
     d = true;
     ok = true;
   } else if (!strict) {
-    d = PyObjGetInt(val, false, ok)!=0;
-    ok = true;
+    int result = PyObject_IsTrue(val);
+    d = (result == 1);
+    // the result is -1 if an error occurred, handle this:
+    ok = (result != -1);
   }
   return d;
 }