From 6da6bce07af7b1b6b3a847bc04dad5677265e2f8 2010-02-20 20:32:36
From: florianlink <florianlink@ea8d5007-eb21-0410-b261-ccb3ea6e24a9>
Date: 2010-02-20 20:32:36
Subject: [PATCH] allow to pass invalid QVariants as QVariant parameter of slots

git-svn-id: svn://svn.code.sf.net/p/pythonqt/code/trunk@126 ea8d5007-eb21-0410-b261-ccb3ea6e24a9

---

diff --git a/src/PythonQtConversion.cpp b/src/PythonQtConversion.cpp
index 6251adc..8232fb3 100644
--- a/src/PythonQtConversion.cpp
+++ b/src/PythonQtConversion.cpp
@@ -537,9 +537,9 @@ void* PythonQtConv::ConvertPythonToQt(const PythonQtMethodInfo::ParameterInfo& i
      case PythonQtMethodInfo::Variant:
        {
          QVariant v = PyObjToQVariant(obj);
-         if (v.isValid()) {
-           PythonQtValueStorage_ADD_VALUE_IF_NEEDED(alreadyAllocatedCPPObject,global_variantStorage, QVariant, v, ptr);
-         }
+         // the only case where conversion can fail it None and we want to pass that to, e.g. setProperty(),
+         // so we do not check v.isValid() here
+         PythonQtValueStorage_ADD_VALUE_IF_NEEDED(alreadyAllocatedCPPObject,global_variantStorage, QVariant, v, ptr);
        }
        break;
        default: