Project

General

Profile

Actions
Copy link

Bug #567

closed

Analyse Logiscope FSW 3.0.0.10 : Several coding rules violations to be fixed

Added by bruno katra over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
bruno katra
Category:
-
Target version:
-
Start date:
30/11/2015
Due date:
% Done:

0%

Estimated time:
revision:
r0

Description

William a relevé plusieurs accrocs aux règles de codage dans le code du fsw 3.0.0.10. Certains datent déjà du FSW R2 (#243) et concerneraient les morceaux de code de Thomas (bp) qui est en watcher de cet issue.
En PJ se trouve le rapport complet de William, le résumé des problèmes à corriger est au "§6. Action Plan" :

AI-1 Comment frequency to be increase
AI-2 Don.Enumeration rule violation to be corrected: a lot of integer value used in the source code shall be replaced by constant or enumerated values.
AI-3 Don.Initialisation_P1 rule results to be analysed then justified or corrected.
AI-4 Don.Initialisation_P2 rule results to be analysed then justified or corrected.
AI-5 Don.Separee rule violation to be corrected
AI-6 Tr.Accolades rule violation on files fsw_misc.c and lfr_cpu_usage_report.c to be corrected
AI-7 Tr.BoucleSortie rule violation to be corrected, use of continue and break instruction forbidden.
AI-8 Tr.OrdreChoix rule violation to be corrected, default case to be added
AI-9 Tr.Parenthèses rule violation to be corrected

-------------------------
Tracké dans :
https://jira-lesia.obspm.fr/browse/RPWSWR-446
https://jira-lesia.obspm.fr/browse/RPWSWR-574

Files

RPW-MEB-LFR-NTT-00069_3.0_LFR_R3_Code_analysis.pdf (1.23 MB) RPW-MEB-LFR-NTT-00069_3.0_LFR_R3_Code_analysis.pdf bruno katra, 30/11/2015 04:47 PM
Actions
Copy link

Also available in: Atom PDF